From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41994)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1evOfK-0002O5-5D
	for guix-patches@gnu.org; Mon, 12 Mar 2018 10:43:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1evOfG-0002t9-9F
	for guix-patches@gnu.org; Mon, 12 Mar 2018 10:43:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49168)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1evOfG-0002sZ-4O
	for guix-patches@gnu.org; Mon, 12 Mar 2018 10:43:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1evOfF-0001tJ-QD
	for guix-patches@gnu.org; Mon, 12 Mar 2018 10:43:01 -0400
Subject: [bug#30765] [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced
	comma (unquote).
Resent-Message-ID: <handler.30765.B30765.15208657577227@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87vae3r38d.fsf@GlaDOS.home>
Date: Mon, 12 Mar 2018 15:42:32 +0100
In-Reply-To: <87vae3r38d.fsf@GlaDOS.home> (Diego Nicola Barbato's message of
	"Sat, 10 Mar 2018 23:10:42 +0100")
Message-ID: <87h8plnynb.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Diego Nicola Barbato <dnbarbato@posteo.de>
Cc: 30765@debbugs.gnu.org

Hello Diego,

Diego Nicola Barbato <dnbarbato@posteo.de> skribis:

> This patch fixes an issue where qTox failed to display some icons by
> moving qtsvg to propagated-inputs.
> I also took the liberty of fixing a misplaced comma (unquote).

The patch LGTM, but can you explain why propagating qtsvg allows icons
to be displayed?

In general we try to avoid propagated inputs because they =E2=80=9Cpollute=
=E2=80=9D the
user=E2=80=99s profile, so we should make sure there=E2=80=99s no other sol=
ution and add
a comment explaining why we do that.

Thanks!

Ludo=E2=80=99.