all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Diego Nicola Barbato <dnbarbato@posteo.de>
Cc: 30765@debbugs.gnu.org
Subject: [bug#30765] [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote).
Date: Mon, 12 Mar 2018 15:42:32 +0100	[thread overview]
Message-ID: <87h8plnynb.fsf@gnu.org> (raw)
In-Reply-To: <87vae3r38d.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Sat, 10 Mar 2018 23:10:42 +0100")

Hello Diego,

Diego Nicola Barbato <dnbarbato@posteo.de> skribis:

> This patch fixes an issue where qTox failed to display some icons by
> moving qtsvg to propagated-inputs.
> I also took the liberty of fixing a misplaced comma (unquote).

The patch LGTM, but can you explain why propagating qtsvg allows icons
to be displayed?

In general we try to avoid propagated inputs because they “pollute” the
user’s profile, so we should make sure there’s no other solution and add
a comment explaining why we do that.

Thanks!

Ludo’.

  reply	other threads:[~2018-03-12 14:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-10 22:10 [bug#30765] [PATCH] gnu: qtox: Propagate qtsvg and fix misplaced comma (unquote) Diego Nicola Barbato
2018-03-12 14:42 ` Ludovic Courtès [this message]
2018-03-12 15:00   ` Marius Bakke
2018-03-15  1:51     ` Diego Nicola Barbato
2018-03-15 21:18       ` bug#30765: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8plnynb.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=30765@debbugs.gnu.org \
    --cc=dnbarbato@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.