From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyklF-00008C-Po for guix-patches@gnu.org; Wed, 21 Mar 2018 16:55:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyklC-0004x0-MV for guix-patches@gnu.org; Wed, 21 Mar 2018 16:55:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38418) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyklC-0004ww-HT for guix-patches@gnu.org; Wed, 21 Mar 2018 16:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eyklC-0001U4-8r for guix-patches@gnu.org; Wed, 21 Mar 2018 16:55:02 -0400 Subject: [bug#30572] [PATCH 1/7] gnu: bootstrap: Add trivial packages for bash, mkdir, tar, and xz. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180222102933.4978-1-cmmarusich@gmail.com> <20180315040915.5556-1-cmmarusich@gmail.com> <20180315040915.5556-2-cmmarusich@gmail.com> <87370yl5y5.fsf@gnu.org> <87muz25a72.fsf@gmail.com> Date: Wed, 21 Mar 2018 21:54:37 +0100 In-Reply-To: <87muz25a72.fsf@gmail.com> (Chris Marusich's message of "Wed, 21 Mar 2018 05:22:57 +0100") Message-ID: <87h8p9f8tu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: 30572@debbugs.gnu.org Chris Marusich skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Chris Marusich skribis: >> >>> * gnu/packages/bootstrap.scm (bootstrap-binary): New procedure. >>> (%bootstrap-bash, %bootstrap-mkdir, %bootstrap-tar, %bootstrap-xz): >>> Use it to create these new packages, and export them. >> >> For =E2=80=98guix pack --bootstrap=E2=80=99, I believe we could avoid de= fining these >> packages and simply use =E2=80=98%bootstrap-coreutils&co=E2=80=99 when = =E2=80=98--bootstrap=E2=80=99 is >> used. >> >> Would that work for you? >> >> I=E2=80=99m asking because we may not keep these 4 binaries around forev= er. > > %bootstrap-coreutils&co requires a network connection to build. Is it > OK to use it in tests even though it requires a network connection? If > it's OK, then I'll use it, but I thought we wanted to avoid relying on a > network connection in tests, which is why I defined new packages that do > not rely on the network. Oh, I see. I think it=E2=80=99s OK to use =E2=80=98bootstrap-coreutils&co= =E2=80=99 nevertheless, and to simply check for networking in the test, as done in tests/guix-package-net.sh and tests/guix-environment.sh. The downside is that those tests will indeed require networking (though they remain cheap). The upside is that we don=E2=80=99t clutter the packag= e set with =E2=80=9Cweird=E2=80=9D packages. :-) Another option would be to define these packages in a temporary file in the test and add that to GUIX_PACKAGE_PATH, but maybe that=E2=80=99s overki= ll=E2=80=A6 Thoughts? Ludo=E2=80=99.