[bug#31046] [PATCH] gnu: chromaprint: Build fpcalc

[bug#31046] [PATCH] gnu: chromaprint: Build fpcalc

[Pierre Neidhardt]

* gnu/packages/mp3.scm (chromaprint): Build fpcalc
---
 gnu/packages/mp3.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 6dc58e2cc..f57ebf575 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -508,6 +508,7 @@ command-line tool.")
     (arguments
      `(#:tests? #f ; tests require googletest *sources*
        ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
+       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc
        #:test-target "check"))
     (inputs
      ;; requires one of FFmpeg (prefered), FFTW3 or vDSP
-- 
2.16.3

[bug#31046] [PATCH] gnu: chromaprint: Build fpcalc

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]


Toggle on the build of fpcalc, a commandline tool to compute the
fingerprint of audio files.

It's less than 40kb and does not require additional dependencies.
The size of the closure (as returned by ~guix size chromaprint~) is
510.3 MB, just like before the patch.

Considering how light it is, I don't think it's worth making a separate
output.

--
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#31046: [PATCH] gnu: chromaprint: Build fpcalc

[Ludovic Courtès]

Hello,

Pierre Neidhardt <ambrevar@gmail.com> skribis:

> * gnu/packages/mp3.scm (chromaprint): Build fpcalc
> ---
>  gnu/packages/mp3.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 6dc58e2cc..f57ebf575 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -508,6 +508,7 @@ command-line tool.")
>      (arguments
>       `(#:tests? #f ; tests require googletest *sources*
>         ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
> +       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc

[...]

> It's less than 40kb and does not require additional dependencies.
> The size of the closure (as returned by ~guix size chromaprint~) is
> 510.3 MB, just like before the patch.
>
> Considering how light it is, I don't think it's worth making a separate
> output.

Agreed.

I slightly adjusted the commit log to match the conventions and
committed.  Thank you!

Ludo’.

[bug#31046] [PATCH] gnu: chromaprint: Build fpcalc

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> I slightly adjusted the commit log to match the conventions and
> committed.  Thank you!

Thank you.

I'm a bit confused about the log conventions although I've read the GNU
standards.  Are there some unwritten rules?

Maybe it's just a matter of getting use to the change log :)

--
Pierre Neidhardt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#31046] [PATCH] gnu: chromaprint: Build fpcalc

[Ludovic Courtès]

Pierre Neidhardt <ambrevar@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> I slightly adjusted the commit log to match the conventions and
>> committed.  Thank you!
>
> Thank you.
>
> I'm a bit confused about the log conventions although I've read the GNU
> standards.  Are there some unwritten rules?

I think about everything is written down, maybe there are actually too
many written rules.  :-)

> Maybe it's just a matter of getting use to the change log :)

Yeah.  I’d suggest looking at past commits when in doubt.

Thanks,
Ludo’.