From: ludo@gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31046-done@debbugs.gnu.org
Subject: bug#31046: [PATCH] gnu: chromaprint: Build fpcalc
Date: Wed, 04 Apr 2018 13:56:02 +0200 [thread overview]
Message-ID: <87h8ordw31.fsf@gnu.org> (raw)
In-Reply-To: <20180403142356.9252-1-ambrevar@gmail.com> (Pierre Neidhardt's message of "Tue, 3 Apr 2018 19:53:56 +0530")
Hello,
Pierre Neidhardt <ambrevar@gmail.com> skribis:
> * gnu/packages/mp3.scm (chromaprint): Build fpcalc
> ---
> gnu/packages/mp3.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 6dc58e2cc..f57ebf575 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -508,6 +508,7 @@ command-line tool.")
> (arguments
> `(#:tests? #f ; tests require googletest *sources*
> ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
> + #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc
[...]
> It's less than 40kb and does not require additional dependencies.
> The size of the closure (as returned by ~guix size chromaprint~) is
> 510.3 MB, just like before the patch.
>
> Considering how light it is, I don't think it's worth making a separate
> output.
Agreed.
I slightly adjusted the commit log to match the conventions and
committed. Thank you!
Ludo’.
next prev parent reply other threads:[~2018-04-04 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 14:23 [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc Pierre Neidhardt
2018-04-03 14:28 ` Pierre Neidhardt
2018-04-04 11:56 ` Ludovic Courtès [this message]
2018-04-04 13:23 ` Pierre Neidhardt
2018-04-04 14:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8ordw31.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31046-done@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.