From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f98mJ-0003Jj-VH for guix-patches@gnu.org; Thu, 19 Apr 2018 08:35:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f98mE-0001fg-44 for guix-patches@gnu.org; Thu, 19 Apr 2018 08:35:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52300) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f98mE-0001fW-0u for guix-patches@gnu.org; Thu, 19 Apr 2018 08:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f98mD-0005Xp-Ls for guix-patches@gnu.org; Thu, 19 Apr 2018 08:35:01 -0400 Subject: [bug#31114] [PATCH] gnu: Add fortune-mod. Resent-Message-ID: References: <20180409173217.7629-1-ambrevar@gmail.com> <878t9w9t57.fsf@gmail.com> <877epggl1x.fsf@gnu.org> <87efjnfsmq.fsf@gmail.com> <87d0z7frr7.fsf@gmail.com> <87a7ub8j1b.fsf@gnu.org> <87efjnowut.fsf@gmail.com> <87a7tzmse1.fsf@gnu.org> From: Pierre Neidhardt In-reply-to: <87a7tzmse1.fsf@gnu.org> Date: Thu, 19 Apr 2018 18:04:08 +0530 Message-ID: <87h8o7iddr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31114-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Pierre, > > I=E2=80=99ve applied it all after fixing trivial issues reported by =E2= =80=98guix lint=E2=80=99. > I was able to get a few fortune cookies already, so thank you. :-) I did run `guix lint` if I'm not mistaken, I don't remember any issue. What were those? > Pierre Neidhardt skribis: > >> + (native-inputs >> + `(("perl" ,perl) >> + ;; The following is only needed for tests. >> + ("perl-file-find-object" ,perl-file-find-object) >> + ("perl-test-differences" ,perl-test-differences) >> + ("perl-class-xsaccessor" ,perl-class-xsaccessor) >> + ("perl-io-all" ,perl-io-all) >> + ("perl-test-runvalgrind" ,perl-test-runvalgrind) >> + ("cmake-rules" >> + ,(origin >> + (method url-fetch) >> + (uri (string-append "https://bitbucket.org/shlomif/shlomif-c= make-modules/" >> + "raw/default/shlomif-cmake-modules/Shlom= if_Common.cmake")) >> + (sha256 >> + (base32 "0kx9s1qqhhzprp1w3b67xmsns0n0v506bg5hgrshxaxpy6lqiw= b2")))))) > > I=E2=80=99m afraid the above URL is referring to the tip of that reposito= ry, and > thus that contents may change over time. Could you come up with a > stable URL, i.e., one that includes a commit ID? Sure, I think https://bitbucket.org/shlomif/shlomif-cmake-modules/raw/c505713d7a7cda608f= 97f01577e5868a711b883e/shlomif-cmake-modules/Shlomif_Common.cmake should do. Out of curiosity, why did you close the bug / merge the patch with the URL issue mentioned above? =2D-=20 Pierre Neidhardt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlrYjMAACgkQm9z0l6S7 zH8gpwf/ZX3dncMqshYuEU6gwh37LnwGvQk3kvvfDfUgOHVyAf3RscRhAVSa2hSm e4LOHTDjV/IstXd6ph4UXxweHne3KEfqZQRgIN5/cyhFgT3AFBdJAEi2hQJp4fon 1PMJu+OukO2Z1jObBAnyLcrxsfeY9CGOfTgwuPsoOn5fLmfy+4Jq2/e+rxb4U1fa kXa/X8GoJx4xnO9KUoY0OA4/lO4f7yy+w5U4ba3B11+V31xiaIAZAKr3gXmyftD3 hSxMqgaWL7RLcFa0mnTjOF9xiphpcVsQ5i0dVvCB1gsp87EbEluIRX8mN+4BkO74 mkKOzkpQahiWXBvOVi47hust137dsQ== =hHfn -----END PGP SIGNATURE----- --=-=-=--