From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: Web interface review Date: Sat, 21 Jul 2018 16:50:07 +0200 Message-ID: <87h8ksmyn4.fsf@lassieur.org> References: <87sh4encn4.fsf@lassieur.org> <87k1pq5k87.fsf@lassieur.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgtD7-0006yE-Ir for guix-devel@gnu.org; Sat, 21 Jul 2018 10:50:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgtD4-0003RT-HR for guix-devel@gnu.org; Sat, 21 Jul 2018 10:50:17 -0400 Received: from mail.lassieur.org ([83.152.10.219]:60338) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fgtD4-0003Qp-5k for guix-devel@gnu.org; Sat, 21 Jul 2018 10:50:14 -0400 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tatiana Sholokhova Cc: guix-devel Hello Tatiana! Tatiana Sholokhova writes: > Hello Cl=C3=A9ment! > > Thank you for your review! > > I fixed most of the problems you noticed and rebased commits as you advis= ed > . > > I couldn't fix the problem with several calling of (with-critical-section= ). > As I wrote to IRC channel, I tried to put '(with-critical-section > db-channel (db)' around '(let* ...)' and I received an error: > ``` > In web/server.scm: > 279:25 0 (_) > Throw to key `vm-error' with args `(vm-run "Too few values returned to > continuation" ())'. > ``` It's because 'respond-html' returns several values. I think you could do: (respond-html (with-critical-section ... (let* ...))) > Could you give a status about the pagination? >> > Pagination works correctly with evaluations, but it doesn't work correctly > with builds. In some cases, we have builds missing. It happens due to equ= al > timestamp values, so we need to filter build by (timestamp, id) tuple key. > > What else do we need to do before the merge? Once we have something consistent, we can push. And we can add stuff afterwards of course. Do you think it would be feasible to fix the pagination before the merge? I won't have time to look at your update before tomorrow night, I'll let you know then! Thanks, Cl=C3=A9ment