From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwwWv-00028j-J0 for guix-patches@gnu.org; Mon, 03 Sep 2018 17:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fwwWt-0000Ig-S8 for guix-patches@gnu.org; Mon, 03 Sep 2018 17:37:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fwwWt-0000IO-Nc for guix-patches@gnu.org; Mon, 03 Sep 2018 17:37:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fwwWt-0008Ea-En for guix-patches@gnu.org; Mon, 03 Sep 2018 17:37:03 -0400 Subject: [bug#32614] [PATCH] emacs-irony-mode Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <1c7a4813-8116-f13f-d65f-5bcac343b89d@yahoo.de> Date: Mon, 03 Sep 2018 23:36:37 +0200 In-Reply-To: <1c7a4813-8116-f13f-d65f-5bcac343b89d@yahoo.de> (Tim Gesthuizen's message of "Sun, 2 Sep 2018 21:16:23 +0200") Message-ID: <87h8j6uuu2.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tim Gesthuizen Cc: 32614@debbugs.gnu.org Hello Tim, Tim Gesthuizen skribis: > The attached patch adds emacs-irony-mode. > It is also packaged in MELPA so it is definitely free software. > If there are problems with the description or synopsis just let me know > and I will change the patch accordingly. Thanks for the patch! I have some suggestions and comments below, but overall it LGTM: > From 6975ba9e4b005c77f00d7f2187b5d8047f15ba07 Mon Sep 17 00:00:00 2001 > From: Tim Gesthuizen > Date: Thu, 30 Aug 2018 17:39:57 +0200 > Subject: [PATCH] gnu: Add emacs-irony-mode > > --- > gnu/packages/emacs.scm | 49 ++++++++++++++++++++++++++++++++++++------ Please run =E2=80=98git log gnu/packages/emacs.scm=E2=80=99 to see our conv= entions for commit logs, or see . (We can always fix it up for you though, it=E2=80=99s no big deal.) > + (home-page "https://github.com/Sarcasm/irony-mode") > + (synopsis "Clang autocompletion and syntax checking integration for = GNU Emacs") It=E2=80=99s a bit long. Perhaps: =E2=80=9CCode completion and syntax chec= ks for Emacs=E2=80=9D? > + (description "Provides clang assisted syntax checking and autocomple= tion > + for C,C++ and ObjC.") Please make a full sentence, as per . > + (license license:gpl3))) Isn=E2=80=99t it =E2=80=98gpl3+=E2=80=99, meaning =E2=80=9Cversion 3 or any= later version, at your option=E2=80=9D? > +(define-public emacs-irony-mode-server > + (package (inherit emacs-irony-mode) > + (name "emacs-irony-mode-server") > + (propagated-inputs > + `(("clang" ,clang))) Instead of propagating Clang, which clutters the user=E2=80=99s profile, do= you think we could patch the .el files such that they refer to =E2=80=98clang= =E2=80=99 by its absolute file name? See =E2=80=98emacs-emms=E2=80=99 for an example of= that. > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (invoke "cmake" > + "server" > + (string-append "-DCMAKE_INSTALL_PREFIX=3D" out)))= ))))) Please return #t at the end of the phase. > (source (origin > - (method url-fetch) > - (uri (string-append "https://github.com/smihica/emmet-mode" > - "/archive/" version ".tar.gz")) > + (method url-fetch) > + (uri (string-append "https://github.com/smihica/emmet-mode" > + "/archive/" version ".tar.gz")) > (file-name (string-append name "-" version ".tar.gz")) > - (sha256 > - (base32 > - "0g3p22yabfcp98cfv9dgl9il2m2pd53isq2q11vb3s7qyn31f7zj")))) > + (sha256 > + (base32 > + "0g3p22yabfcp98cfv9dgl9il2m2pd53isq2q11vb3s7qyn31f7zj"))= )) This change is unnecessary and unrelated; could you remove it? Could you send an updated patch? Thank you! Ludo=E2=80=99.