all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Guix build output insufficient
Date: Wed, 12 Sep 2018 19:52:45 +0200	[thread overview]
Message-ID: <87h8iuk3gy.fsf@elephly.net> (raw)
In-Reply-To: <87pnximx3e.fsf@tobias.gr>


Hi Tobias,

> Ricardo Wurmus wrote:
>> Note that the patch cannot be applied because I had to change how “@
>> build-failed” is treated.  The underlying problem here is that the
>> daemon may send a multi-line message through the port, which
>> unfortunately doesn’t necessarily arrive in one piece.
>>
>> AFAICS the only such message is the hash mismatch error.  If we
>> could
>> force it to remain on one line we could better format that
>> single-line
>> string in guix/ui.scm.
>
> Didn't we change this from a one-line message relatively recently? I
> vaguely remember supporting such a change (oops... :-)

Yes, it was a change to the formatting of the message.  I also supported
this change because it makes it much easier to see how the hashes
differ.

Now that we apply post-processing to the build output in guix/ui.scm
this early formatting gets in the way.

This happened in the daemon, though, and since people don’t update the
daemon as often as they update the rest of Guix, we may need to
accomodate both formats for a while.  I’d rather wait some more time
until more of wip-ui could be merged.

(The post-processing itself unfortunately has its own downsides: the
Emacs minor mode for build logs can no longer highlight the transformed
“@” messages.)

--
Ricardo

      reply	other threads:[~2018-09-12 17:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11  8:26 Guix build output insufficient Pjotr Prins
2018-09-11  9:04 ` Pjotr Prins
2018-09-11  9:55   ` Danny Milosavljevic
2018-09-11 10:41     ` Pierre Neidhardt
2018-09-11 11:59       ` Devan Carpenter
2018-09-11 11:52 ` Ricardo Wurmus
2018-09-11 14:23   ` Danny Milosavljevic
2018-09-12  6:52     ` Ricardo Wurmus
2018-09-12 15:25       ` Pjotr Prins
2018-09-13  6:45         ` Pjotr Prins
2018-09-13  7:23           ` Ricardo Wurmus
2018-09-12 17:09   ` Ludovic Courtès
2018-09-12 17:25     ` Ricardo Wurmus
2018-09-12 17:34       ` Tobias Geerinckx-Rice
2018-09-12 17:42       ` Tobias Geerinckx-Rice
2018-09-12 17:52         ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8iuk3gy.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.