* [bug#33088] [PATCH] gnu: pango-1.42.4: Propagate fribidi.
@ 2018-10-18 14:56 Stefan Stefanović
2018-11-06 18:52 ` Marius Bakke
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Stefanović @ 2018-10-18 14:56 UTC (permalink / raw)
To: 33088
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
Package pango-1.42.4 lint is OK. Package pango-1.42.4 build is OK.
Running make command, I get message "Some deprecated features have been used..."
After removing .../gtk.go file and running make again with environment variable
GUILE_WARN_DEPRECATED="detailed" I do not get the above warning.
Is it because I used "(@ (srfi srfi-1) alist-delete)" sexp?
(srfi srfi-1) module can be included using " #:use-module (srfi
srfi-1)" but I chose this form because alist-delete procedure is used
by me only in this one place.
[-- Attachment #2: 0001-gnu-pango-1.42.4-Propagate-fribidi.patch --]
[-- Type: text/x-patch, Size: 1225 bytes --]
From a89af17b9917c93d13133176f6cb5abcf52ca7fc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Stefanovi=C4=87?= <stefanx2ovic@gmail.com>
Date: Thu, 18 Oct 2018 16:31:46 +0200
Subject: [PATCH] gnu: pango-1.42.4: Propagate fribidi.
* gnu/packages/gtk.scm (pango-1.42.4)
[propagated-inputs]: Add fribidi to inherited pango propagated-inputs. New field.
[inputs]: Remove fribidi from inherited pango inputs. New field.
---
gnu/packages/gtk.scm | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 8c25922c9..e22be115b 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -265,7 +265,13 @@ used throughout the world.")
"pango-" version ".tar.xz"))
(sha256
(base32
- "17bwb7dgbncrfsmchlib03k9n3xaalirb39g3yb43gg8cg6p8aqx"))))))
+ "17bwb7dgbncrfsmchlib03k9n3xaalirb39g3yb43gg8cg6p8aqx"))))
+ (propagated-inputs
+ `(("fribidi" ,fribidi)
+ ,@(package-propagated-inputs pango)))
+ (inputs
+ `(,@((@ (srfi srfi-1) alist-delete)
+ "fribidi" (package-inputs pango))))))
(define-public pangox-compat
(package
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#33088] [PATCH] gnu: pango-1.42.4: Propagate fribidi.
2018-10-18 14:56 [bug#33088] [PATCH] gnu: pango-1.42.4: Propagate fribidi Stefan Stefanović
@ 2018-11-06 18:52 ` Marius Bakke
2018-11-06 20:41 ` Stefan Stefanović
0 siblings, 1 reply; 3+ messages in thread
From: Marius Bakke @ 2018-11-06 18:52 UTC (permalink / raw)
To: Stefan Stefanović, 33088
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
Hello!
Thanks for the patch. The problem with missing FriBidi propagation is
solved in the 'core-updates' branch with commit
698ec949079ae9930ff10c869ca1a90264c05210.
I'm hesitant to apply this on the 'master' branch because 'cairo-1.42.4'
is a replacement package. In practice, everything uses the "original"
cairo 1.42.0 at build time, where FriBidi is not listed in the
pkg-config files, so there should not be any problems for packages.
I'm guessing you found this issue in a `guix environment` or similar?
Since it's easy to work around, I'd rather "punt" on this patch and wait
for the core-updates merge, hopefully in a week or two.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#33088] [PATCH] gnu: pango-1.42.4: Propagate fribidi.
2018-11-06 18:52 ` Marius Bakke
@ 2018-11-06 20:41 ` Stefan Stefanović
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Stefanović @ 2018-11-06 20:41 UTC (permalink / raw)
To: Marius Bakke; +Cc: 33088
> I'm guessing you found this issue in a `guix environment` or similar?
I found this issue while packaging some software that is still in
alpha/beta state,
I will wait for the proper stable release before sending my patches.
> Since it's easy to work around, I'd rather "punt" on this patch and wait
> for the core-updates merge, hopefully in a week or two.
It not a problem, I can always use cario-1.42.0.
Feel free to close this patch any time you wish.
You do not need to apply this patch. ;)
Thank you,
for the explanation.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-06 20:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-18 14:56 [bug#33088] [PATCH] gnu: pango-1.42.4: Propagate fribidi Stefan Stefanović
2018-11-06 18:52 ` Marius Bakke
2018-11-06 20:41 ` Stefan Stefanović
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.