From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gs9oq-0000WF-Ar for guix-patches@gnu.org; Fri, 08 Feb 2019 12:20:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gs9op-0008OE-Is for guix-patches@gnu.org; Fri, 08 Feb 2019 12:20:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gs9op-0008OA-EF for guix-patches@gnu.org; Fri, 08 Feb 2019 12:20:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gs9op-0003He-39 for guix-patches@gnu.org; Fri, 08 Feb 2019 12:20:03 -0500 Subject: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba. Resent-Message-ID: References: <87zhrmgy0x.fsf@cbaines.net> <20190127114956.26570-1-mail@cbaines.net> <20190127114956.26570-11-mail@cbaines.net> <20190203231817.0a722915@alma-ubu> From: Christopher Baines In-reply-to: <20190203231817.0a722915@alma-ubu> Date: Fri, 08 Feb 2019 17:19:26 +0000 Message-ID: <87h8de5hb5.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 34217@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling writes: > On Sun, 27 Jan 2019 11:49:56 +0000 > Christopher Baines wrote: > >> These packages are mutually dependant, so I've put them in one commit. >> >> * gnu/packages/ruby.scm (ruby-aruba, ruby-cucumber): New variables. > > You missed to add the "...-without-tests" variables here. I wasn't quite sure whether to put only public things in the changelog, or everything. I've included them in the changelog now. >> +(define-public ruby-aruba >> + (package >> + (name "ruby-aruba") >> + (version "0.14.7") > > There is another update since yesterday: > 0.14.8 - February 02, 2019 (169 KB) Cool, I've updated to this new version. >> +;; A version of ruby-aruba without tests run so that circular >> dependencies can +;; be avoided. >> +(define ruby-aruba-without-tests >> + (package >> + (inherit ruby-aruba) >> + (arguments '(#:tests? #f)) >> + (propagated-inputs >> + (map (lambda (input) >> + (if (string=3D? (car input) "ruby-cucumber") >> + `("ruby-cucumber" ,ruby-cucumber-without-tests) >> + input)) >> + (package-propagated-inputs ruby-aruba))) > > This is really nit-picking, I haven't tried it out myself and I haven't > used it much myself, but I think this could be written more elegant with > match-lambda [syntax errors might be included]: > > (map (match-lambda > (("ruby-cucumber" . pkg) > `("ruby-cucumber" ,ruby-cucumber-without-tests)) > (input input) > ...) I've changed this to use alist-delete which Ricardo suggested as I think that's the most straight forward. Thanks for the your comments, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxduh5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XcoAQ/+PsfkYX6SLS0tkPCfgzBPZbtihHs3mlTYTZ1TOdJBCBdedQXWk1Bvkaop 5cCV9mLWnocfC8bygh0HSgTP2fGOuNT/9i4hwcrDEukHUxAuCgDSnzrU98FAoppZ q9L7TZP+2bjsBPDQ+a7EgoUggOl2cfN1wL9+u/2K85K627TK9KaXXG9eAhnezvtw 64B8yHRLk/bPgy5hd8MjYf/L5QbC5yHFpTMopuFv0B5KkZvMQVjDRH69H+FA2l/d 01MsqXtJpgGtmphXQp+LurTXRRbXD4WW26CUy43L1MtmPbP0oBxNJKcLQ6hm6bNw vpo+f0pmV2RUZ+HpkU9hsGHxtO3n3BO4rZlrXlErpEY6bawKwqV4fkALqSDjE5at fAwuJNIE7Rwu0cm9Kve1FHvakAPjss9Om0nrfTueS8BFPN65GMkEKjrCJhPY+wRP eZjnS6qdxGR2XT6+HENRX8pSvY3l+2+D2hp6TjZC5mvMAgOrYwc7KQapTC8rsQ7B 9/RzSgvel8UbgL6RLVdwc1WRty29PNXQui0gFZ5F3LsA0UhAB7qJ/rBqglU7YkRh ozvo1wG1gJpj5/TWmQzSfniv90fh2eNFPaGtCy2ScdnXOJRCUPM128dyl2MgWCqU sHSfgOaI7hldpKS/27lsJ9L1SmCpF8ekSAoZkoTURLSC2zO9hT4= =cELK -----END PGP SIGNATURE----- --=-=-=--