From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:55013)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gv2YZ-00067A-5n
	for guix-patches@gnu.org; Sat, 16 Feb 2019 11:11:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gv2YS-0007dj-NA
	for guix-patches@gnu.org; Sat, 16 Feb 2019 11:11:08 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:51188)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gv2YQ-0007cb-Dd
	for guix-patches@gnu.org; Sat, 16 Feb 2019 11:11:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gv2YQ-0003Ia-7m
	for guix-patches@gnu.org; Sat, 16 Feb 2019 11:11:02 -0500
Subject: [bug#34295] [PATCH] pull: Specify channels via command-line.
Resent-Message-ID: <handler.34295.B34295.155033344412647@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190203113749.14825-1-go.wigust@gmail.com>
Date: Sat, 16 Feb 2019 17:10:40 +0100
In-Reply-To: <20190203113749.14825-1-go.wigust@gmail.com> (Oleg Pykhalov's
	message of "Sun, 3 Feb 2019 14:37:49 +0300")
Message-ID: <87h8d3hfy7.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 34295@debbugs.gnu.org

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * guix/scripts/pull.scm (show-help, %options): Add 'channel'.
> (channel-list): Use this.
> * doc/guix.texi (Invoking guix pull): Document this.

Why not, but I wonder if we really want to do this much on the command
line?  Do you personally find it more convenient than having a
channels.scm file?

What do people think?

> +    (cond (channel-options
> +           (let ((channels (map alist->channel channel-options)))
> +             (if (null? (filter guix-channel? channels))
> +                 (append channels %default-channels)
> +                 channels)))

(null? (filter =E2=80=A6)) =E2=86=92 (not (any guix-channel? channels))

But note that %DEFAULT-CHANNELS possibly contains more than the 'guix
channel so this test is not quite accurate.

Thanks,
Ludo=E2=80=99.