From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#34778: Guix refresh -u fails
Date: Fri, 08 Mar 2019 23:30:09 +0100
Message-ID: <87h8cdc83y.fsf@gnu.org>
References: <CAE4v=ph1zTMNvUNjyYkz95-ZU_2ujpn=1gB31ZYf1TK6O4NmQg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:38083)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h2O19-0007Cr-Ti
	for bug-guix@gnu.org; Fri, 08 Mar 2019 17:31:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h2O19-0000CU-3a
	for bug-guix@gnu.org; Fri, 08 Mar 2019 17:31:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:51497)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h2O18-0000CG-UA
	for bug-guix@gnu.org; Fri, 08 Mar 2019 17:31:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h2O18-00018C-Oe
	for bug-guix@gnu.org; Fri, 08 Mar 2019 17:31:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.34778.D34778.15520842191698.done@debbugs.gnu.org>
In-Reply-To: <CAE4v=ph1zTMNvUNjyYkz95-ZU_2ujpn=1gB31ZYf1TK6O4NmQg@mail.gmail.com>
	("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Thu, 7 Mar 2019
	09:28:21 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: =?UTF-8?Q?G=C3=A1bor?= Boskovits <boskovits@gmail.com>
Cc: 34778-done@debbugs.gnu.org

Hi G=C3=A1bor,

G=C3=A1bor Boskovits <boskovits@gmail.com> skribis:

> guix refresh -u unibilium
> fails with the following backtrace:
> gabriel@guixsd ~/guix$ ./pre-inst-env guix refresh -u unibilium
> Backtrace:
>           14 (apply-smob/1 #<catch-closure 728c20>)
> In ice-9/boot-9.scm:
>     705:2 13 (call-with-prompt _ _ #<procedure default-prompt-handle=E2=
=80=A6>)
> In ice-9/eval.scm:
>     619:8 12 (_ #(#(#<directory (guile-user) 7ae140>)))
> In guix/ui.scm:
>   1654:12 11 (run-guix-command _ . _)
> In ice-9/boot-9.scm:
>     829:9 10 (catch _ _ #<procedure 7f7f2456b9b8 at guix/ui.scm:624=E2=80=
=A6> =E2=80=A6)
>     829:9  9 (catch _ _ #<procedure 7f7f2456b9d0 at guix/ui.scm:750=E2=80=
=A6> =E2=80=A6)
> In guix/scripts/refresh.scm:
>     513:8  8 (_)
> In guix/store.scm:
>   1737:24  7 (run-with-store _ _ #:guile-for-build _ #:system _ # _)
> In guix/scripts/refresh.scm:
>    531:16  6 (_ _)
> In srfi/srfi-1.scm:
>     640:9  5 (for-each #<procedure 289bd20 at guix/scripts/refresh.=E2=80=
=A6> =E2=80=A6)
> In guix/scripts/refresh.scm:
>    301:20  4 (update-package #<store-connection 256.99 93be10> #<pa=E2=80=
=A6> =E2=80=A6)
> In guix/upstream.scm:
>    374:22  3 (package-update #<store-connection 256.99 93be10> _ _ # _)
>    302:17  2 (download-tarball #<store-connection 256.99 93be10> #f # =E2=
=80=A6)
> In guix/download.scm:
>    568:55  1 (download-to-store #<store-connection 256.99 93be10> #f =E2=
=80=A6)
> In unknown file:
>            0 (basename #f #<undefined>)
>
> ERROR: In procedure basename:
> In procedure scm_to_utf8_stringn: Wrong type argument in position 1
> (expecting string): #f

This is because unibilium uses =E2=80=98git-fetch=E2=80=99, and currently =
=E2=80=98guix refresh
-u=E2=80=99 only knows how to download tarballs, it doesn=E2=80=99t know ho=
w to make Git
checkouts.

Commit 0bd1498fc40820be35125cc0a62482d015b58e9b fixes the issue by at
least reporting a proper error message.

We=E2=80=99ll have to adjust <upstream-source> to support not just tarball =
URLs,
as is currently the case, but also Git references.

Thanks,
Ludo=E2=80=99.