From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#33639: ISO installer image is broken on i686 Date: Mon, 08 Apr 2019 10:50:29 +0200 Message-ID: <87h8b8284q.fsf@gnu.org> References: <20190407201849.74qtwvazknbsaklg@pelzflorian.localdomain> <2660367208964033194@scdbackup.webframe.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:57787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDPzn-0002Tz-Vv for bug-guix@gnu.org; Mon, 08 Apr 2019 04:51:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDPzg-0005nS-DY for bug-guix@gnu.org; Mon, 08 Apr 2019 04:51:11 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35441) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDPza-0005gX-KG for bug-guix@gnu.org; Mon, 08 Apr 2019 04:51:05 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <2660367208964033194@scdbackup.webframe.org> (Thomas Schmitt's message of "Sun, 07 Apr 2019 23:35:16 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Thomas Schmitt Cc: bug-xorriso@gnu.org, 33639@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, "Thomas Schmitt" skribis: > The fact that the VM always sees the expected size but the host sees vary= ing > sizes supports the suspicion that at the end of the VM its i/o buffers or > virtual disk are not always properly flushed to the i/o system of the hos= t. > The varying success smells like a race condition. Indeed, that rings a bell: I fixed a similar issue in commit 0dc7d298a33f83d5f02a962b5f1bd24ee0e8ef07. Florian: could you check whether the patch below solves the problem for you? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index db9b1707d7..3ee03c84a0 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -240,7 +240,11 @@ made available under the /xchg CIFS share." #:target-arm32? #$(target-arm32?) #:disk-image-format #$disk-image-format #:disk-image-size size - #:references-graphs graphs)))))) + #:references-graphs graphs) + + ;; Make sure I/O buffers get flushed. This is particularly + ;; important when MAKE-DISK-IMAGE? is true. + (sync)))))) (gexp->derivation name builder ;; TODO: Require the "kvm" feature. @@ -530,10 +534,7 @@ should set REGISTER-CLOSURES? to #f." #$os #:compressor '(#+(file-append gzip "/bin/gzip") "-9n") #:creation-time (make-time time-utc 0 1) - #:transformations `((,root-directory -> ""))) - - ;; Make sure the tarball is fully written before rebooting. - (sync)))))) + #:transformations `((,root-directory -> "")))))))) (expression->derivation-in-linux-vm name build #:make-disk-image? #f --=-=-=--