From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#36777: Guix Inferiors: Curious incorrect derivation output bug
Date: Fri, 16 Aug 2019 23:03:23 +0200
Message-ID: <87h86gg6w4.fsf@gnu.org>
References: <TifHDa-L4paOnZQruSSv3YhpIdqMvwlk7pwnElq9azsMZwEdFv3-0usXgSQkV4nIOuKoJzv-BwIurwdecWYX-BTGUn2xZXAqQzefQp85W7M=@carldong.me>
 <875znps08a.fsf@gnu.org>
 <1WSz93jYl9XxYywM_b-gQYV4SiIG9VyTXLYpj4bueFcBZByRMIdXQNnVY4YDnbH_hPe4y_ZDjl7lIgyvynH8J85NtO93namyeEVMU7Lj9WY=@carldong.me>
 <87wog3i2sj.fsf@gnu.org> <87r26bi1x2.fsf@gnu.org>
 <rvQNShnNXKeE-TRrrP9SzUqXX4dJEB481poZeW9Rh_RZ7tgj7BRuBFnV049S2IfmM6v32jY1T8WM_zn5ZDX-2Kyfw16jm4wSaRshHnntHJQ=@carldong.me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:58580)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hyjOH-000328-Ct
 for bug-guix@gnu.org; Fri, 16 Aug 2019 17:04:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hyjOG-0003eb-A5
 for bug-guix@gnu.org; Fri, 16 Aug 2019 17:04:05 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46212)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hyjOG-0003eC-3d
 for bug-guix@gnu.org; Fri, 16 Aug 2019 17:04:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hyjOF-0004sH-Uz
 for bug-guix@gnu.org; Fri, 16 Aug 2019 17:04:03 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.36777.D36777.156598941218639.done@debbugs.gnu.org>
In-Reply-To: <rvQNShnNXKeE-TRrrP9SzUqXX4dJEB481poZeW9Rh_RZ7tgj7BRuBFnV049S2IfmM6v32jY1T8WM_zn5ZDX-2Kyfw16jm4wSaRshHnntHJQ=@carldong.me>
 (Carl Dong's message of "Tue, 30 Jul 2019 18:36:01 +0000")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Carl Dong <contact@carldong.me>
Cc: "36777@debbugs.gnu.org" <36777-done@debbugs.gnu.org>

Hi Carl,

Carl Dong <contact@carldong.me> skribis:

> Yes! The patch actually fixed the problem when applied on top of 5cf4b26d=
52bcea382d98fb4becce89be9ee37b55!

[...]

> Not sure what the next steps are for this, but I'd very much like to unde=
rstand where this went wrong. Perhaps we could write tests for this so it d=
oesn't happen in the future for releases.

Yup, I understood when this could happen (if multiple inputs of a
derivation are =E2=80=9Cfixed-output=E2=80=9D derivations leading to the sa=
me output),
wrote a test for that, and came up with a simpler fix in commit
268896444bed7b958add74b2e1e86ff802c5f5cb.

Let me know if anything is amiss!

Thanks for testing the patch,
Ludo=E2=80=99.