Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.

Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.

[Ludovic Courtès]

Hi there!

guix-commits@gnu.org skribis:

> commit 5a097cdd5446587511dbee049ad706366c74e5ad
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Sat Aug 31 03:23:16 2019 +0200
>
>     services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.
>     
>     * gnu/services/cups.scm (error-policy, cups-configuration): Substitute
>     RETRY-CURRENT-JOB for the obsolete RETRY-THIS-JOB name of this policy.
>     * doc/guix.texi (Printing Services): Likewise.

[...]

>  (define-enumerated-field-type error-policy
> -  (abort-job retry-job retry-this-job stop-printer))
> +  (abort-job retry-job retry-current-job stop-printer))

I’m not sure how ‘define-enumerated-field-type’ works, but can we add a
‘define-deprecated’ for ‘retry-this-job’ or similar?

Thanks,
Ludo’.

Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Ludo',

Ludovic Courtès 写道：
>>  (define-enumerated-field-type error-policy
>> -  (abort-job retry-job retry-this-job stop-printer))
>> +  (abort-job retry-job retry-current-job stop-printer))
>
> I’m not sure how ‘define-enumerated-field-type’ works, but 
> can we add a
> ‘define-deprecated’ for ‘retry-this-job’ or similar?

‘retry-this-job’ was never[0] valid, so I think failing loudly 
is the right thing to do here.  CUPS wouldn't have known what to 
do with it anyway.

Kind regards,

T G-R

[0]: https://github.com/apple/cups/issues/5301

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Tobias Geerinckx-Rice 写道：
> ‘retry-this-job’ was never[0] valid, so I think failing loudly 
> is
> the right thing to do here.  CUPS wouldn't have known what to do 
> with
> it anyway.

Sorry, sent too soon.  So: this was never more than a broken typo 
(albeit one that slipped in via CUPS itself), I don't think it 
deserves too much attention.  (Which I've now just given it :-)

G'night,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Re: 01/02: services: cups: Rename ‘retry-this-job’ to ‘retry-current-job’.

[Ludovic Courtès]

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Tobias Geerinckx-Rice 写道：
>> ‘retry-this-job’ was never[0] valid, so I think failing loudly is
>> the right thing to do here.  CUPS wouldn't have known what to do
>> with
>> it anyway.
>
> Sorry, sent too soon.  So: this was never more than a broken typo
> (albeit one that slipped in via CUPS itself), I don't think it
> deserves too much attention.  (Which I've now just given it :-)

Heh, makes sense.  :-)

Ludo’.