From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:54692)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iEJWZ-0006LU-Vq
 for guix-patches@gnu.org; Sat, 28 Sep 2019 16:41:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iEJWY-0001zg-T7
 for guix-patches@gnu.org; Sat, 28 Sep 2019 16:41:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42524)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iEJWY-0001zc-OE
 for guix-patches@gnu.org; Sat, 28 Sep 2019 16:41:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iEJWY-0001F1-Bo
 for guix-patches@gnu.org; Sat, 28 Sep 2019 16:41:02 -0400
Subject: [bug#37535] [PATCH] gnu: Add python-flask-cors.
Resent-Message-ID: <handler.37535.B37535.15697032594755@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <3f1fdf71-c664-4fb1-8ba1-f82e2d5f39b7@www.fastmail.com>
Date: Sat, 28 Sep 2019 22:40:50 +0200
In-Reply-To: <3f1fdf71-c664-4fb1-8ba1-f82e2d5f39b7@www.fastmail.com> (Hamzeh
 Nasajpour's message of "Sat, 28 Sep 2019 01:46:24 +0330")
Message-ID: <87h84wnoh9.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Hamzeh Nasajpour <h.nasajpour@pantherx.org>
Cc: 37535@debbugs.gnu.org

Hi Hamzeh,

"Hamzeh Nasajpour" <h.nasajpour@pantherx.org> skribis:

> * gnu/packages/python-web.scm (python-flask-cors): New variable.

[...]

> +(define-public python-flask-cors
> +  (package
> +  (name "python-flask-cors")
> +    (version "3.0.7")

The indentation is different from what we usually do.  Could you run
./etc/indent-code.el as noted at
<https://guix.gnu.org/manual/en/html_node/Formatting-Code.html>?

> +    (arguments
> +      `(#:tests? #f))

Could you try to run the test suite or, as a last resort, add a comment
explaining why it is disabled?

> +    (home-page "https://github.com/corydolphin/flask-cors")
> +    (synopsis "A Flask extension adding a decorator for CORS support")
> +    (description
> +     "A Flask extension for handling Cross Origin Resource Sharing (CORS=
),=20
> +making cross-origin AJAX possible.")

Please fix the issue reported by =E2=80=98guix lint=E2=80=99 for the synops=
is and make a
full sentence for the description.  See
<https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html>.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.