From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:52453) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihFv9-0001O8-PD for guix-patches@gnu.org; Tue, 17 Dec 2019 11:42:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihFv8-0003kv-CU for guix-patches@gnu.org; Tue, 17 Dec 2019 11:42:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihFv8-0003ka-92 for guix-patches@gnu.org; Tue, 17 Dec 2019 11:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihFv8-0003If-6r for guix-patches@gnu.org; Tue, 17 Dec 2019 11:42:02 -0500 Subject: [bug#38630] Software Heritage (swh): Fix API change, causing repeatedly submitting archives Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20191215223433.5ce5be20@alma-ubu> Date: Tue, 17 Dec 2019 17:41:04 +0100 In-Reply-To: <20191215223433.5ce5be20@alma-ubu> ("=?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?="'s message of "Sun, 15 Dec 2019 22:34:33 +0100") Message-ID: <87h81yrjkv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 38630@debbugs.gnu.org Hello! Bj=C3=B6rn H=C3=B6fling skribis: > when linting, I recognized that the archival linter was repeatedly > sending packages to the SWH, despite that the package was already > archived. > > With some investigations, I noticed they changed the API. Here's a > patch that fixes it. Good catch! > I have not communicated with SWH about that, especially I have not asked > SWH why they broke the API without updating the version number. Yeah, that=E2=80=99s weird, I=E2=80=99ve pinged them on IRC. It seems that the removal was intentional as part of , but it wasn=E2=80=99t clear whe= ther the API breakage should have happened. This led them to open a new task: . We should keep an eye on it. > From a5ada85d168b45d517d8faf0d79ad5beccc26911 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Bj=3DC3=3DB6rn=3D20H=3DC3=3DB6fling?=3D > > Date: Sun, 15 Dec 2019 22:00:56 +0100 > Subject: [PATCH] swh: Fix API call for getting origin. > > When using the archival linter, git origins already in the archive where > not recognized due to an API change and where repeatedly asked for archiv= al. > This is fixed here. > > * guix/swh.scm (lookup-origin): Fix API URI for getting origin. > (): Fix comment with API URI example. In the meantime, your patch looks like the right move, so you can push it. Thank you! Ludo=E2=80=99.