From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:35710)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ihgcx-00054b-Ob
 for guix-patches@gnu.org; Wed, 18 Dec 2019 16:13:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ihgcw-00013Q-NC
 for guix-patches@gnu.org; Wed, 18 Dec 2019 16:13:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:38048)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ihgcw-00013H-EO
 for guix-patches@gnu.org; Wed, 18 Dec 2019 16:13:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ihgcw-0002jw-A6
 for guix-patches@gnu.org; Wed, 18 Dec 2019 16:13:02 -0500
Subject: bug#38513: [PATCH] gnu: Remove uses of deprecated Qemu "-nic,
 model=foo" invokations.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.38513.D38513.157670353710474.done@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <87fthmwkmv.fsf@gnu.org>
References: <20191206211304.2724-1-mbakke@fastmail.com>
 <87fthmwkmv.fsf@gnu.org>
Date: Wed, 18 Dec 2019 22:12:08 +0100
Message-ID: <87h81xcp93.fsf@devup.no>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 38513-done@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Hi!
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> * gnu/build/vm.scm (load-in-linux-vm): Move Qemu network configuration f=
rom
>> ARCH-SPECIFIC-FLAGS to the Qemu command line.  Use the "-nic" option of =
Qemu
>> instead of "-device" and "-net".
>> * gnu/system/vm.scm (common-qemu-options): Change "-net nic ..." to "-ni=
c user ...".
>> * doc/guix.texi (Installing Guix in a VM, Running Guix in a VM): Adjust
>> examples accordingly.
>
> Apart from the typo Leo noted, it LGTM!  :-)

I discovered a problem with our documentation when researching this
patch.  Qemu nowadays, with no "-nic" or related arguments, acts the
same as "-nic,model=3De1000e".  So a full network is available by default,
unless one adds "-nic none".

The "Running Guix in a VM" section of the manual mentions Qemu
networking twice, and both are inaccurate or wrong.  It would be good to
reword that section.  Any takers?  :-)

In any case this patch will be pushed shortly.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEyBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl36ligACgkQoqBt8qM6
VPrmJAf1EMRULM6b/0BotAJ3xFCDGlZGNknMeiMab5xJfXjo9bJumu2kn25wnLcT
czcyxkabTYzEtyKLq7xFHMZQYPBi2R1S4KUG/GAgulsRvnC9g+qEF5s0gqEmsXBk
M2QmELGNCqjd27vzSil2F6xtstnxxpEpotQtDESzAVB2C4c8cBOBXmDGF159vECa
p80qOJRSTZkBQjufgWwEgqvZ2mFmahqTYmRXKahwbYYmgGpqJ3hpqXMBl4dKWpkb
rgnJr5256NNPScABINvIMP1LLWHkBmtjcYfry9pG3+wX+g0ybVRQogU0mVVRGjrO
HgP4JygJ779JWyCT8q2M9VbTzJXz
=Rvv8
-----END PGP SIGNATURE-----
--=-=-=--