From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:36040)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1isCPx-0003PG-Qi
 for guix-patches@gnu.org; Thu, 16 Jan 2020 16:11:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1isCPu-0004VN-1i
 for guix-patches@gnu.org; Thu, 16 Jan 2020 16:11:05 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:60711)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1isCPt-0004VD-Tq
 for guix-patches@gnu.org; Thu, 16 Jan 2020 16:11:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1isCPt-0008MP-PR
 for guix-patches@gnu.org; Thu, 16 Jan 2020 16:11:01 -0500
Subject: [bug#39086] [PATCH 4/5] gnu: ibus: Build with emoji support.
Resent-Message-ID: <handler.39086.B39086.157920905532124@debbugs.gnu.org>
References: <20200111120829.29821-1-leo.prikler@student.tugraz.at>
 <20200111120829.29821-4-leo.prikler@student.tugraz.at>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20200111120829.29821-4-leo.prikler@student.tugraz.at>
Date: Thu, 16 Jan 2020 22:10:37 +0100
Message-ID: <87h80vxg36.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 39086@debbugs.gnu.org


Leo Prikler <leo.prikler@student.tugraz.at> writes:

> * gnu/packages/ibus.scm (ibus) [inputs]: Add unicode-emoji and
> unicode-cldr-common.
> [configure-flags]: Add flags for emoji and annotations.

This should be =E2=80=9Carguments=E2=80=9D, not =E2=80=9Cconfigure-flags=E2=
=80=9D.  Also: please remove
the space between =E2=80=9C(ibus)=E2=80=9D and =E2=80=9C[inputs]=E2=80=9D.

>      (arguments
>       `(#:tests? #f  ; tests fail because there's no connection to dbus
> -       #:configure-flags `("--disable-emoji-dict" ; cannot find emoji.js=
on path
> -                           "--enable-python-library"
> +       #:configure-flags `("--enable-python-library"
> +                           ,(string-append
> +                             "--with-unicode-emoji-dir=3D"
> +                             (assoc-ref %build-inputs "unicode-emoji")
> +                             "/share/unicode/emoji")
> +                           ,(string-append
> +                             "--with-emoji-annotation-dir=3D"
> +                             (assoc-ref %build-inputs "unicode-cldr-comm=
on")
> +                             "/share/unicode/cldr/common/annotations")
>                             ,(string-append "--with-ucd-dir=3D"
>                                             (getcwd) "/ucd")
>                             "--enable-wayland")

Now that the configure flags are so long I have a preference for
dropping quoting and using (list =E2=80=A6) instead.  All that unquoting lo=
oks a
little too noisy.

> @@ -241,6 +248,8 @@ conventions.")
>       `(("glib" ,glib "bin") ; for glib-genmarshal
>         ("gobject-introspection" ,gobject-introspection) ; for g-ir-compi=
ler
>=20=20
> +       ("unicode-emoji" ,unicode-emoji)
> +       ("unicode-cldr-common" ,unicode-cldr-common)
>         ;; XXX TODO: Move Unicode data to its own (versioned) package.
>         ("unicode-nameslist"
>          ,(origin

Oh, here is the comment I mentioned earlier!

--=20
Ricardo