From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:49740)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKl7T-0003f3-8r
 for guix-patches@gnu.org; Sat, 04 Apr 2020 11:54:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKl7S-0006hj-Bl
 for guix-patches@gnu.org; Sat, 04 Apr 2020 11:54:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:33058)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jKl7S-0006hc-8n
 for guix-patches@gnu.org; Sat, 04 Apr 2020 11:54:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKl7S-00066C-5w
 for guix-patches@gnu.org; Sat, 04 Apr 2020 11:54:02 -0400
Subject: [bug#40274] [PATCH v6 2/2] gnu: Add kernel-module-loader-service.
Resent-Message-ID: <handler.40274.B40274.158601563723423@debbugs.gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
References: <20200328135908.2540-1-brice@waegenei.re>
 <20200404151732.20341-1-brice@waegenei.re>
 <20200404151732.20341-3-brice@waegenei.re>
Date: Sat, 04 Apr 2020 17:53:47 +0200
In-Reply-To: <20200404151732.20341-3-brice@waegenei.re> (Brice Waegeneire's
 message of "Sat, 4 Apr 2020 17:17:32 +0200")
Message-ID: <87h7xztfg4.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 40274@debbugs.gnu.org


Hello Brice,

I think what you discussed with Danny, separating module loading from
configuration is very wise.

> +The kernel module loader service allows one to load, at boot, loadable
> +kernel modules---in opposition to built-in kernel modules which should
> +be added to the @code{kernel-arguments} field instead.  This is

Using kernel-arguments you can configure built-in modules but you cannot
force them to show-up, at least for most device drivers. For those
device drivers, loading of built-in modules is based on hardware probing
at boot-time. 

So I would just stick with:

"The kernel module loader service allows one to load, at boot time,
specific kernel modules."

> +(define ddcci-config
> +  (plain-file "ddcci.conf"
> +              "options ddcci dyndbg delay=120"))

Having the modprobe-service-type you proposed earlier, would be super
nice to do that :)

> +
> +(operating-system
> +  ...
> +  (services (cons* (service kernel-module-loader-service-type
> +                            '("ddcci" "ddcci_backlight"))
> +                   (simple-service 'ddcci-config etc-service-type
> +                                   (list `("modprobe.d/ddcci.conf"
> +                                           ,ddcci-config)))

Great!

This seems really nice to me.

Mathieu