From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50152) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOGdw-0001MW-CL for guix-patches@gnu.org; Tue, 14 Apr 2020 04:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOGdv-0005Ak-6J for guix-patches@gnu.org; Tue, 14 Apr 2020 04:10:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49880) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOGdu-0005AH-2T for guix-patches@gnu.org; Tue, 14 Apr 2020 04:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOGdt-0003Em-Tl for guix-patches@gnu.org; Tue, 14 Apr 2020 04:10:01 -0400 Subject: [bug#40622] new package 'flowee'. Resent-Message-ID: From: Nicolas Goaziou References: <6313128.DvuYhMxLoT@cherry> Date: Tue, 14 Apr 2020 10:09:36 +0200 In-Reply-To: <6313128.DvuYhMxLoT@cherry> (Tom Zander via Guix-patches via's message of "Tue, 14 Apr 2020 09:27:00 +0200") Message-ID: <87h7xmwksf.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 40622@debbugs.gnu.org Cc: tomz@freedommail.ch Hello, Tom Zander via Guix-patches via writes: > Please merge. Thank you. I have some comments first. :) > (sha256 > - (base32 "1c1hkik8avill8ha33g76rk4b03j5ac8wiml69q4jav7a63ywgfy")))) > + (base32 "1ajd5axv9zyhh6njrvamm11zn52j1q4j3mwn2nfv7cjd4lhnhlsr")))) This change is unrelated. > (build-system gnu-build-system) > (arguments > `(#:phases > @@ -1440,6 +1440,70 @@ walets in a fast and small server. The full data is stored in a full node, > like Flowee the Hub, which Fulcrum connects to over RPC.") > (license license:gpl3+))) > > +(package > + (name "flowee") > + (version "2020.03.1") You forgot to define a variable for this package. > + (source (origin > + (method url-fetch) > + (uri (string-append "https://gitlab.com/FloweeTheHub/thehub/-/archive/" > + version "/thehub-" version ".tar.gz")) > + (sha256 > + (base32 > + "1w20haldxlnppi2lkn5xsmw8cnxpcc92yradhb823d2ih66ybp0l")))) Nitpick: I would move `origin' under `source' and `base32' on the same line as the string. > + (build-system cmake-build-system) > + (arguments > + `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF") > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'make-qt-deterministic > + (lambda _ > + ; Make Qt deterministic. Comments on a full line need two semicolons. > + (setenv "QT_RCC_SOURCE_DATE_OVERRIDE" "1") > + #t)) > + (add-before 'configure 'disable-black-box > + ; the black-box testing runs full hubs and lets them interact. > + ; this is more fragile and a slow machine, or low memory machine, may > + ; make the tests timeout and fail. We just disable them here. Ditto. > + (lambda _ > + (substitute* "testing/CMakeLists.txt" > + (("test_api") "")) > + #t)) > + (add-after 'configure 'set-build-info > + ; Their genbuild.sh to generate a build.h fails in guix (no .git dir) . > + ; Its purpose is to write the tag name in the build.h file. We do that > + ; here instead. See above. > + (inputs > + `(("boost" ,boost) > + ("libevent" ,libevent) > + ("miniupnpc" ,miniupnpc) > + ("qtbase" ,qtbase) > + ("gmp" ,gmp) > + ("openssl" ,openssl))) > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("util-linux" ,util-linux) ; provides the hexdump command for tests > + ("qttools" ,qttools))) Could you re-order inputs alphabetically? Could you send an updated patch? Regards, -- Nicolas Goaziou