From: "Ludovic Courtès" <ludo@gnu.org>
To: Marius Bakke <marius@gnu.org>
Cc: 42030@debbugs.gnu.org
Subject: [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction.
Date: Mon, 29 Jun 2020 17:14:40 +0200 [thread overview]
Message-ID: <87h7utc3a7.fsf@gnu.org> (raw)
In-Reply-To: <87o8p2ayaj.fsf@gnu.org> (Marius Bakke's message of "Mon, 29 Jun 2020 13:47:48 +0200")
Hi!
Marius Bakke <marius@gnu.org> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>>> I think we should export %guix-channel-introduction, or alternatively
>>> add a %default-guix-channel that can be inherited, for easy access in
>>> custom channels.scm files. WDYT?
>>
>> The idea was to expose only ‘%default-channels’, which leaves room for
>> the possibility of having multiple channels by default. I’d rather
>> avoid exposing the individual bits as that’s a bit of an additional
>> committment.
>>
>> But note that the introduction of the “official” guix channel is
>> automatically added anyway (commit
>> c3f6f564e909ebefe752d24b325871a4e3a02d40).
>
> It is only added for people using the default channel URL, and not for
> local mirrors that may well be authenticated. E.g. (url "/some/dir") or
> (url "https://github.com/guix-mirror/guix").
>
> Would it make sense to remove the %default-channel-url check from
> ensure-default-introductions? I think we can safely assume that a
> channel named 'guix is _the_ Guix channel regardless of where it came
> from, and if users need to override the introduction they can just do
> that.
I don’t think we can do that: if someone who’s not currently a committer
wants to publish a fork, they’ll also publish a different introduction,
pointing to the first commit where they’re in ‘.guix-authorizations’.
> Currently I do this to access the channel introduction, which seems
> needlessly complicated:
>
> (use-modules (srfi srfi-1))
> (let ((guix-channel (find (lambda (channel)
> (eq? 'guix (channel-name channel)))
> %default-channels)))
You can write: (find guix-channel? %default-channels).
> (list [other channels omitted]
> (channel
> (inherit guix-channel)
> (url "/home/marius/src/guix"))))
I’m hesitant. We can publish ‘%guix-channel-introduction’ if it helps,
but it’s a slight maintenance constraint for a slight improvement. :-)
WDYT?
Ludo’.
next prev parent reply other threads:[~2020-06-29 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 12:57 [bug#42030] [PATCH] channels: Error out when the 'guix' channel lacks an introduction Ludovic Courtès
2020-06-24 21:13 ` Marius Bakke
2020-06-25 9:29 ` Ludovic Courtès
2020-06-29 11:47 ` Marius Bakke
2020-06-29 15:14 ` Ludovic Courtès [this message]
2020-07-25 15:05 ` Marius Bakke
2020-06-28 21:31 ` bug#42030: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7utc3a7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=42030@debbugs.gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.