From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6H4eAqCuhV/oDgAA0tVLHw (envelope-from ) for ; Tue, 13 Oct 2020 13:41:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yCagOZ+uhV9NfwAA1q6Kng (envelope-from ) for ; Tue, 13 Oct 2020 13:41:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72C64940224 for ; Tue, 13 Oct 2020 13:41:51 +0000 (UTC) Received: from localhost ([::1]:55472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSKYo-0005Jm-7T for larch@yhetil.org; Tue, 13 Oct 2020 09:41:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSKYe-0005Ii-M7; Tue, 13 Oct 2020 09:41:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35588) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSKYe-0002xk-By; Tue, 13 Oct 2020 09:41:40 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=44212 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSKYd-0000gD-DJ; Tue, 13 Oct 2020 09:41:39 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jan Nieuwenhuizen Subject: raise(-1) succeeds for programs linked against libpthread References: <20201005100249.19995.93553@vcs0.savannah.gnu.org> <87h7r82740.fsf@gnu.org> <87sgaju53p.fsf@gnu.org> <87tuuzd6aq.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 =?utf-8?Q?Vend=C3=A9miaire?= an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 13 Oct 2020 15:41:37 +0200 In-Reply-To: <87tuuzd6aq.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Mon, 12 Oct 2020 13:37:01 +0200") Message-ID: <87h7qyjl9q.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, bug-hurd@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: sJVxnEWKf4vU Hi! (Cc: bug-hurd.) Jan Nieuwenhuizen skribis: >>> #include >>> >>> int >>> main (void) >>> { >>> if (!raise (-1)) >>> return 1; >>>=20=20=20 >>> return 0; >>> } >> >> I don=E2=80=99t know if it=E2=80=99s relevant here, but you should alway= s use =E2=80=98-pthread=E2=80=99 >> both at compile time and link time: >> >> gcc raise.c -pthread >> >> That typically defines a few macros that may or may not have an effect >> on the code at hand. > > Ah...right. Makes no difference, though: > > root@childhurd ~# guix environment --bootstrap --ad-hoc gcc-toolchain@7 > root@childhurd ~ [env]# gcc raise.c > root@childhurd ~ [env]# ./a.out > root@childhurd ~ [env]# echo $? > 0 > root@childhurd ~ [env]# gcc raise.c -pthread > root@childhurd ~ [env]# ./a.out > User defined signal 2 Interesting! In the second case, we=E2=80=99re using =E2=80=98__pthread_ki= ll=E2=80=99 from =E2=80=98pt-kill.c=E2=80=99 (instead of =E2=80=98kill=E2=80=99). The expected behavior is that =E2=80=98raise=E2=80=99 should return non-zer= o and EINVAL. =E2=80=98pthread_kill=E2=80=99 passes the signal number to =E2=80=98_hurd_r= aise_signal=E2=80=99, which assumes it is valid: --8<---------------cut here---------------start------------->8--- int _hurd_raise_signal (struct hurd_sigstate *ss, int signo, const struct hurd_signal_detail *detail) { if (ss =3D=3D NULL) { ss =3D _hurd_self_sigstate (); __spin_lock (&ss->lock); } /* Mark SIGNO as pending to be delivered. */ __sigaddset (&ss->pending, signo); ss->pending_data[signo] =3D *detail; --8<---------------cut here---------------end--------------->8--- I suppose that before calling =E2=80=98sigaddset=E2=80=99, it should check = whether SIGNO is within bounds, along the lines of: if (signo < 2 || signo >=3D _NSIG) return EINVAL; Does that make sense? Thanks, Ludo=E2=80=99.