From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yHz/CxyPlF/2ZgAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 20:31:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2AvdBxyPlF8oOwAAB5/wlQ (envelope-from ) for ; Sat, 24 Oct 2020 20:31:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 94E88940111 for ; Sat, 24 Oct 2020 20:31:23 +0000 (UTC) Received: from localhost ([::1]:45256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWQC9-0004MF-Fe for larch@yhetil.org; Sat, 24 Oct 2020 16:31:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWQBr-0004Lz-Si for guix-patches@gnu.org; Sat, 24 Oct 2020 16:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWQBq-0004Kr-Br for guix-patches@gnu.org; Sat, 24 Oct 2020 16:31:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWQBq-0005mS-7Y for guix-patches@gnu.org; Sat, 24 Oct 2020 16:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44181] [PATCH] gnu: Add atomicparsley. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandru-Sergiu Marton Cc: 44181@debbugs.gnu.org Received: via spool by 44181-submit@debbugs.gnu.org id=B44181.160357145422207 (code B ref 44181); Sat, 24 Oct 2020 20:31:02 +0000 Received: (at 44181) by debbugs.gnu.org; 24 Oct 2020 20:30:54 +0000 Received: from localhost ([127.0.0.1]:35276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWQBe-0005m1-Gw for submit@debbugs.gnu.org; Sat, 24 Oct 2020 16:30:54 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWQBb-0005lp-E8 for 44181@debbugs.gnu.org; Sat, 24 Oct 2020 16:30:48 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id 2F9CF27BBF0; Sat, 24 Oct 2020 21:30:46 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id fd3528fa; Sat, 24 Oct 2020 20:30:42 +0000 (UTC) References: <20201023212346.26664-1-brown121407@posteo.ro> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <20201023212346.26664-1-brown121407@posteo.ro> Date: Sat, 24 Oct 2020 21:30:35 +0100 Message-ID: <87h7qjbc44.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: kiqFu7Jn8w+p --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Thanks for the patch, I've put some comments inline below. Alexandru-Sergiu Marton writes: > * gnu/packages/video.scm (atomicparsley): New variable. > --- > gnu/packages/video.scm | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index bdccb6fdb7..5cf8b56ae1 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -44,6 +44,7 @@ > ;;; Copyright =C2=A9 2020 Michael Rohleder > ;;; Copyright =C2=A9 2020 Vinicius Monego > ;;; Copyright =C2=A9 2020 Brett Gilio > +;;; Copyright =C2=A9 2020 Alexandru-Sergiu Marton > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -4806,3 +4807,41 @@ BBC iPlayer output.") > includes @code{dvdxchap} tool for extracting chapter information from DV= D.") > (license license:gpl2) > (home-page "https://www.bunkus.org/videotools/ogmtools/"))) Looks like this is at the end of video.scm. That's OK, but often unwise as if everyone adds new packages to the end of the modules, the patches will often conflict. For that reason, it's normally helpful to add packages not at the end, I usually add it close to related packages, or those with a name close by in the alphabet. > + > +(define-public atomicparsley > + (package > + (name "atomicparsley") > + (version "20200701.154658.b0d6223") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/wez/atomicparsley") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1kym2l5y34nmbrrlkfmxsf1cwrvch64kb34jp0hpa0b89idbhwqh"))= )) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f So that someone looking at the package definition can tell why the tests are disabled, it would be good to add a comment saying why. If it's that the tests don't pass, then it can be a TODO comment. > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'set-cmake-version > + (lambda* _ > + (substitute* "CMakeLists.txt" > + (("VERSION 3.17") "VERSION 3.16")) > + #t)) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (install-file "AtomicParsley" bin)) > + #t))))) > + (inputs > + `(("zlib" ,zlib))) > + (synopsis "Metadata editor for MPEG-4 files") > + (description "AtomicParsley is a lightweight command line program for > +reading, parsing and setting metadata into MPEG-4 files, in particular, > +iTunes-style metadata.") > + (home-page "https://github.com/wez/atomicparsley") > + (license license:gpl2))) I had a look at the few source files, and they suggested that this is gpl2+, maybe there's a bit that's gpl2 only though? Would you be able to send an updated patch? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+UjutfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdKsQ/+JvIb0ar5vDZgHTO5Vx0LrZ2aZHdR61ed 1vehgNFvSIPxtgP5JwXZ+UkCwxQTLZIARt3cEbYltWu6TyxMTNBA5zuxF3u6DIiU cv0Bx43D+BOWEW/7U6egBtBouhEu/tWzcu2ZHF+lV4QeltED1VW04WT2Gck9QiQ2 bnQB51FUAFuBKhtjKKCgc7o7IrqggWq0fqzGojnNcXNvoHqiTm9lV7AiOktc248C tI42JGGoaPm/KlSp5ZXDE7gxrSBYIrlWGaqIrkP0FwYv1gXVLGBT6Jbo74HVBbac YoEXxOjUgQ3nKUpMR2I9bB4cMMO30dspPxRgnTmadO4Lg9KgUMFgPeAp2FkJEiK5 TGQb4YW2bCVgksdArh5VUzEmOx5k0zwTH7CJYUp/kVy9KAvfsrSOXhXLSsWQSvuD hLO19FXQKfXt6qumuS7Sr/Szud0sdfOGnMVDTuvcVGkaXHPHtJSE0DNd2YvVerOm BSo1PGpIY2SVP2HU1V9yZxH3er66PbkO2lw88J9UPexQHJI5tITQoQatVpYw4JMP HmqihdE2yFw9Sk7uW4hFH9WjL9NIuoyS3OlbBX9f8MlPj8ZH+zjOQs/OfAR/UzZA tq/E2QBUI7nu5x+aRxG9hiUmup3Sr7ZgZSNWaka5VtNG71Olmp9mvN19xaZCp/JF lw33axVx9tA= =ozaC -----END PGP SIGNATURE----- --=-=-=--