From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oIirMLe+218fMgAA0tVLHw (envelope-from ) for ; Thu, 17 Dec 2020 20:25:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qPt/LLe+21/MNgAA1q6Kng (envelope-from ) for ; Thu, 17 Dec 2020 20:25:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 30E5394042B for ; Thu, 17 Dec 2020 20:25:27 +0000 (UTC) Received: from localhost ([::1]:42384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpzq0-0000Rn-WC for larch@yhetil.org; Thu, 17 Dec 2020 15:25:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpzpg-0000Pk-Dl for bug-guix@gnu.org; Thu, 17 Dec 2020 15:25:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpzpf-0005ib-5L for bug-guix@gnu.org; Thu, 17 Dec 2020 15:25:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kpzpe-00059J-17 for bug-guix@gnu.org; Thu, 17 Dec 2020 15:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45279: [core-updates] copy-recursively does not throw an error on missing directory Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 17 Dec 2020 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45279 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Marius Bakke Received: via spool by 45279-submit@debbugs.gnu.org id=B45279.160823668619757 (code B ref 45279); Thu, 17 Dec 2020 20:25:01 +0000 Received: (at 45279) by debbugs.gnu.org; 17 Dec 2020 20:24:46 +0000 Received: from localhost ([127.0.0.1]:37075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpzpO-00058a-7x for submit@debbugs.gnu.org; Thu, 17 Dec 2020 15:24:46 -0500 Received: from world.peace.net ([64.112.178.59]:50134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kpzpK-00058H-8S for 45279@debbugs.gnu.org; Thu, 17 Dec 2020 15:24:44 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kpzpE-0004b0-Ak; Thu, 17 Dec 2020 15:24:36 -0500 From: Mark H Weaver In-Reply-To: <87lfdwk83q.fsf@gnu.org> References: <87h7ol8msy.fsf@gnu.org> <87lfdwk83q.fsf@gnu.org> Date: Thu, 17 Dec 2020 15:23:44 -0500 Message-ID: <87h7okuqok.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45279@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.31 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 30E5394042B X-Spam-Score: -2.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2FRNLpdTGR9/ Ludovic Court=C3=A8s writes: > Marius Bakke skribis: > >> On the 'core-updates' branch, using copy-recursively on a nonexistent >> directory does not cause a build failure. Instead an error is printed >> and the script continues: >> >> (copy-recursively "doesnotexist" output) >> [...] >> starting phase `install' >> i/o error: doesnotexist: No such file or directory >> phase `install' succeeded after 0.0 seconds >> >> This is on cc6cb6e80a42355147809b4830053a34d1563994. > > I think it=E2=80=99s always been this way. Do you think we should change= it? In general, I think it's a good idea to raise errors for things like this. Warnings that only end up in build logs are likely to go unnoticed for a long time. Mark