From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id X0heOwUmEWB5IgAA0tVLHw (envelope-from ) for ; Wed, 27 Jan 2021 08:36:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uMsNNwUmEWCrTwAA1q6Kng (envelope-from ) for ; Wed, 27 Jan 2021 08:36:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 35BAC940430 for ; Wed, 27 Jan 2021 08:36:21 +0000 (UTC) Received: from localhost ([::1]:50086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4gJI-0002hU-6t for larch@yhetil.org; Wed, 27 Jan 2021 03:36:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4gJ0-0002hC-0f for guix-patches@gnu.org; Wed, 27 Jan 2021 03:36:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4gIz-00058U-Om for guix-patches@gnu.org; Wed, 27 Jan 2021 03:36:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4gIz-00013R-Mu for guix-patches@gnu.org; Wed, 27 Jan 2021 03:36:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45860] [PATCH v2 2/5] services: postgresql: Add socket directory support. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Jan 2021 08:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Mathieu Othacehe Received: via spool by 45860-submit@debbugs.gnu.org id=B45860.16117365303996 (code B ref 45860); Wed, 27 Jan 2021 08:36:01 +0000 Received: (at 45860) by debbugs.gnu.org; 27 Jan 2021 08:35:30 +0000 Received: from localhost ([127.0.0.1]:43714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4gIU-00012O-9e for submit@debbugs.gnu.org; Wed, 27 Jan 2021 03:35:30 -0500 Received: from mira.cbaines.net ([212.71.252.8]:48110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4gIS-00012G-Dl for 45860@debbugs.gnu.org; Wed, 27 Jan 2021 03:35:28 -0500 Received: from localhost (82-132-234-1.dab.02.net [82.132.234.1]) by mira.cbaines.net (Postfix) with ESMTPSA id 52BDE27BC1A; Wed, 27 Jan 2021 08:35:27 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id e17f5741; Wed, 27 Jan 2021 08:35:26 +0000 (UTC) References: <20210118101628.202607-1-othacehe@gnu.org> <20210118101628.202607-3-othacehe@gnu.org> User-agent: mu4e 1.4.14; emacs 27.1 From: Christopher Baines In-reply-to: <20210118101628.202607-3-othacehe@gnu.org> Date: Wed, 27 Jan 2021 08:35:23 +0000 Message-ID: <87h7n2hj5g.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45860@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.45 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 35BAC940430 X-Spam-Score: -4.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: /Eesf3DAbSCO --=-=-= Content-Type: text/plain Mathieu Othacehe writes: > * gnu/services/databases.scm (postgresql-config-file-socket-directory): New > procedure. > ()[socket-directory]: New field. > (postgresql-config-file-compiler): Honor it. > (postgresql-activation): Create the socket directory if needed. > * doc/guix.texi (Database Services): Document it. > --- > doc/guix.texi | 6 ++++++ > gnu/services/databases.scm | 32 +++++++++++++++++++++++--------- > 2 files changed, 29 insertions(+), 9 deletions(-) This looks good, I did spot some system tests fail though, and I'm guessing it's this patch in the series that's the reason [1] 1: https://data.guix-patches.cbaines.net/compare/system-test-derivations?base_commit=2d9c6542c804eb2ef3d8934e1e3ab8b24e9bbafb&target_commit=f8a367281daaad998059dd657818c49ed5beac30&locale=en_US.UTF-8 Looking at the patchwork system test log, I'm guessing it's using the default socket directory on the client side, which is now not working. I think patching the postgresql package to adjust [2] accordingly would be useful to keep PostgreSQL connecting with the default socket directory. 2: #define DEFAULT_PGSOCKET_DIR "/tmp" --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmARJctfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfHyg/9EaXBSE9joxJF5POlV0YDd5R8giq9Dn40 gIjKLd6FZVHSDXJL5fFXGDDzHSzxWgASLJdj9x4KUDirR83HhadAr+pGm75MKwtI Jlj7piwa+jSjF4dkRbbYoazdEaWe7Ob8zfgfS/UeLPwegZ0jysl2WGLftOiCKetR hQpoOukCalz5vMA+SdyQp+rdBKabqoQFrkUNFwkXei4yhZpJhDfZnmBj9DBBs7m5 k7n0Ts0TGakQUqaJ37Zlyx5BF7yt05IeVXse5onhWDHRfNCdUs3zVGdw2xU/lHoN 0bOCxamWBJs6AKKJnR00ZaOVDmayA3oOhmytM7uz+jxnZRLnCc4BBWcLP7QgnucC mlOlT+Bc3wlRWiFV5AJd7IAwVLe8Pw9QJUoxmLosMYEluEkE0z6zXgVlViwTkVPS s3A7pIM5KnpTace5rToFxbChuy8So2xoliOStsFJu/2zii5SezuVMC6Hw48qDNnq 3st22dNqQ4oPxtQ47YwGyrI50aec2qv+LRlj+krNTy4V1SneqY8i9J5ivB7x1gd7 nDgzuk0qPlBKCSce66lv01i+rd1rlp78T+dYFReQJBttAClBXjrPg21gonM/A0n8 s3NjNG8bvXu4izNL6M7aBYrFdWDurh38wJ2nlCNCnSMmWBRgsIwCJkt7Iaz5ZbMt +ocM2L18c0M= =cN9e -----END PGP SIGNATURE----- --=-=-=--