From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id pHhNEHhfPWA0GgAA0tVLHw (envelope-from ) for ; Mon, 01 Mar 2021 21:41:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kKTsC3hfPWDxawAA1q6Kng (envelope-from ) for ; Mon, 01 Mar 2021 21:41:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7375E2FF for ; Mon, 1 Mar 2021 22:41:11 +0100 (CET) Received: from localhost ([::1]:47530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGqHv-0002Ee-0l for larch@yhetil.org; Mon, 01 Mar 2021 16:41:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGqHm-0002D7-Ay for guix-patches@gnu.org; Mon, 01 Mar 2021 16:41:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGqHm-00007F-2p for guix-patches@gnu.org; Mon, 01 Mar 2021 16:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGqHm-0001XP-0I for guix-patches@gnu.org; Mon, 01 Mar 2021 16:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46668] [PATCH]: tests: do not hard code HTTP ports Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 Mar 2021 21:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46668 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 46668@debbugs.gnu.org Received: via spool by 46668-submit@debbugs.gnu.org id=B46668.16146348275865 (code B ref 46668); Mon, 01 Mar 2021 21:41:01 +0000 Received: (at 46668) by debbugs.gnu.org; 1 Mar 2021 21:40:27 +0000 Received: from localhost ([127.0.0.1]:51045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGqHD-0001WW-6s for submit@debbugs.gnu.org; Mon, 01 Mar 2021 16:40:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGqHB-0001WJ-MF for 46668@debbugs.gnu.org; Mon, 01 Mar 2021 16:40:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54703) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGqH6-0008Bt-9l; Mon, 01 Mar 2021 16:40:20 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59104 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lGqH5-00045Q-NL; Mon, 01 Mar 2021 16:40:20 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <1728b9290c1b0e248b71c8b35623939853895a7f.camel@telenet.be> <87r1kyri5l.fsf@gnu.org> <3ae8be5f05d73106c867fe2cfc7f619673fd738b.camel@telenet.be> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 =?UTF-8?Q?Vent=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 01 Mar 2021 22:40:18 +0100 In-Reply-To: <3ae8be5f05d73106c867fe2cfc7f619673fd738b.camel@telenet.be> (Maxime Devos's message of "Mon, 01 Mar 2021 18:23:00 +0100") Message-ID: <87h7lupn7h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614634872; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=j12P1+oygfD7PFfQ5SqWEjRPZjesLJr/KAEg4Ua4THY=; b=GhcphKlyCY1S2d/6/hvWTubSCeHfRRcdhFPuFoXb/gZqmjSNVRTjrwQUZG9idzdGNiBo/z 3JCn2Ded/GGaMMoyo0Afm5aM+Mfk1Ot9FU2yuMaZ2WQqarOASSw0ppncdQMk/BWPkCS9E+ NQSDkVQ4Q72et7A/xX/3qxbWefhIv27ONFWfVlKOCKZDIz3Gpp2L1YcsleUWWA1pqi0SaU diAYCd32b2QUXb60Dvgz4YRHotj4sL3yfytEJcnfI0zuY0d7PVd26KPaoJdOCsEH6T8iYq bnTBztn4e8j0XisyhfQdH48kGILv643U9IyrtLF8YtNMdRnLidb1iq54nzMefA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614634872; a=rsa-sha256; cv=none; b=Q6LYNml2ta3Ud8m7fl3Hytyxv7gRtVeHQmCIr/9AQPnWia6X9bgnUYBY1zsZtN4zH+Qu75 JQem5/XfTsQqKYoU0xMyYex6NFfayitaKHSlzyPUTb29ytu13qNE/44tak6R5HAP8OxYPp ziMMvOGTKK22x5VS/I8R8G+nN6KPztoL3vu5lO+KrUCNOueKHVJzyujqZ6c0b2cbabTrfN A4ITGuCe4pZh3qmC94V0jekf6pN2mG+iE1gaEbhKWqMZ/dqQ0iH1wF1bKLOoaJQ0NQDL4k ECGxCkBnAmu63eYaUJyOvM+xf/FVCECC80NK5Ny1Da7pk+T86zbAagRbF+Z/Qw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.87 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E7375E2FF X-Spam-Score: -2.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: wk5/vAp94vVI Hi, Maxime Devos skribis: > You made some comments about =E2=80=98Hunks that shouldn't be here=E2=80= =99 below. > I disagree. As my explanation is exactly the same for almost all hunks, > I've numbered them and the explanations. > > Explanations: > > A. (Hunk 2--12, i.e. all hunks except the first) > In some tests, the port number is hardcoded. > E.g., you'll see (test-equal "Some string http://localhost:9999" expr= ession). > Removing the hard-coding is the whole point of this patch. > B. See later (hunk #1). > C. See later (hunk #2). Oooh I see, my bad! I thought =E2=80=98test-equal=E2=80=99 & co. were vani= shing, when in fact they were just moved down. Your explanations make perfect sense. IWBN to keep the (test-xyz =E2=80=A6) forms at the top level as much as pos= sible (it=E2=80=99s more convenient, especially when working from Geiser); when i= t=E2=80=99s not possible, changes like you did are the right thing. Thank you, and apologies for the confusion! Ludo=E2=80=99.