From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qB/JCjCmRmBpXwAA0tVLHw (envelope-from ) for ; Mon, 08 Mar 2021 22:33:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CEzXBjCmRmBOIAAA1q6Kng (envelope-from ) for ; Mon, 08 Mar 2021 22:33:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D4C38703 for ; Mon, 8 Mar 2021 23:33:19 +0100 (CET) Received: from localhost ([::1]:49786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJORC-0002aH-AW for larch@yhetil.org; Mon, 08 Mar 2021 17:33:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJOR3-0002a8-Np for guix-devel@gnu.org; Mon, 08 Mar 2021 17:33:09 -0500 Received: from mira.cbaines.net ([212.71.252.8]:59720) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJOR1-0005A0-Fz for guix-devel@gnu.org; Mon, 08 Mar 2021 17:33:09 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id DD45C27BC50; Mon, 8 Mar 2021 22:33:05 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id f37f0b12; Mon, 8 Mar 2021 22:33:05 +0000 (UTC) References: <87a6rf5rd6.fsf@gmail.com> <87r1krgs10.fsf@netris.org> <874khm5pab.fsf_-_@gmail.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Christopher Baines To: Chris Marusich Subject: Re: core-updates: Emacs is only supported on x86_64-linux? In-reply-to: <874khm5pab.fsf_-_@gmail.com> Date: Mon, 08 Mar 2021 22:33:00 +0000 Message-ID: <87h7llb7j7.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615242799; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=6A7oZO6fTCJKdYDvZAZ+SWfRpvHNX66c1mdmN0LCLLY=; b=B470gi5gKE8NJCDra+SLyXMp1nKok5Pli6EIRL7LaLLHoGG+q1u2Xmx1VADcBg1cF9zhl5 mOlRHEKnkg2mHiRUH6o35lTcHQ8RA1ok1ueFlr6Pm2xhTFqozeC05NhSiOrPseZn/x4f41 A1bWgK8e9Gdb5ys5biY79t1rkiKsw/c+WKWAGsv5VciIfqaxj6kPAN2oA/4ZVGjMXKM6YM pGH7JyLBWvdeOZ4WNq0ynKo2ege+K18maHw3FfWScCZw1m+n2OXWZ4KqP35QQ3kGXyGAhg zzD5p7iWk8vLYmyt3oeq2OOVe66PAdv6x/ZVLI+Mqf2aZXFTgfhfqgqROHuZhg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615242799; a=rsa-sha256; cv=none; b=V/ZDyQgLo+nMReX//e5BkUuJu39N3+S76BkMuOliB1F80AsZwe/NDUoklPf40mXykXJthP nYj2VE4SWV3/+apOxOkbsTnVFxusjEcJ6sV7U+/NIqscmO1CY5/bFcH3bDyFNCjVK6bKHs 1HJOYjLGLym4Eb5plLFIQFxL1garyZt9311+Iqo/0dP4gllV52U671kj5gYdsxhuYYM1xx 7SZNC2jBsP58GcrJmLKd087bEathgdy+t9nDOx18OQiG6kUvDCOQMdk0d3SawdXqWTAumr F236FvnFvnii5qmWeK9BuKIGGQWoCgvi+/6GP7j73K1GQLguDrdnOEnD5Cbxew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.98 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 7D4C38703 X-Spam-Score: -0.98 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7aLCn7obJDkS --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Chris Marusich writes: > Christopher Baines writes: > >> Chris Marusich writes: >> >>> I've noticed that the emacs package only supports x86_64-linux, at least >>> on core-updates. Is that intended? >> >> The relevant commit [1] does mention the intent "Remove "i686-linux" >> from supported systems.", but that does differ from my interpretation of >> the change, which is only support x86_64-linux. >> >> 1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D0ed631866cc0b= 7cece2b0a0b50e39b37ae91bb67 >> >> I've sent a patch that should add back "support" for other systems: >> >> https://issues.guix.gnu.org/46987 >> >> That's for master at least, I haven't looked in to what the situation is >> on core-updates. It's worth there checking if the build still fails. > > That patch doesn't apply on core-updates because that rust version > doesn't seem to exist any more on core-updates. However, the same > change applied to the right rust on core-updates does the trick, like > this: > > From e36c4cab40c5b97ffedc72acc586c0b560e7868e Mon Sep 17 00:00:00 2001 > From: Chris Marusich > Date: Sun, 7 Mar 2021 15:58:19 -0800 > Subject: [PATCH] gnu: rust: Make it "supported" on all systems but i686-l= inux. > > * gnu/packages/rust.scm (rust-1.30)[supported-systems]: Instead of hard-c= oding > this to just "x86_64-linux", calculate the supported systems by deleting > "i686-linux" from %supported-systems. > --- > gnu/packages/rust.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/rust.scm b/gnu/packages/rust.scm > index 70d19e089ab..98c553cb913 100644 > --- a/gnu/packages/rust.scm > +++ b/gnu/packages/rust.scm > @@ -448,7 +448,9 @@ jemalloc =3D \"" jemalloc "/lib/libjemalloc_pic.a" "\" > (search-path-specification > (variable "LIBRARY_PATH") > (files '("lib" "lib64"))))) > - (supported-systems '("x86_64-linux")) > + (supported-systems > + (delete "i686-linux" ; fails to build, see bug #35519 > + %supported-systems)) > (synopsis "Compiler for the Rust progamming language") > (description "Rust is a systems programming language that provides m= emory > safety and thread safety guarantees.") > --=20 > 2.26.2 > > > Both of these patches fix the issue for me. After applying either one > in isolation (on the wip-ppc64le branch, which was recently rebased onto > core-updates), the list of supported systems for the emacs package > correctly includes other systems, including powerpc64le-linux, and thus > the tests/guix-package.sh test passes on my powerpc64le-linux system. > > I think both of these patches are important and needed. The patch to > restore supported systems to the rust package is important because we > will want rust to build successfully on many systems. The patch to only > add gtk+ and librsvg inputs to emacs when the system is x86_64-linux is > important because it would be advantageous to be able to use emacs > without depending on rust on systems like powerpc64le-linux, where Rust > support may not be great yet. > > It's also convenient for me, personally, because I don't really want to > deal with Rust right now just to get Emacs working on powerpc64le-linux. > Once I can build a Guix release binary for powerpc64le-linux, then I > think I can start worrying more about Rust. I have taken the liberty of > applying these patches to the wip-ppc64le branch as-is, since they work > for me. I can remove them later if we don't like it. > > We will undoubtedly run into a similar situation with other packages > going forward, like Mark mentioned. Debian ran into this very issue > some time ago, and apparently it caused a bit of consternation: > > https://lwn.net/Articles/771355/ > > Apparently, powerpc64le-unknown-linux-gnu is a "Tier 2" Rust platform, > which I guess means it's pretty well supported, but not as well as "Tier > 1". I hope that we can get it all working, since librsvg is depended > upon in some way or another by about 2700 packages (about 17% of the > total Guix package collection). In the meantime, limiting the blast > radius as needed, like Mark suggested, seems like the right thing to do > until Rust support improves on other architectures. I've gone ahead and pushed the patch I proposed to master, I think it's a step forward. As you say, adapting the change for core-updates might be good as well. I want to check though if rust builds for i686-linux on core-updates, as the path is different to master, so it may well work. So yeah, once I've found out whether rust works on i686-linux on core-updates, I might make a change there too. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmBGphxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcOVg//V/AginssjX0rfWkLpUIdOO258TrCDOZI rY8ZyeeyX9tKVimB8lLvcbqaOXyjAfT0O43uV6G1sVTkrz+Kiwwy4Fu8vIGclgQJ QskihQbqWuOAe91w6vNJTk5Rjzv7s+zk5D/4XjtuAO93AuEhwqo92PrTKRhRnbEW LynkKVYQWiGaC/9C7dxYK1jkeozhG66pu0Fx9a5TtSpgzWu4l/HqoRqG8XAhJ62R vYlxC0ZCtiN1J/UATFdkQSOGWDZcYpXq/nYmYO8TFFB7AnTXTHx8YnZIwWlWZBUk cEGL/mzWIf1mWn7mD+CekZ7sVMhC5XUduNjeUnBhir0F3MCEXy1Vv8B1C8c7p6MK MnvRywCBRhrTiwc5HoIqjB4pxoVXj9kFxIKYc/eTRcfbpBt9dNws0Rhp3bvSQMt6 C9lHOO0MQkZpm1gZUP26gVsLEPp0cBVPO7sdpz+hxhkm4IVGbRIYXVlEXq58UZ/c mUnK+ra8tmr2vqKJLRtQtstWAc6BLo6WrxWLKwSrqvEFzHrRjAxSGYgWHxEvGCJx EGGF+KBSYNrkVamVsUW7kq4T0dm4ROgo68ouazLQu3j5jCaER4Dd6hv/b2oyLOsK 7zXbnZjcTerJPKVj++K0MJwrN3ZhmLWD8WRKVMBKPR4l5d8eN8PrNRzYV+9UPAfE VeCTRwNd1Ro= =+B58 -----END PGP SIGNATURE----- --=-=-=--