From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ONS4J5DNCmHpMgAAgWs5BA (envelope-from ) for ; Wed, 04 Aug 2021 19:25:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kJ/LIpDNCmF1NgAA1q6Kng (envelope-from ) for ; Wed, 04 Aug 2021 17:25:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1E6881559A for ; Wed, 4 Aug 2021 19:25:36 +0200 (CEST) Received: from localhost ([::1]:52760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBKe7-0007q6-9N for larch@yhetil.org; Wed, 04 Aug 2021 13:25:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBIS7-00038R-7l for guix-patches@gnu.org; Wed, 04 Aug 2021 11:05:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBIS6-00032F-1k for guix-patches@gnu.org; Wed, 04 Aug 2021 11:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBIS5-0007xP-KC for guix-patches@gnu.org; Wed, 04 Aug 2021 11:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49252] [PATCH] Channels defaulting to HEAD instead of =?UTF-8?Q?=E2=80=98master=E2=80=99?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Aug 2021 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49252 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kyle Meyer Cc: Ricardo Wurmus , 49252@debbugs.gnu.org Received: via spool by 49252-submit@debbugs.gnu.org id=B49252.162808947230548 (code B ref 49252); Wed, 04 Aug 2021 15:05:01 +0000 Received: (at 49252) by debbugs.gnu.org; 4 Aug 2021 15:04:32 +0000 Received: from localhost ([127.0.0.1]:44927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBIRb-0007wd-LF for submit@debbugs.gnu.org; Wed, 04 Aug 2021 11:04:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBIRa-0007wS-By for 49252@debbugs.gnu.org; Wed, 04 Aug 2021 11:04:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33790) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBIRT-0002gF-Na; Wed, 04 Aug 2021 11:04:23 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=43034 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBIRT-0000WC-5j; Wed, 04 Aug 2021 11:04:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87y2auw3jo.fsf@inria.fr> <87fswo8goa.fsf@kyleam.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 Thermidor an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 04 Aug 2021 17:04:21 +0200 In-Reply-To: <87fswo8goa.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 08 Jul 2021 20:38:45 -0400") Message-ID: <87h7g5p7yi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628097936; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=LtXBELE0rLl4RxYDo0MbZakcC6iyYsB0Mznh+wj6f9I=; b=Ita02t3pu/oA3aXzTP+4fAsY8L9KiCQiGJyPmWSjEPH5I3GQF8riAqvfaodr54K9KO0qvh Q6u4r5tg1THSGxvKjak/Qng0veOmd40ASv/QnUngQrtlHmTXt1vO/H2U9z5S9Cxe81e3lq aAStXuQJAXddFq3nHuUbJki44D+ki2QdgRMWtLmVOHhaKGNaSRweGRVyu5f6eYyOs72/oy ADhn2EiMZPLnHZa5RW1cXr4yLo7rKz4+lvf7J+8hG7ZcYR4RPApcTdxmEEwPgev8LKN+Wz IKliizenLJ3fbB2eZfkwXEflXm8sT66gVAE3ryudFxD5okSGdDJxYHHbP841DA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628097936; a=rsa-sha256; cv=none; b=Ow3zqKxmFuz4D74MgDtLq6PjPqLGQAqMdsecppTDszE/rnOhfxURJFuZ7jxzMUZCoF0a0d DlIv/cBtt1wLVZecVjP3hvY95rEN0eMdr6B4P0VtMcQJLMtB3BMkiQ5vuxV1zCDHmqENeo PpH13nb+Pxq1MhB6YZb4g4Mu0DbXkk/DTg5u+gZN904Lkaoyi6wxYl25Ml5Gld5AZd6I/O KhXLyDsr2uNGdMGyVsmnX5ssoTuT+4SfBZc4By8X7MeXymjpNs81A6g16Lzlnzhnz4zzYb x2ySNDNbY7CHFJ6TOQntyckZsRt8LMN4F7OBhmsd8wWrUkbX7LoqRolUF8h6/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1E6881559A X-Spam-Score: -1.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: CdFE20gvh9Iw Hi Kyle, Kyle Meyer skribis: > Ludovic Court=C3=A8s writes: > >> For the record, commit cb41c15827a2e910aa56fb5d1917ba8a085c95c7 by Kyle >> (Cc=E2=80=99d) gives the ability to use the remote HEAD by default, whic= h is >> exactly what we need here. >> >> Unfortunately, for the Guix repo at Savannah, I get: >> >> --8<---------------cut here---------------start------------->8--- >> $ ./pre-inst-env guix time-machine -- describe >> guix time-machine: error: Git error: reference 'refs/remotes/origin/HEAD= ' not found >> --8<---------------cut here---------------end--------------->8--- >> >> =E2=80=A6 but it works for . >> >> Presumably we have a server-side setup issue at Savannah? > > Hmm, it looks like it's there: > > $ git ls-remote https://git.savannah.gnu.org/git/guix.git | grep HEAD > e499500730de23fd54ae63696a725d4b90a406d7 HEAD > > $ git clone https://git.savannah.gnu.org/git/guix.git && cd guix > $ git for-each-ref refs/remotes/origin | grep HEAD > e499500730de23fd54ae63696a725d4b90a406d7 commit refs/remotes/origin/HEAD > $ git name-rev refs/remotes/origin/HEAD > refs/remotes/origin/HEAD master OK, so something else must be at fault. Ideas? > This might be a long shot, but if you cloned the repo with magit-clone, > it has some custom logic that deletes refs/remotes//HEAD unless > magit-clone-set-remote-head is non-nil (and it's nil by default). No, these are clones managed via (guix git) only. >> Are there downsides, or cases where it might pick the wrong branch? > > The main downside I can think of is what I mentioned in bug#45187 > (87v9d8dk0r.fsf@kyleam.com): > > [The remote HEAD symref] probably the best indicator of what the > primary branch is. In a clone, it doesn't necessarily match HEAD on > the remote, because users may change it to another branch they're > interested in, but that isn't really relevant to these > behind-the-scenes checkouts. > > So, if it's a user-facing clone, refs/remotes/origin/HEAD isn't a > reliable indicator because users are free to redirect the remote HEAD > symref to another branch of interest [*] or to delete it altogether. > > I think channel clones would fall into the "behind the scenes" category, > though, right? Right, those cached clones managed by (guix git) are behind the scenes; we can assume only (guix git) will only ever touch them. Thanks, Ludo=E2=80=99.