bug#52266: [Installer] ESP/EFI Partition not being reformatted (if exists) during graphical install by default.

bug#52266: [Installer] ESP/EFI Partition not being reformatted (if exists) during graphical install by default.

[Ry P. via Bug reports for GNU Guix]

[-- Attachment #1.1: Type: text/plain, Size: 1112 bytes --]

Brief Summary:
It appears as though the Guix installer does not reformat the EFI/ESP partition if it already exists.

Step to reproduce this bug:
With a computer which already has an ESP partition, go through the graphical installation and do not reformat/delete/modify the existing EFI/ESP partition. When you confirm the partitioning changes, you may notice that the EFI partition remains unmodified.

Effects:
It creates a GRUB2 error which states that it can not find the filesystem properly. In my case, it’s because Grub expected a previous OS’s filesystem information (Fedora), but as the EFI partition was not modified in the install, the .cfg did not reflect the new GUIX filesystem UUID.

What do you think should happen:
When installing using the guided installer, have the GUIX installer automatically modify/reformat the ESP/EFI partition. This ensures that that GRUB2 can find the new GUIX UUID upon reboot.

Hardware:
Lenovo X1 Carbon

Kernel:
Linux-Libre Kernel

ISO:
Latest Snapshot Iso

Thank you for your time, please let me know if additional information is needed.

[-- Attachment #1.2: Type: text/html, Size: 2752 bytes --]

bug#52266: [Installer] ESP/EFI Partition not being reformatted (if exists) during graphical install by default.

[Mathieu Othacehe]

Hello,

> Brief Summary: It appears as though the Guix installer does not
> reformat the EFI/ESP partition if it already exists.

Sorry the installation failed for you :(.

While it's true that the Guix installer doesn't reformat the ESP
partition if it already exists, that shouldn't cause any issue. That's
what happened when I installed Guix on my X1 Nano.

> Effects: It creates a GRUB2 error which states that it can not find
> the filesystem properly. In my case, it’s because Grub expected a
> previous OS’s filesystem information (Fedora), but as the EFI
> partition was not modified in the install, the .cfg did not reflect
> the new GUIX filesystem UUID.

Could you share the Grub error you encountered?

Thanks,

Mathieu

bug#52266: [Installer] ESP/EFI Partition not being reformatted (if exists) during graphical install by default.

[opalvaults (Ry) via Bug reports for GNU Guix]

Sure thing! I will try and replicate it. It was giving an error root FS 
not found but I don't have the error in front of me anymore as I had to 
reformat the ESP partition and that fixed the issue.

bug#52266: (no subject)

[opalvaults (ry) via Bug reports for GNU Guix]

Probably best to close this as I won't be able to get back around to 
testing. I'm running into sof-firmware issues so I gotta tackle that. 
Thank you for your time!

bug#52266: [Installer] ESP/EFI Partition not being reformatted (if exists) during graphical install by default.

[Mathieu Othacehe]

Hey,

> Probably best to close this as I won't be able to get back around to
> testing. I'm running into sof-firmware issues so I gotta tackle that. 
> Thank you for your time!

Closing, then. Thanks!

Mathieu