all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thiago Jung Bauermann <bauermann@kolabnow.com>
To: zimoun <zimon.toutoune@gmail.com>
Cc: Kyle Meyer <kyle@kyleam.com>,
	Arun Isaac <arunisaac@systemreboot.net>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	guix-devel@gnu.org
Subject: Re: Updating mumi on berlin
Date: Sun, 15 May 2022 19:05:02 -0300	[thread overview]
Message-ID: <87h75qa1kq.fsf@kolabnow.com> (raw)
In-Reply-To: <86wnezw182.fsf@gmail.com>


Hello zimoun,

zimoun <zimon.toutoune@gmail.com> writes:

> Hi Thiago,
>
> On Fri, 06 May 2022 at 00:22, Thiago Jung Bauermann <bauermann@kolabnow.com> wrote:
>
>> I didn't go that route because I don't like disabling tests without
>> understanding why they fail and it took me a while to understand the
>> zombie root cause. In addition to that, without the testsuite passing I
>> didn't feel confident that I would be proposing a good enough package
>> because virtually the only part of public-inbox that I use is lei
>> itself. What if there was a regression in other parts of it and I didn't
>> notice because I use so little?
>>
>> But I wouldn't mind disabling the part that checks that lei-daemon is
>> truly gone, or even the whole testsuite if that is too complicated.
>>
>> On the other hand, the preferred solution would be the workaround
>> pointed out by Maxim, where tini is used to run the testsuite and reap
>> its sub-processes. I can probably take a stab at it over the weekend if
>> no one beats me to it.
>
> For sure.  For it is worth, I try to keep in mind, :-)
>
>         Now is better than never.
>         Although never is often better than *right* now.
>
>         – The Zen of Python, by Tim Peters –

I liked the plot twist in this one. :-)

> and
>
>         Perfect is the enemy of good
>
>         – commonly attributed to Voltaire –

Yeah, I can easily fall into the trap of trying to get things just right
and taking too long to finish my projects… Though in this case not
feeling confident enough about the updated package due to not being able
to run the tests was a real concern for me.

Since then I have been able to run the testsuite locally and it passes,
so I have just posted a patch series updating public-inbox:

https://issues.guix.gnu.org/55436

Though that one is still with tests disabled (in the spirit of the
quotes above!). I have a bit more polishing to do before I can send the
follow-up patches to enable tests.

For now, you can find them here if you're curious:

https://gitlab.com/bauermann/guix/-/commits/public-inbox-update

-- 
Thanks
Thiago


      reply	other threads:[~2022-05-15 22:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22  5:38 Updating mumi on berlin Arun Isaac
2022-04-27  6:27 ` zimoun
2022-04-27 11:14   ` Arun Isaac
2022-05-02 10:33     ` zimoun
2022-05-03 17:33       ` Arun Isaac
2022-05-03 20:42       ` Thiago Jung Bauermann
2022-05-04  8:00         ` zimoun
2022-05-05  1:49           ` Kyle Meyer
2022-05-05  3:13             ` Thiago Jung Bauermann
2022-05-05 14:45               ` Maxim Cournoyer
2022-05-06  3:16                 ` Thiago Jung Bauermann
2022-05-07 22:20                 ` Ludovic Courtès
2022-05-08  1:00                   ` Thiago Jung Bauermann
2022-05-15 20:59                     ` Ludovic Courtès
2022-05-16  8:27                       ` Maxime Devos
2022-06-04 22:36                       ` Thiago Jung Bauermann
2022-05-05  8:37             ` zimoun
2022-05-06  2:24               ` public-inbox v1.7 update (was: Updating mumi on berlin) Kyle Meyer
2022-05-06  7:37                 ` zimoun
2022-05-08  4:41                   ` Kyle Meyer
2022-05-09 13:58                     ` zimoun
2022-05-06  3:22               ` Updating mumi on berlin Thiago Jung Bauermann
2022-05-06  7:48                 ` zimoun
2022-05-15 22:05                   ` Thiago Jung Bauermann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h75qa1kq.fsf@kolabnow.com \
    --to=bauermann@kolabnow.com \
    --cc=arunisaac@systemreboot.net \
    --cc=guix-devel@gnu.org \
    --cc=kyle@kyleam.com \
    --cc=maxim.cournoyer@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.