From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cBfCM1PNi2IYTQEAbAwnHQ (envelope-from ) for ; Mon, 23 May 2022 20:07:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8BLiM1PNi2KWcwEA9RJhRA (envelope-from ) for ; Mon, 23 May 2022 20:07:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72B6229437 for ; Mon, 23 May 2022 20:07:11 +0200 (CEST) Received: from localhost ([::1]:57758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntCSU-0008K6-Ds for larch@yhetil.org; Mon, 23 May 2022 14:07:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntCLb-0007k1-67 for guix-patches@gnu.org; Mon, 23 May 2022 14:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56277) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ntCLa-0003sW-GR for guix-patches@gnu.org; Mon, 23 May 2022 14:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ntCLa-0004qy-Du for guix-patches@gnu.org; Mon, 23 May 2022 14:00:02 -0400 Subject: bug#53295: [PATCH] gnu: Add FFmpeg 5.0. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 23 May 2022 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53295 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Leo Famulari Cc: 53295-done@debbugs.gnu.org Mail-Followup-To: 53295@debbugs.gnu.org, marius@gnu.org, leo@famulari.name Received: via spool by 53295-done@debbugs.gnu.org id=D53295.165332875218552 (code D ref 53295); Mon, 23 May 2022 18:00:02 +0000 Received: (at 53295-done) by debbugs.gnu.org; 23 May 2022 17:59:12 +0000 Received: from localhost ([127.0.0.1]:50173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntCKk-0004p7-1K for submit@debbugs.gnu.org; Mon, 23 May 2022 13:59:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ntCKV-0004oO-JP for 53295-done@debbugs.gnu.org; Mon, 23 May 2022 13:59:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntCKQ-0003kx-7b; Mon, 23 May 2022 13:58:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=57kqkRPNmLD9UWUjd+wv1PCW6P2q9S5e53nMx7Uc5Bs=; b=hhB1FfgVuZw9nsQ4GPsW mQBbuMdltiLgBBbx4T+VfwgjrOJfcjxgaGIKF+e9De3O9AZPOoPBrOv0/9f3X2aAj4d+nC2fUCLAB zEx4wtC+dTPbWP6OQNF4EWwBLktBgbJ1MEWTJU5WaEGU+YJ40+dLGY90t4XWTyfHvoz0hm9jlUc2/ GB464ZzIY+DHklj2CdZryt14xsVoAQcYhWZ3i6TcbNtSrl1sYTgzyulB9tfOy57E3qhiuDTeLNKBx HkzPJrr1mmCKPpU1ESLJM6VO2uTcqUFzVb7KO20jQRNllb+tXyd1O3agD/ZDPjEaospCF19mqvj/Y ttvh/q/D4iiyeA==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:42462 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntCKO-0008Lz-KN; Mon, 23 May 2022 13:58:49 -0400 From: Marius Bakke In-Reply-To: <87pmohwkp5.fsf@gnu.org> References: <87pmohwkp5.fsf@gnu.org> Date: Mon, 23 May 2022 19:58:46 +0200 Message-ID: <87h75g2krt.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653329231; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=57kqkRPNmLD9UWUjd+wv1PCW6P2q9S5e53nMx7Uc5Bs=; b=Rb0H5Sbp6oYzAnEKmvR0f/J2dtLe2fb7FVLNs2YGMDAf30E4FTlw9dW08RGvk1TQiLdc/c 1fGT+UXHaVMEyIs3mzeGae7rnMWXMp/hW+hbSK3XmxMwDCoqQ3OnnJbhTyjV5jISWJD7uw oHUL01THjnMKjx5FKsdYq4dx08sI5Zx36DJpNMoUqiWi0olLmCx9gNvWcAbkZneqvrJ7dh fKU7InnlOSTLqw20hV8U7aBPZXOmcRK1YRUngH7S8bRTJ+irCfkGEhB07Am2nEZBYehqcg zdaKZsh2Ub3j8RoRKlG+g2l1kijzNIzLzhT/BEinv1IIAYdR1JiE9K1/Aj83Yg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653329231; a=rsa-sha256; cv=none; b=CZsocjaLOBpkdcjTy5jE9NphtijikkvOE4dL7Kj4Tg/uL4CoMCTmQcBWNqlDmrzqme6Z4B xEZ5pn0UaOdMvqxnFQnZ8KQu9bxtWRUbbefRScyPS3vz3NGMOjkSGyjduvZGX/6I0EmEJK IAqRLS6ocAXzaFEoTJieXzsffs5LuOgsuIC6Fc36dwmjHCObIgSKAQPbs9pVluNWE+rA8K y/vAiqrSPgJCQzcFrVRN86n0l5drgR86Iu9TwEdxlctlcTRyfppyjjbGTJRx8PykZUkA8Z 9aEFk1hcaCLAqaC8NNwo2+60PE2QwxC0OSW7LATQMKkQXzOOhs/3PDfgv+sTDw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=hhB1FfgV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.55 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=hhB1FfgV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 72B6229437 X-Spam-Score: -4.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3hlfexSn5FD/ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s skriver: > Hi, > > Leo Famulari skribis: > >> Here's the new major release of FFmpeg. >> >> We can add it right away and move users over to it incrementally as we >> test them =E2=80=94 having this new version is useful for people like me= who use >> FFmpeg directly. >> >> Also, I always found our FFmpeg packages' use of inheritance to be >> confusing when making changes to them, so I didn't use it here. >> >> * gnu/packages/video.scm (ffmpeg-5): New variable. > > Could you remove input labels? (I think =E2=80=98guix style=E2=80=99 can= =E2=80=99t help because > of the conditional in the middle.) > > That said, it seems to me there=E2=80=99s a lot of duplication here compa= red to > version 4. So I=E2=80=99d be in favor of inheriting from that one. I went ahead and pushed this patch in 1cb10f696813ef23678029, with the adjustments Ludo recommended + G-expressions; as well as a follow-up that makes ffmpeg@4 inherit from it. Thanks Leo & Ludo! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYovLVg8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHcRNAEAxUD960WhKtcFX2zmTFSoAdnNG3pdhUplOHDZ M/DD074BAMgpXHXdgvmcWDPr0pJO5m6dfgIAZTBwvT/a1i0mLvUP =76G/ -----END PGP SIGNATURE----- --=-=-=--