From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WGVqD0K762ImFwEAbAwnHQ (envelope-from ) for ; Thu, 04 Aug 2022 14:27:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SCuCD0K762LvYAAA9RJhRA (envelope-from ) for ; Thu, 04 Aug 2022 14:27:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EE164396DE for ; Thu, 4 Aug 2022 14:27:45 +0200 (CEST) Received: from localhost ([::1]:56844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJZx2-00038Z-SL for larch@yhetil.org; Thu, 04 Aug 2022 08:27:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJZWF-0000f0-Ir for bug-guix@gnu.org; Thu, 04 Aug 2022 08:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJZWF-00050q-8C for bug-guix@gnu.org; Thu, 04 Aug 2022 08:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJZWF-0007JT-05 for bug-guix@gnu.org; Thu, 04 Aug 2022 08:00:03 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56398: (guix git) fails to check out repos with nested submodules Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 04 Aug 2022 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56398 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: =?UTF-8?Q?Andr=C3=A9?= Batista Cc: 56398@debbugs.gnu.org Received: via spool by 56398-submit@debbugs.gnu.org id=B56398.165961437428033 (code B ref 56398); Thu, 04 Aug 2022 12:00:02 +0000 Received: (at 56398) by debbugs.gnu.org; 4 Aug 2022 11:59:34 +0000 Received: from localhost ([127.0.0.1]:51474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZVk-0007I2-5g for submit@debbugs.gnu.org; Thu, 04 Aug 2022 07:59:34 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:37626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZVf-0007Hl-Gu for 56398@debbugs.gnu.org; Thu, 04 Aug 2022 07:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=Gmsh83OdmU1ENN/ERJOjdOjfIiTPTkqO/bQ97Ns2YIQ=; b=Sk3hCZoRn+sPHKNZZZnd0TLNlWuF1zsWTfUk45nHSYxTbUDIT94wSRqr Y2GteSIXWGqkEtXPPbl+WeD4fGd/GLCz6fzY7IlkoBeFTP6YrmOqm3zud R0QZK00eNTNomfUwTzXR/t5X4vlmg9upTLLFmu2hTcKYcVlC+c1oAmjH6 A=; X-IronPort-AV: E=Sophos;i="5.93,215,1654552800"; d="scan'208";a="20780720" Received: from unknown (HELO ribbon) ([193.50.111.124]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2022 13:59:21 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 17 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Lin X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 04 Aug 2022 13:59:20 +0200 In-Reply-To: ("=?UTF-8?Q?Andr=C3=A9?= Batista"'s message of "Thu, 4 Aug 2022 08:43:49 -0300") Message-ID: <87h72smd7r.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659616066; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Gmsh83OdmU1ENN/ERJOjdOjfIiTPTkqO/bQ97Ns2YIQ=; b=jbGusV7XdDfPUcaij1KTuQojw39LqgpVDpiN1Ze2cCyKoMK3zCQNQA3Eoi0fGL4+fhc6Gd P8+c9oAPObilPgdwMzWLfrDxdVsaN4NRpzPdsG2r8vy7Xrdlz3JQ5L92Z0QWi880J4Q9qY bk0xeHQyQaUEIOvB3mHEnQ8gPpggnOWjQ3AOa2webINBelwp5Fmi/ftnF/tmP9+6O0fffY +Po23FVYRTL72f+FYlOhS7pMVJ0Onj2NTyiJFP426ZkciPs8ajyuUaS+7T3BKGW7rzIxh0 2v2uUqFmGfUlomOHO1zFBkGz9cKaQgXQixSpqu+Vfa1edwnCnYzSQ/On6SewGQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659616066; a=rsa-sha256; cv=none; b=FPUJrtuGYoxtGC2a0cHk50JGsjqx1EDrCOTkgPtkfUcGFfV67vlXQnYUdsCPprYX2l9A1J bkbN4SL2dT8ufFeY69poNlC1YFuyVQfHhto0NJj22+dO0cOi7AOnZzlE0H/rCCSWSpRMtB AoT/9NhsOzIoM8qH+WW/mS0AvhwjS8EeoVrefM/JDGrjfPeaiXqipVEiJ0EPq3r1Q+PCwu lmJhJDVr+XtYpwFXI2vE0B0kQZ2csDyRnDolQfuztZp5XwbYWmCABmElhkKSsFgejQmIeh +VNQCVcyMieJvXPuzibHUzv2z2UbYmvcGABq1XtCIAycoB58togmfIG/xPLLeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=Sk3hCZoR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=Sk3hCZoR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EE164396DE X-Spam-Score: 7.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: s2gfxp8nybMK Hello, Andr=C3=A9 Batista skribis: > Well, I guess ENOENT !=3D GIT_ENOTFOUND and, in that case, I think we > are better off gracefully failing to update it than trying to "branch" > our local repo. The patch below tests for the directory's existence > before proceding with the update. With this patch applied I've managed > to refresh pytorch, its submodules and got the following code: But you got a wrong hash I presume, because submodule weren=E2=80=99t actua= lly checked out, right? > + (if (file-exists? directory) > + ((lambda () > + (submodule-update submodule > + #:fetch-options fetch-options) The problem is that it papers over an actual libgit2 bug. I think we should instead report it upstream. Do you feel like doing it? I guess we=E2=80=99d need to give them the C version of the three-line snippet I gave earlier. WDYT? Thanks, Ludo=E2=80=99.