From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WAtKAgrNZmNwpgAAbAwnHQ (envelope-from ) for ; Sat, 05 Nov 2022 21:52:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yJJnAQrNZmMqvQAAG6o9tA (envelope-from ) for ; Sat, 05 Nov 2022 21:52:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8FBC2F245 for ; Sat, 5 Nov 2022 21:52:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orQ96-0008Kj-2D; Sat, 05 Nov 2022 16:52:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orQ94-0008KA-DC for guix-patches@gnu.org; Sat, 05 Nov 2022 16:52:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orQ94-0001gL-55 for guix-patches@gnu.org; Sat, 05 Nov 2022 16:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orQ93-0001mG-P1 for guix-patches@gnu.org; Sat, 05 Nov 2022 16:52:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59003] [PATCH 0/7] [Installer] Warn about unsupported devices Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Nov 2022 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59003 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59003@debbugs.gnu.org Received: via spool by 59003-submit@debbugs.gnu.org id=B59003.16676815026806 (code B ref 59003); Sat, 05 Nov 2022 20:52:01 +0000 Received: (at 59003) by debbugs.gnu.org; 5 Nov 2022 20:51:42 +0000 Received: from localhost ([127.0.0.1]:58177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orQ8k-0001li-BE for submit@debbugs.gnu.org; Sat, 05 Nov 2022 16:51:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orQ8i-0001lV-B6 for 59003@debbugs.gnu.org; Sat, 05 Nov 2022 16:51:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orQ8c-0001br-V3; Sat, 05 Nov 2022 16:51:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/e7Uzr6vOv4cnOVH652dL6XyFxSBFsIVfu7Kr9tD1Es=; b=FGJP/h2ysjX/8+oXuytz 5gz2Qrskg4fL3JzkFykfFrZCbHI8RUNsV3h7nY78J4W/3IgAFa1FdjansoQdw45zIbqXSOeC9lpnb cRArgszuG66p3UmfF68sxHB539lhI1yFKunp51OCQBbwNPtvPekqogPHJFe3yIclk9uHZJ6ItMIkM qMwIrjbIvUAKEdD4kVZLHlJxKE1ycd9VzLuRUhtqTVyorXFs6N0v8WL5IX7m9BLj8Ps3SixUwgmKG 1OPZvJzn6BZ9UkBFn4qbooKCzSQxdg4/rLW03ZUXcHQBy73JeusxSsfiVWvCz1hFLRgIugfRR9siV MhlRiUdo2oUDBQ==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2774.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2774] helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orQ8c-0007Yw-EJ; Sat, 05 Nov 2022 16:51:34 -0400 From: Mathieu Othacehe References: <20221103191935.16336-1-ludo@gnu.org> <20221103191935.16336-6-ludo@gnu.org> Date: Sat, 05 Nov 2022 21:51:31 +0100 In-Reply-To: <20221103191935.16336-6-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 3 Nov 2022 20:19:34 +0100") Message-ID: <87h6zdi0q4.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667681545; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/e7Uzr6vOv4cnOVH652dL6XyFxSBFsIVfu7Kr9tD1Es=; b=dWz4CDld3zaf0laDRgnV3zbFgF91I91X68qSLtyv8giiTNmLr0imWRBd/jSZfYiubx4tYz b0nuBwk9+Pt8LXMzXk26zi3ZB8X78fro3Ra8DG+CJcxAY9e3utyyCJSXGq56NPsCNFDchW 6AusVqb4CUNs4VpWrX2XniajLfvG+vZ57m1WbjcLdQTE+OYKGDgzoLxaWYb6+mNEN6LTV1 z+wQr7b/RQf3PTAJfVCKHgfbNk/gS9iNb3gJMK2sKg/UDoTMxUyc8n0cLRV5NCBn3LeUma D4+8uaVJ2EdNb3g0TfBsOJRoDCtPBUrdamG4ZCTuyWcj6uwGvlFEKhMZFJXSWg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667681545; a=rsa-sha256; cv=none; b=FNKLPUZLUsbx0EzzVxbWgw68n813WE0nyCsH4nkUYnCIc8cOOkfg3CQSqmVTZBj5Fk5DX0 IKKpaY5lbpnjqQ/gYhXr2Huhs20f2j4EO6RPSRNHr2KJGi1e65OUUV1p05M/RI42U8yKIT ZDLzeglZ2YtKKnc4TQZY1NBbEP1mzxgDcNNnnXZOdHowk53cHBoGYObSnn1BYFOTg+qyUM TfCFAb36dzR12658SCqk14z7IZLtVfcYplO5k7JMImdoJTCDk5GvjgTuT2ZQ5IGGLv33CN uBKPaabmNBtQlg1BLrwKLBIac1zMeZswcqrWqP/qrKXIQgCMpbOqvWmUMqQFiQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="FGJP/h2y"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="FGJP/h2y"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C8FBC2F245 X-Spam-Score: -2.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: Qr68wxBY7IBw Hey Ludo, Overall, this is a very welcomed improvement :) > -(define (check-hardware-support) > +(define %unsupported-linux-modules > + ;; List of Linux modules that are useless without non-free firmware. > + '("iwlwifi")) > + > +(define unsupported-pci-device? > + ;; Arrange to load the module alias database only once. > + (let ((aliases (delay (known-module-aliases)))) > + (lambda (device) > + "Return true if DEVICE is known to not be supported by free software." > + (any (lambda (module) > + (member module %unsupported-linux-modules)) > + (matching-modules (pci-device-module-alias device) > + (force aliases)))))) > + I feel like all the hardware related part should not be part of the gnu/installer/newt/ directory which is intended to contain mostly Newt/GUI related stuff. It would also be more logical for the contributors to browse the gnu/installer/hardware.scm file for the %unsupported-linux-modules list than the gnu/installer/newt/welcome.scm file. This can be done as a follow up though. I'm currently testing this patchset on a few machines with unsupported hardware and will report back. Thanks for this patchset, Mathieu