From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id M37+C+jZcmNMWQEAbAwnHQ (envelope-from ) for ; Tue, 15 Nov 2022 01:14:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sJYrC+jZcmN3rwAA9RJhRA (envelope-from ) for ; Tue, 15 Nov 2022 01:14:32 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C2275904D for ; Tue, 15 Nov 2022 01:14:31 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouirV-0004so-SZ; Mon, 14 Nov 2022 18:27:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouihX-0001BJ-A8 for guix-patches@gnu.org; Mon, 14 Nov 2022 18:17:20 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouihK-0002jI-K8 for guix-patches@gnu.org; Mon, 14 Nov 2022 18:17:08 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouihK-0000Tw-Gg for guix-patches@gnu.org; Mon, 14 Nov 2022 18:17:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Nov 2022 23:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59253 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: liliana.prikler@gmail.com, 59253@debbugs.gnu.org, 59253-done@debbugs.gnu.org X-Debbugs-Original-Cc: Liliana Marie Prikler , Thiago Jung Bauermann via Guix-patches via , 59253-done@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16684678001581 (code B ref -1); Mon, 14 Nov 2022 23:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2022 23:16:40 +0000 Received: from localhost ([127.0.0.1]:51675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouigw-0000P1-VY for submit@debbugs.gnu.org; Mon, 14 Nov 2022 18:16:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:59270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouigt-0000O6-T4 for submit@debbugs.gnu.org; Mon, 14 Nov 2022 18:16:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouigi-0006GD-5N for guix-patches@gnu.org; Mon, 14 Nov 2022 18:16:29 -0500 Received: from mx.kolabnow.com ([212.103.80.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouQ0C-0008Gr-Fw for guix-patches@gnu.org; Sun, 13 Nov 2022 22:19:18 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 026A41803; Mon, 14 Nov 2022 04:19:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1668395950; x=1670210351; bh=oqDJ6+Zr7P6mOqTbYRuE+kwn8Af0qko3RYj pLuob9MQ=; b=4wM8qR0uWc+tsjbFU+R6cnHKsm6hUdRVGM7te76naWOyGYEzfex 7YV6fbUG/7tASK7YUDYTHikFqPZ+xIRmrcLtkSKLnnl00l4nSTxjkYdn3U5OPcw6 /HQYJoeeTucntQDXWDKOxkC9+p/VUlHlckncVOzH8Y6Jnna3Bib7BYzCSJwlh+1n DCS64qi1+L2ouHIRIyYlwzv7kEm0QLN2IZccNsOuzaTwGWMS7Bdg7Ve68Gzn6Yev PrufTJ2CZ5/XkjvZr4dYDxppW7yRHupE24GRls+uW30NkfHlJ7/7Ft2b0AEz9U79 GLj6+ZTGEu/8CfuYzrbx2wWxiBWVDitlRVLW06HLQivo6muhaH220AKpjngfDb1j i2yTTYiz7wi3chxBB141fbvsmG/WreRP8DKXJArIHWmlaPLylapctcq0yOWQwLjo qs8IuWiA4/Q8420xGwO3MI1dsiuSo5xQSTxhNa2T6iEmqiycz0ALwuuJawSP/Tuv Np3KACB9uBIAdSscD4fPIqu3n2mz5oKeaDNRESDaZ0dNPebWLMlvi4hbkvvZh6oD dJTT6bW6AvVf4Yw4uiG9XKQ443a6BtAgtEaEykPeT8f/TNYetDgk3upUv/t+/Lw9 QR6OhjpZIxMwekYzMsCp7AQagLsY9DO1c+haVt2D34Eu/CVT57cdFlzY= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GqGN7H0i1AKa; Mon, 14 Nov 2022 04:19:10 +0100 (CET) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id 73F9615F8; Mon, 14 Nov 2022 04:19:09 +0100 (CET) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 0B5849F5; Mon, 14 Nov 2022 04:19:09 +0100 (CET) References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> Date: Mon, 14 Nov 2022 00:09:21 -0300 In-reply-to: <87y1seqlwm.fsf@gmail.com> Message-ID: <87h6z2p6jc.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.103.80.155; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668471271; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oqDJ6+Zr7P6mOqTbYRuE+kwn8Af0qko3RYjpLuob9MQ=; b=inoudVdmjGgOnJioz+G/VJlyS8HC44xkf7b7haIxVwist/OEMjzianaEndQ0e/BVAhCX4u KljYM2KZTa5apaoo8qS350I+6rw91V2JOzRuIkMraOBRnkCysDj9+T5xSa/SqzyyFTUvkY IPf1SZFTPegp+FVCDgQfRqvaxRIfLhAH2ocN3B8ScQTvU9sXbBOMWkwyMqdrluaF9KVWXE hzY0tm13WchB+hQb/NtpetT/P0KnvY1/+2buFeSG9h6H4pSKg4lZCVCTlXRvU5mMg+m4Mq OZZ8OfOTj8bn1ZbpQc86uP5BqD8G1YT+QRNBb39SZ2RoPPJPWrnbqu3ki1KiFA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668471271; a=rsa-sha256; cv=none; b=txxu61V+LqSagT4BmDFHYxRpiZi+UFjQ8IRnouR6ob0BxhtGOeBoOQEdvoqJ9hbN4ZSFle VhK3j1Fc/PzbIqNT1YHFaOh0SAiQ8xi0WeMOmbtEB5j+yWevC00YVX/62p8+fY4xBWYtmZ RMUvCcqXEXR+E3DRJvZ32D2n0WE9eKwqRbHPP0OaDGfXYi2984PlePL/Srm9fvUHAtf5wY kPP4QB7QGM1qo1UWQk4q93rYzNfcZ0J0Olt5UsVOGeSs1Tot1x8I/gHtgb45MqhBG+a+pX GMCkGBkbDM7NGjp1G/hm+ANcB8JyLRuypooxVoEe9G/aNhCdPpEGUNrWolirTg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=4wM8qR0u; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.74 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=4wM8qR0u; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C2275904D X-Spam-Score: -3.74 X-Migadu-Scanner: scn1.migadu.com X-TUID: Lq4XQXmbkH+x Hello Maxim, Maxim Cournoyer writes: > Hi, > > Thiago Jung Bauermann via Guix-patches via > writes: > >> Hello Liliana, >> >> Liliana Marie Prikler writes: >> >>> Am Sonntag, dem 13.11.2022 um 22:24 +0100 schrieb Liliana Marie >>> Prikler: >>>> Am Sonntag, dem 13.11.2022 um 18:11 -0300 schrieb Thiago Jung >>>> Bauermann: >>>> > Magit has a strong dependency on Git so it should directly >>>> > reference >>>> > the >>>> > git executable rather than expect it to be available in the profile >>>> > or >>>> > environment. >>>> >=20 >>>> > This also fixes a build failure in emacs-forge. >>>> >=20 >>>> > * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]<#:phases>: >>>> > Substitute >>>> > git path in the =E2=80=98magit-git-executable=E2=80=99 variable. >>>> LGTM, will push once I'm done with some other stuff. >>> Aaaand it's done. >> >> Wow, that was quick. Thank you! > > Won't this make magit unusable from TRAMP (which already seems broken > for me since the time we enabled native comp -- anyone else?). Hm, interesting point. I don't know. I don't use TRAMP because it was too slow for me in the couple of times I've tried. magit/lisp/magit-git.el does have this custom variable though, which this patch didn't change: #+BEGIN_SRC elisp (defcustom magit-remote-git-executable "git" "The Git executable used by Magit on remote machines. On the local host `magit-git-executable' is used instead. Consider customizing `tramp-remote-path' instead of this option." :package-version '(magit . "3.2.0") :group 'magit-process :type 'string) #+END_SRC elisp So I'd say it's possible that my patch doesn't affect whether Magit works from TRAMP=E2=80=A6 --=20 Thanks Thiago