From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +GyxNE0jxWOiRAAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 11:13:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MCqKNE0jxWNOiQAAauVa8A (envelope-from ) for ; Mon, 16 Jan 2023 11:13:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 81B0EA000 for ; Mon, 16 Jan 2023 11:13:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHMUD-0000AO-5V; Mon, 16 Jan 2023 05:13:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHMUB-0000AB-Ar for guix-patches@gnu.org; Mon, 16 Jan 2023 05:13:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHMUA-0004En-Qk for guix-patches@gnu.org; Mon, 16 Jan 2023 05:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHMUA-0000hS-6w for guix-patches@gnu.org; Mon, 16 Jan 2023 05:13:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60753] [PATCH] gnu: home: Add home-emacs-service-type. Resent-From: David Wilson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Jan 2023 10:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60753 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: "\(" , 60753@debbugs.gnu.org Received: via spool by 60753-submit@debbugs.gnu.org id=B60753.16738639692643 (code B ref 60753); Mon, 16 Jan 2023 10:13:02 +0000 Received: (at 60753) by debbugs.gnu.org; 16 Jan 2023 10:12:49 +0000 Received: from localhost ([127.0.0.1]:60502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHMTx-0000gY-1V for submit@debbugs.gnu.org; Mon, 16 Jan 2023 05:12:49 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:38423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHMTu-0000gJ-38 for 60753@debbugs.gnu.org; Mon, 16 Jan 2023 05:12:47 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 09A985C00C6; Mon, 16 Jan 2023 05:12:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 16 Jan 2023 05:12:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daviwil.com; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1673863960; x= 1673950360; bh=5Ujib5uR5C+NHVzgi0Z63NvUiKancTGoVuF74dDDdxM=; b=Q mSl5kFHvcHnJdiyBUrPv7ifAg9KQhEHo9oaqI9gpJPLIWtAroUqPf8uW4utltSPt d/3iyA6Ihz3IQt0jLxMM2b+WZaVDa+1BToSRs1u2HhItI4AGeh0aYREe8gyFTjYo AW7Jl7FLt2MvegHYIx7Xt2cliIcnb+I2yo0jtLzNjXKaa6/3Z/DAq5Ul6fj+PwHa x7BlZY9qNMPwcwXynmkB3M6OUY3y0x6rqEbDf+IQpPcLydHNfWNaYskBFN5X9mej v6Pqmq2cYDVoxNd/ZiYYegXGAyjOWOf/Gvr4Agfy1UQe7uV2EitNwostms241M85 A7QOu93dFAIRuKeeyTZaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673863960; x= 1673950360; bh=5Ujib5uR5C+NHVzgi0Z63NvUiKancTGoVuF74dDDdxM=; b=B a09R+Sh6HhKAb3nKnVDkLe4pTK5iOf84b/YxSeh/4yRqCxU2pwWfLIg983JosnhK RXmtseoZe2d25ZrQh6p0VYyJuXT+8rotJILugDZEZKNQMWr1KmpeVOuIk40o/xGG BO52VCLjIFmYjuYmwYCvlW2eGENE8MFMM5XhDPW53YO7dZLWesLdEJ5SHcecGp2G SRyxWLyMM8+NVeGVWKMEQFZ6Ucph3ZbR1bxFVb5IDsn3iVnsgBRr58wETrKZjbUo MoK3T8NBLgPIHyzo8TTFGFTF5ERFRQ2zweRowCQh1fy2rT5hOVLN7zcVcAYbCBfG DS628noJuyNHhKRN0G5mw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtgedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpeffrghv ihguucghihhlshhonhcuoegurghvihgusegurghvihifihhlrdgtohhmqeenucggtffrrg htthgvrhhnpedutdfgieehhefhtdefgeevgeehgfehudegvefhudeijeehgffhudfhvedt jeegffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gurghvihgusegurghvihifihhlrdgtohhm X-ME-Proxy: Feedback-ID: iba684179:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 16 Jan 2023 05:12:38 -0500 (EST) References: <87edrzzw9w.fsf@daviwil.com> <87v8lby7jq.fsf@daviwil.com> <87k01p8086.fsf_-_@gnu.org> User-agent: mu4e 1.8.11; emacs 28.2 From: David Wilson Date: Mon, 16 Jan 2023 11:25:29 +0200 In-reply-to: <87k01p8086.fsf_-_@gnu.org> Message-ID: <87h6wqu6ss.fsf@daviwil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=daviwil.com header.s=fm1 header.b="Q mSl5kF"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="B a09R+S"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673864013; a=rsa-sha256; cv=none; b=iQRcFzM9DMBw0gGnGcy9LslL6OJe0SqJpuz5VLB1MO4nWTet9GSLqn4vrrBUUCGjW/ZfkV Z2XpUg3uVolEfaRnaqYcyYApG/avmSuU5dWaKJAtvbgnZ0vDCn0PX57PU9OACuDxc0B0Zd KdYRGsk7WXI+MqIJg55HdWvOq1xgRNYz4CGlCiS6YPpRO9c57NaDiYVdcIHxrplgAGrukA WJ1kIi1hXzsUJFDkU2dsRgyLCYDs01GaKjhDli9jj2FWn3Gf1U8FQCQGCHYuft0QOX8o95 YufOTCPVnScZt9dJsSDugqZtH0OFY7wVd1VsWBFyQZO9YwT9PdG/bRpNyVCjWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673864013; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5Ujib5uR5C+NHVzgi0Z63NvUiKancTGoVuF74dDDdxM=; b=exULOe7g5tdmprR1HLwxLkeoPc+ej/TYwo6mGr51LUuZZGu0+/Olv1y+/rAKeZErW9dILw KPQo6TitCToI550KAzA7YFwvucmHMui1RLMaL1GrGhqMboIPDmx1AKytUgWcu1GbvCV5eZ qT2A2Jm13r14KAMcRECMzDkaUF7h1naWinZYSKugQXsi21BvywvAlZ7McIRpf/emzmOo5Z sS7PT21PBpxZRJgtvJxTWUgRJT7Lz6c1FPgZK47IHHsFjNjlze0FH7GNAV3qOtk+KqHtqE gLkmyCCDbfFuaXTm3PpPfsMc6Ooh1yMMP2LoIs7L0M6k8+MQtoVFoGlFtUSqQg== X-Migadu-Queue-Id: 81B0EA000 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=daviwil.com header.s=fm1 header.b="Q mSl5kF"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="B a09R+S"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -2.72 X-Spam-Score: -2.72 X-TUID: LcgY9YyvbT34 Thanks for the feedback, Ludo! I'll make the requested changes and send them later today. I may also try adding some tests to ensure that the output is what we expect. There seems to be a `tests/services` folder, should I add a `tests/home-services` folder to match? Ludovic Court=C3=A8s writes: > It would be nice if you could start the section with a few sentences > explaining the rationale and what=E2=80=99s being described here. Will do, I'll look at other services to get an idea of the best way to do this. > What about accepting sexps (or gexps) instead of strings? As in: > > (init-file '((require 'whatever) (setq something t))) > > Also I find it confusing that it=E2=80=99s either text or files. In the = code it > has type =E2=80=98text-config=E2=80=99, which means list of file-like obj= ects IIUC, no? Yes, this was a misunderstanding on my part! Regarding using s-expressions for this, it would certainly look cleaner. Andrew raises a good concern about it in his response, I'll take a look at what RDE does for this and see if I can adopt a similar approach. > Nitpick: I think this should be =E2=80=98load-path=E2=80=99 (singular), b= ecause it=E2=80=99s one > search path (i.e., a list of directories). > > And: s/Additional load paths/Additional directories/ Will change both of these, thanks! > Would be nice to have a couple of commented examples here, like you had > in the first message in this thread. :-) Yep, I'll add examples for all the use cases here. > Would be nice to have a sentence above, like =E2=80=9CThis service type c= an be > extended with @code{home-emacs-extension} records, described below:=E2=80= =9D. Will describe and give an example of how to extend the service! David