From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: phodina <phodina@protonmail.com>
Cc: 59851@debbugs.gnu.org
Subject: [bug#59851] Add Moonlight
Date: Mon, 16 Jan 2023 11:11:18 -0500 [thread overview]
Message-ID: <87h6wq8no9.fsf@gmail.com> (raw)
In-Reply-To: <m_E7NdSsSdVPdQnIJ0A8fmwr7jmZ7RBn2qrDdCMW_P1FkzdxTLayYwf5gSYStidtqPw4MJolQi3BUc6qaUmX2xlpHSvJaQYb8t8oNs1d8es=@protonmail.com> (phodina@protonmail.com's message of "Tue, 06 Dec 2022 03:17:28 +0000")
Hi again,
phodina <phodina@protonmail.com> writes:
> Hello,
>
> these patches add support for game streaming solution for Nvidia GameStream protocol. The client is open source. However, the games and the server is a non-libre application.
>
> ----
> Petr
>
>
>
> From 6f6e1a55787059f520428287fba474fe72c4a86b Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina@protonmail.com>
> Date: Sat, 3 Dec 2022 10:36:38 +0100
> Subject: [PATCH 6/6] gnu: Add moonlight.
>
> * gnu/packages/games.scm (moonlight): New variable.
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 131784bc2a..d3628266ac 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -5857,6 +5857,61 @@ (define-public bambam
> colors, pictures, and sounds.")
> (license license:gpl3+)))
>
> +(define-public moonlight
> + (package
> + (name "moonlight")
Should that be called moonlight-qt? Or perhaps it's the flagship
client, and thus 'moonlight' is appropriate, and other clients can have
different names?
> + (version "3.1.4")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/moonlight-stream/moonlight-qt")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "02y2rbiiawhj1dvgxdaz8k9kpz6zkv20zsk17fbqj8259m3g5xr5"))))
> + (build-system qt-build-system)
> + (arguments
> + (list #:tests? #f
An explanatory comment (;no test suite) ? is required.
> + #:phases #~(modify-phases %standard-phases
> + (replace 'configure
> + (lambda* _
> + (symlink (string-append #$(this-package-input
> + "sdl-gamecontrollerdb")
> + "/gamecontrollerdb.txt")
> + "app/SDL_GameControllerDB/gamecontrollerdb.txt")
> + (substitute* "moonlight-qt.pro"
> + (("moonlight-common-c \\\\")
> + "#moonlight-common-c \\")
> + (("qmdnsengine \\\\") "#qmdnsengine \\")
> + (("app \\\\") "app")
> + (("app.depends") "INCLUDEPATH +=")
> + (("h264bitstream \\\\") "#h264bitstream \\"))
> + (invoke "qmake"
> + (string-append "PREFIX=" #$output)))))))
Please explain what the non-obvious substitutions (commenting stuff) are
for.
> + (native-inputs (list pkg-config qttools-5))
> + (inputs (list moonlight-common
> + libva
> + libvdpau
> + openssl
> + opus
> + qtbase-5
> + sdl-gamecontrollerdb
> + qtquickcontrols2-5
> + qtdeclarative-5
> + qtsvg-5
> + qmdnsengine
> + sdl2
> + sdl2-ttf
> + h264bitstream
> + ffmpeg))
Please sort inputs :-).
> + (synopsis "GameStream client for PCs")
I'd drop "for PCs", since it doesn't add much.
> + (description
> + "Moonlight PC is an open source implementation of NVIDIA's GameStream, as
> +used by the NVIDIA Shield.")
> + (home-page "https://moonlight-stream.org")
> + (license license:gpl3)))
That should also be gpl3+.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-01-16 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 3:17 [bug#59851] Add Moonlight phodina via Guix-patches via
2023-01-16 15:03 ` Maxim Cournoyer
2023-01-16 15:04 ` Maxim Cournoyer
2023-01-16 15:59 ` Maxim Cournoyer
2023-01-16 16:05 ` Maxim Cournoyer
2023-01-16 16:11 ` Maxim Cournoyer [this message]
2023-01-16 16:12 ` Maxim Cournoyer
2023-01-17 8:07 ` phodina via Guix-patches via
2023-01-17 16:29 ` Maxim Cournoyer
2023-01-17 16:35 ` Maxim Cournoyer
2023-03-21 14:07 ` Maxim Cournoyer
2024-01-21 13:22 ` bug#59851: " Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6wq8no9.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=59851@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.