all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: phodina <phodina@protonmail.com>
Cc: 59974@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
Subject: [bug#59974] My GNU Health package
Date: Tue, 17 Jan 2023 11:11:11 -0500	[thread overview]
Message-ID: <87h6wp16qo.fsf@gmail.com> (raw)
In-Reply-To: <cDednQg1dqrDuSZJoFxAbQwMbnCjAjqI4aGh6EbP85U8_HYaniLHDOnT-u8LosMEPx9N96QsIiZOLQac7czQrtu4e3_KG6ru3oZ2MuuW63E=@protonmail.com> (phodina@protonmail.com's message of "Tue, 17 Jan 2023 07:28:56 +0000")

Hello,

phodina <phodina@protonmail.com> writes:

[...]

> Patch V3 changes:
>
> * added `bash-minimal` and `python` as dependencies.

Thanks for V3!  

> ----
> Petr
>
> From a997a19afaacb9cff523bff39231b176c4553921 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina@protonmail.com>
> Date: Sun, 11 Dec 2022 18:10:17 +0100
> Subject: [PATCH v3] gnu: Add mygnuhealth.
>
> * gnu/packages/medical.scm (mygnuhealth): New variable.
>
> diff --git a/gnu/packages/medical.scm b/gnu/packages/medical.scm
> index 6c9cc757eb..c41d8c8b3d 100644
> --- a/gnu/packages/medical.scm
> +++ b/gnu/packages/medical.scm
> @@ -1,6 +1,7 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
>  ;;; Copyright © 2017 Quiliro <quiliro@fsfla.org>
> +;;; Copyright © 2022 Petr Hodina <phodina@protonmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -20,12 +21,66 @@
>  (define-module (gnu packages medical)
>    #:use-module (guix build-system python)
>    #:use-module (guix download)
> +  #:use-module (guix gexp)
>    #:use-module (guix licenses)
>    #:use-module (guix packages)
>    #:use-module (gnu packages databases)
> +  #:use-module (gnu packages kde-frameworks) ; kirigami
> +  #:use-module (gnu packages python-crypto)
> +  #:use-module (gnu packages python-web)
>    #:use-module (gnu packages python-xyz)
>    #:use-module (gnu packages qt))
>  
> +(define-public mygnuhealth
> +  (package
> +    (name "mygnuhealth")
> +    (version "1.0.5")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "MyGNUHealth" version))
> +              (sha256
> +               (base32
> +                "1jcrriccqzb4jx7zayhiqmpvi3cvfy3bbf9zr3m83878f94yww8j"))))
> +    (build-system python-build-system)
> +    (arguments
> +     (list #:phases #~(modify-phases %standard-phases
> +                        (add-after 'install 'wrap-executable
> +                          (lambda* (#:key inputs #:allow-other-keys)
> +                            (let ((out #$output)
> +                                  (qml "/lib/qt5/qml"))
> +                              (wrap-program (string-append out
> +                                                           "/bin/mygnuhealth")
> +                                            `("QML2_IMPORT_PATH" ":" prefix
> +                                              (,(string-append out qml)
> +                                               ,@(map (lambda (i)
> +                                                     (string-append
> +                                                      (assoc-ref inputs i) qml))
> +                                               '("kirigami"
> +                                                 "qtdeclarative"
> +                                                 "qtgraphicaleffects"
> +                                                 "qtquickcontrols"
> +                                                 "qtquickcontrols2"))))))))

Here it'd be nicer to use wrap-all-qt-programs from (guix build
qt-utils), to avoid hard coding the qt version in the QML wrapped path.

> +                        (add-before 'check 'env-setup
> +                          (lambda _
> +                            (mkdir-p "/tmp/mygh/")
> +                            (setenv "HOME" "/tmp"))))))
> +    (native-inputs (list python-pyside-2))
> +    (inputs (list qtbase-5
> +                  qtdeclarative-5
> +                  qtgraphicaleffects
> +                  qtquickcontrols-5
> +                  qtquickcontrols2-5
> +                  kirigami))

Sort k before q :-)

> +    (propagated-inputs (list python-bcrypt python-matplotlib python-requests
> +                             python-tinydb))
> +    (home-page "https://www.gnuhealth.org")
> +    (synopsis "The GNU Health Personal Health Record")
> +    (description
> +     "This package provides GNUHealth Personal Health Record
> +application for desktop and mobile devices that integrates with the GNU
> +Health Federation.")
> +    (license gpl3+)))

The rest LGTM.

-- 
Thanks,
Maxim




  parent reply	other threads:[~2023-01-17 16:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11 17:48 [bug#59974] My GNU Health package phodina via Guix-patches via
2022-12-12 13:31 ` zimoun
2022-12-13  8:15   ` phodina via Guix-patches via
2023-01-16 14:57     ` Maxim Cournoyer
2023-01-17  7:28       ` phodina via Guix-patches via
2023-01-17  7:30         ` phodina via Guix-patches via
2023-01-17 16:02         ` Maxim Cournoyer
2023-01-17 16:11         ` Maxim Cournoyer [this message]
2023-02-13  1:08 ` [bug#59974] [PATCH v4] gnu: Add mygnuhealth Morgan.J.Smith
2023-03-21  3:46   ` bug#59974: My GNU Health package Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6wp16qo.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=59974@debbugs.gnu.org \
    --cc=phodina@protonmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.