From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uF+XI3fo7WS/SgAAG6o9tA:P1 (envelope-from ) for ; Tue, 29 Aug 2023 14:45:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uF+XI3fo7WS/SgAAG6o9tA (envelope-from ) for ; Tue, 29 Aug 2023 14:45:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 503D365F33 for ; Tue, 29 Aug 2023 14:45:43 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="eu/KKbyl"; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693313143; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vKzWDpNaLpI7LHx1e2eEfu0Cf3u1GmGAT/nGm+IiHI4=; b=WLD3h7jWqO/oEwa7rksw1bYI/7xYom4oe4dUyts8aXhMU8GmDkSY5vidtkhmj+Zs+VpFs6 NnhGZwcv5sL/VV13nEEfxj2vVgDWwdNdy33UcgBJI0cGbAvZe5QtEsw99KUkIvTSXdrAIU Pzp1nqOapO/eK6iYjU35wQ7jkAsaQnObaRwFD9c/RiYKP2zqdZJHomUGsc8GDK6A4YSylp Mc8LHBAnIW5ocJpwEtzaZA3Ya3pbx4oGMipV/G5ibdTw7jNqewHctKj2H9mWG4GJe9sIfL FSp07qqExrYuAv4I2JS1qSTJkMgCsHofb4eiEnz4bFS2bj5adH4exXoPfPc+qA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b="eu/KKbyl"; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693313143; a=rsa-sha256; cv=none; b=Q7kjx4te4BygbC1EoDjgK17HQRaUVRWD7Hn+lvzI+PYYIOdijhs81pQtjfYRfxTfa2haZd Q7ThVoU1tTVB5gVAyS8zNY8tcuoJqw0tHSh/xtK7yeVtNWJ0GLI96sibnguj701YMMZZLl vmZHsRkkIbDwLpqKRFFghIbuRpsK3XB9rb0X/OZNT+VIUKYwC0FtKO/CC1Asy8sctnKnmG KAURHLkbrx4wq3HDoHWHo8fNGN6gBNfhlVsQ98Sgh2z9g/Ur0f1Xqkczari1oCZt/wxqYt nSK8lGmRw0PA33N9w0ukMuJvz4c+iVx1wo1DS589LtE2rFURZpMqCa6U8xBHAQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qay5j-0004E0-QE; Tue, 29 Aug 2023 08:45:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qay5c-0004B8-LS for bug-guix@gnu.org; Tue, 29 Aug 2023 08:45:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qay5X-0003hp-GZ for bug-guix@gnu.org; Tue, 29 Aug 2023 08:44:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qay5e-0006MZ-Dx for bug-guix@gnu.org; Tue, 29 Aug 2023 08:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#32347: gzip cannot be patched Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 29 Aug 2023 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32347 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Marius Bakke , 32347@debbugs.gnu.org Received: via spool by 32347-submit@debbugs.gnu.org id=B32347.169331308824418 (code B ref 32347); Tue, 29 Aug 2023 12:45:02 +0000 Received: (at 32347) by debbugs.gnu.org; 29 Aug 2023 12:44:48 +0000 Received: from localhost ([127.0.0.1]:49715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qay5Q-0006Lm-Fg for submit@debbugs.gnu.org; Tue, 29 Aug 2023 08:44:48 -0400 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]:52256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qay5O-0006LZ-4y for 32347@debbugs.gnu.org; Tue, 29 Aug 2023 08:44:47 -0400 Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6bca66e6c44so3487387a34.0 for <32347@debbugs.gnu.org>; Tue, 29 Aug 2023 05:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693313073; x=1693917873; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=vKzWDpNaLpI7LHx1e2eEfu0Cf3u1GmGAT/nGm+IiHI4=; b=eu/KKbylGVLBvP+k6BR3XlnLNuDf5hV972qZAfr2JxlLNFr+hAR6NCE2IsnTnXDwN5 WMcAM2+zvWKMKGd1Dyebyolih1qB2yVgTtXS83ymDpk1ngjw6lx/LK6z2O6Zi+JwAb89 81AqM51M8wpub0zENPcBIHUPA9uzNxifn5pQ5b4l4/84NjZEakvo2JxhlW4mOpNXNGk4 K9TvHmdRc4InislyHrYAjgmJQjTiMn6TMp2QeHqCVLG0PQXWd4bmD7Vwg2NMnTn38Vfn HHbA/1Jv5Xbfw2JUJkXO65SwEUPTbYe3El+Hj0Dq9xmwC1TVyR3/NdEP7QSB/niBIcKT mPVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693313073; x=1693917873; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vKzWDpNaLpI7LHx1e2eEfu0Cf3u1GmGAT/nGm+IiHI4=; b=AvFwCTos74uQml0scdXMVvQu5i+EKuT2Cf05YiKIshblCLpofT/esBPDpORWtFHcUB 0tMLRS5gUZ3er94v+tZJC64konvXMcT2rrMQ9jiFexHahYLQe9RbD2Mq2So/b5BDwW0S BUsVMNuypdgNQHO/2HCiopnOSCJIuoeYGaAAh32cKkD4xFWD+CBhWW7o7yKm8x3qgi1w Cw5VuRqa0irAWZshdp866YMkrg1CEPyXV4V9td8hvo/QsQnvUj0FOIu8tAh7UfdSzWmY +c0IVLbmr+SK5wDpATMMZ6Xiz/+4ZH7dAzNDruSKUCg520tT5gjZuW22nJVO9C2bB4tt wB/g== X-Gm-Message-State: AOJu0YzLs5gNZPGWDkijJ0cYHaVVB7iGJILbSihIcn3HBSp3wg0Fb7rQ Z33nFUMTcq+vFGuVyYUpvsNiQatq/EvITA== X-Google-Smtp-Source: AGHT+IEtgqAL39voLbLBIwqWak6bvhkajqTOY7ewfyHWYdfR/Y8Nz2py6inaQscA5QpmVWyM1hptdg== X-Received: by 2002:a05:6358:5e08:b0:13a:6748:9312 with SMTP id q8-20020a0563585e0800b0013a67489312mr28655055rwn.19.1693313073237; Tue, 29 Aug 2023 05:44:33 -0700 (PDT) Received: from hurd (dsl-10-132-204.b2b2c.ca. [72.10.132.204]) by smtp.gmail.com with ESMTPSA id o22-20020a05620a111600b0076816153dcdsm3053432qkk.106.2023.08.29.05.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 05:44:32 -0700 (PDT) From: Maxim Cournoyer References: <87muu56m31.fsf@fastmail.com> <20180802115718.GD13776@macbook41> <87a7piii22.fsf@gnu.org> <20181003080141.GA11380@macbook41> Date: Tue, 29 Aug 2023 08:44:31 -0400 In-Reply-To: <20181003080141.GA11380@macbook41> (Efraim Flashner's message of "Wed, 3 Oct 2018 11:01:41 +0300") Message-ID: <87h6oic91s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Spam-Score: -5.13 X-Migadu-Queue-Id: 503D365F33 X-Migadu-Spam-Score: -5.13 X-TUID: Z7d7H4F6gT5z Hi Efraim, Efraim Flashner writes: > On Sun, Aug 19, 2018 at 03:48:05PM +0200, Ludovic Court=C3=A8s wrote: >> Hello, >>=20 >> Efraim Flashner skribis: >>=20 >> > On Thu, Aug 02, 2018 at 01:32:02PM +0200, Marius Bakke wrote: >> >> Hello! >> >>=20 >> >> I'm trying to add a patch to 'gzip', but it causes an infinite loop a= nd >> >> eventually the system runs out of memory. >> >>=20 >> >> It can be reproduced by adding this hunk: >> >>=20 >> > >> >> modified gnu/packages/compression.scm >> >> @@ -215,6 +215,7 @@ adding and extracting files to/from a tar archive= .") >> >> (method url-fetch) >> >> (uri (string-append "mirror://gnu/gzip/gzip-" >> >> version ".tar.xz")) >> >> + (snippet '(#t)) >> >> (sha256 >> >> (base32 >> >> "16h8g4acy7fgfxcjacr3wijjsnixwsfd2jhz3zwdi2qrzi262l5f"= )))) >> >>=20 >> >> [back] >> >>=20 >> >> I guess this is because gzip itself is a patch input. Is this someth= ing >> >> that can be fixed, or do we have to use "patching phases" in these ca= ses? >> > >> > Its also in commencement.scm, so that might be the loop instead. You >> > could try "unpatching" it there. It looks like it has a pseudo-package >> > inside of glibc-utf8-locales-final, with grep-final a few packages low= er >> > being potential inspiration for undoing the modifications in "real >> > gzip". >>=20 >> Indeed. The =E2=80=98bootstrap-origin=E2=80=99 procedure, defined in (g= nu packages >> bootstrap), arranges to use the bootstrap binaries of gzip, patch, >> guile, etc. when patching origins. >>=20 >> Perhaps we=E2=80=99re missing a use of =E2=80=98bootstrap-origin=E2=80= =99 somewhere in (gnu >> packages commencement)? >>=20 > > Looks like it in the end. the gzip for glibc-utf8-locales-final uses the > bootstrap guile for its building, but doesn't get the input rewriting > that comes from package-with-bootstrap-guile. With this patch adding the > trivial snippet to gzip doesn't cause an infinite loop anymore. Since > the patch doesn't change the hash of glibc-utf8-locales-final it should > be OK for master. If you have verified the patch doesn't cause a world rebuild (guix build libreoffice), feel free t opush and close this old bug! --=20 Thanks, Maxim