From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
"Marius Bakke" <mbakke@fastmail.com>,
32347@debbugs.gnu.org
Subject: bug#32347: gzip cannot be patched
Date: Tue, 29 Aug 2023 08:44:31 -0400 [thread overview]
Message-ID: <87h6oic91s.fsf@gmail.com> (raw)
In-Reply-To: <20181003080141.GA11380@macbook41> (Efraim Flashner's message of "Wed, 3 Oct 2018 11:01:41 +0300")
Hi Efraim,
Efraim Flashner <efraim@flashner.co.il> writes:
> On Sun, Aug 19, 2018 at 03:48:05PM +0200, Ludovic Courtès wrote:
>> Hello,
>>
>> Efraim Flashner <efraim@flashner.co.il> skribis:
>>
>> > On Thu, Aug 02, 2018 at 01:32:02PM +0200, Marius Bakke wrote:
>> >> Hello!
>> >>
>> >> I'm trying to add a patch to 'gzip', but it causes an infinite loop and
>> >> eventually the system runs out of memory.
>> >>
>> >> It can be reproduced by adding this hunk:
>> >>
>> >
>> >> modified gnu/packages/compression.scm
>> >> @@ -215,6 +215,7 @@ adding and extracting files to/from a tar archive.")
>> >> (method url-fetch)
>> >> (uri (string-append "mirror://gnu/gzip/gzip-"
>> >> version ".tar.xz"))
>> >> + (snippet '(#t))
>> >> (sha256
>> >> (base32
>> >> "16h8g4acy7fgfxcjacr3wijjsnixwsfd2jhz3zwdi2qrzi262l5f"))))
>> >>
>> >> [back]
>> >>
>> >> I guess this is because gzip itself is a patch input. Is this something
>> >> that can be fixed, or do we have to use "patching phases" in these cases?
>> >
>> > Its also in commencement.scm, so that might be the loop instead. You
>> > could try "unpatching" it there. It looks like it has a pseudo-package
>> > inside of glibc-utf8-locales-final, with grep-final a few packages lower
>> > being potential inspiration for undoing the modifications in "real
>> > gzip".
>>
>> Indeed. The ‘bootstrap-origin’ procedure, defined in (gnu packages
>> bootstrap), arranges to use the bootstrap binaries of gzip, patch,
>> guile, etc. when patching origins.
>>
>> Perhaps we’re missing a use of ‘bootstrap-origin’ somewhere in (gnu
>> packages commencement)?
>>
>
> Looks like it in the end. the gzip for glibc-utf8-locales-final uses the
> bootstrap guile for its building, but doesn't get the input rewriting
> that comes from package-with-bootstrap-guile. With this patch adding the
> trivial snippet to gzip doesn't cause an infinite loop anymore. Since
> the patch doesn't change the hash of glibc-utf8-locales-final it should
> be OK for master.
If you have verified the patch doesn't cause a world rebuild (guix build
libreoffice), feel free t opush and close this old bug!
--
Thanks,
Maxim
prev parent reply other threads:[~2023-08-29 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:32 bug#32347: gzip cannot be patched Marius Bakke
2018-08-02 11:57 ` Efraim Flashner
2018-08-19 13:48 ` Ludovic Courtès
2018-10-03 8:01 ` Efraim Flashner
2023-08-29 12:44 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6oic91s.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=32347@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=ludo@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.