From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uIK4IH42MmWwcwAAauVa8A:P1 (envelope-from ) for ; Fri, 20 Oct 2023 10:12:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uIK4IH42MmWwcwAAauVa8A (envelope-from ) for ; Fri, 20 Oct 2023 10:12:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A314F3A78B for ; Fri, 20 Oct 2023 10:12:45 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=T5OJkVW1; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=G2HDL4uJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697789566; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TjErLIafFf4HOZ5hDE5CnmCM1BKPZZU8PiBkkI9bXpo=; b=LOxZElpbiDuXIM4eBEPNfAWW/XjJIrrHk7Qdttdh4VDpcIQPbjELZZhdB5M48uQyf1bQ/X v5wCWXUMKOWgREWW7DZg0+6p+rX54cKmkNVn+7c+3lF/8HjYwnpRGcrzZM3t3ngL2Swgo7 fvNWi6CHeXnP2ERH8djAqeF9jCNUsAT2yDbWQN2Iig3dQ0OfZdMD0zLvmHTmGgFLON3DYT lKtzCCaRWT0tcaRuW5ObRjIVmTfCq9Bcy9qZxKdtT44bNXfl46q1t+7O4UKCPy9a5Cwk7w TfLnm1ODo5znsStcxkRtq+i9+DLlo8TZy8PosELTKqUO0g13L0njtnz/ZfLnAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=T5OJkVW1; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=G2HDL4uJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697789566; a=rsa-sha256; cv=none; b=FgyzNoRVvgn6FywEEzf5oalU9zeoV2lvpKN0rDPAGos5AsWllIYm7aorLVqsidTKJ5PLH3 SFtlR3Z37Eeqanrw1qUDPogg3fXQ2nX+LejDzTwGB4cDAWElmiuq7DJYNTFMrZGCqPkvOm ovRNnZo2p8XGCHSvYaEXVzEzoT9FT/HG1MI/nYVODdDfq3HCvfasUtBlHpXKjcMOge/9OI 6ViCcJ1ogryq74/BKMnX/+Dk82TRyagqAp/6DUQSB9Aj0Czg2YJ8z+hvz8is7WplGSSZmT 7u8YlMbt7oIBi66ycp3z2GtittxNzaADw8fubUYv6p1HPjUtfXZTDdZ3AgYu/Q== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtkcY-0007In-Oz; Fri, 20 Oct 2023 04:12:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtkcW-0007Gq-Ao for guix-patches@gnu.org; Fri, 20 Oct 2023 04:12:36 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtkcV-0003i2-03 for guix-patches@gnu.org; Fri, 20 Oct 2023 04:12:35 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtkcv-00066f-Mh for guix-patches@gnu.org; Fri, 20 Oct 2023 04:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 08:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169778957923465 (code B ref 66436); Fri, 20 Oct 2023 08:13:01 +0000 Received: (at 66436) by debbugs.gnu.org; 20 Oct 2023 08:12:59 +0000 Received: from localhost ([127.0.0.1]:38579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtkcs-00066N-RS for submit@debbugs.gnu.org; Fri, 20 Oct 2023 04:12:59 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:49497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtkcq-00066B-Vi for 66436@debbugs.gnu.org; Fri, 20 Oct 2023 04:12:57 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D35D9320010B; Fri, 20 Oct 2023 04:12:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 20 Oct 2023 04:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697789543; x=1697875943; bh=TjErLIafFf4HOZ5hDE5CnmCM1BKPZZU8PiB kkI9bXpo=; b=T5OJkVW1iqI9jkIdbVmsBnUP+InjdaSLLz29n51JEkVW3xYio6w crdi8jXcoXF2nXyZ6w+sf3V+mqnbSnO1+L7e4Y+LuFNxbG0lg6sFlOePpFDepUA6 37KhqvkXXOByzJeBtNq/6ARiGLP0Go6izIgOiKYfaO/A5mH2DflbRgU6Phqpbezw gE43lT/D6KFR6UjDqW6GJMTAL90RkPaCGr4Am+U1Skss2VBwpzbAn/iRiAu9NgfB mVUfuk+3EKGVzmyea19rI3za9AVEloxtFwWhmpIh8Qn8Ts7F1/b4TVjkcaPUqop+ 1YkKt1xBBJ77aEUZCl5EnvSNcKoMXdrPaNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697789543; x=1697875943; bh=TjErLIafFf4HOZ5hDE5CnmCM1BKPZZU8PiB kkI9bXpo=; b=G2HDL4uJJZNLFsqi1LE+QF9lnxWW633KOkkvShkqXSJXKgYbTLn 4q/vCXE1f3FrjWD/OmFMGPBCYjDVYA6aSveUYijWgc6mB9VYg/hKewmFCOKrg4YT rfhGvbz78RtyY8sApb6OXn9hioDLDM/8+AmRGKG3/meKP82WSMFGuyLv4IxsunWs nKlT11THyEaKfqb3m6Y92XFTzRjdQuwAQct+qEUSAzBguhq42uf6b864hwD0hwpO DpnLGLX02USMFAXFpCHJTDfxiltp/+rqMFzv2pHng56YjeussgSqhcNc7bxSgwyz 4+6JhqzYdF2zdg+/j7mSXURIZ9HWlEgnW+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjeekucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvvefujghffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpeevlhormhgvnhht ucfnrghsshhivghurhcuoegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgheqnecugg ftrfgrthhtvghrnhepgeekheefffdtfeffueevkefgfffhtddugfdugeeugeevgfduteff udfgfefhjedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheptghlvghmvghntheslhgrshhsihgvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Oct 2023 04:12:22 -0400 (EDT) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 10 Oct 2023 20:24:05 -0400") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> Date: Fri, 20 Oct 2023 10:12:11 +0200 Message-ID: <87h6mlzp9g.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.99 X-Spam-Score: -1.99 X-Migadu-Queue-Id: A314F3A78B X-Migadu-Scanner: mx2.migadu.com X-TUID: rw1n5/nTnk18 Hi, These are a few questions regarding reviewing. 1. What should the reviewer do with old-style patches, like the ones that don't use G-Expressions? Should we tell the submitter to use them when possible or is it only a matter of style that is up to the submitter? Obviously they are hard to grasp for newcomers. It's probably good for newcomers if we teach them how to use G-Expressions but we don't really have time to do so, given the number of patches waiting to be reviewed. This question could be extended to style issues. Like using %var versus var. 2. What should the reviewer do when only small changes are required? The reviewer could do these changes in seconds whereas asking for a new revision could take days. These changes could be indentation fixes, removing of unused code, but they could also be more substantial, like adding a missing `file-name` field. Or changing old-style to G-Expressions? If the reviewer makes such changes and pushes them right away, I imagine they should be documented and explained. 3. Should the reviewer run the program being packaged? The above guidelines speak about applying, reading, building and linting but not running. (Making sure it works as expected.) Thanks, Cl=C3=A9ment