From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KDhWOmlQMmVOzAAA9RJhRA:P1 (envelope-from ) for ; Fri, 20 Oct 2023 12:03:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KDhWOmlQMmVOzAAA9RJhRA (envelope-from ) for ; Fri, 20 Oct 2023 12:03:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9E686417E0 for ; Fri, 20 Oct 2023 12:03:21 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=p7Hlz8J2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697796201; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=21/cuc3xiMnVVWGfjFKdNB4jE7iEjfTZfh7G5VQ4aAs=; b=W11Uy+m7bvOKWl2gIyeW/qcZAtm3Ni59LNwPHwTO1vA7WD92wOk6lpAXoIMkMQG/veojgp biS6MywHs8d6hj746RhruCVG9DrOCIvmsiHJZ7muVDAPunVduy8Q5lqrtUEV7BlyYiah5B TA5e4Eumgkyn9EvEs/T7qcsPOVpiYp+TGWL4kfbbIk072+0tZh9YsHcVFwzCwToh2yYER+ FihUZ6qyLyxOCAvoRpJ+AUfoIKvg9w7dPONuEx+abSYpsTIX0aSlUfJDLsPeVQEVYLOnjw Re6FaNU/rjHI8NJYaf+sEuGw1rIAo31+OAbyScsPvqee2agNXqQizq/KKWlufw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=p7Hlz8J2; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697796201; a=rsa-sha256; cv=none; b=HJg3ey8t+4QgS8vVjsfu7LLD06dMKfubXW20nEz5bzdddHa5rXAJzILlGx9n+6RCdevb1E DbIF/kR6jsYZl07vJzxRntxr9yG1FcoBE5JSbIhDUyegEQmM2XtXkg/c5bAkrlaBLClJ6w RtjDzTgoe1COkKy0/UwADJJZWjFnRBWqHEeUXeQBLPPo+I4/LrbxriqhY0Cmua1IZWyv4F HZBsAEBM/4kCeWmKI7PgRPJZ5ylMAsUqkH0PWLZZaZ3As9Bqpqf4/nzaiVYCB0rGD9jdE/ 7itXSvUIF0feWMLuL7V3uTOhdbinRaRZt2uYkqiUoYl1AI4tk5TXJGdnxu8kWg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtmKy-0002Je-8J; Fri, 20 Oct 2023 06:02:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtmKx-0002JP-Mq for guix-patches@gnu.org; Fri, 20 Oct 2023 06:02:35 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtmKx-0006Bn-Dy for guix-patches@gnu.org; Fri, 20 Oct 2023 06:02:35 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtmLO-0001Lr-GG for guix-patches@gnu.org; Fri, 20 Oct 2023 06:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66408] [PATCH v5] gnu: icecat: Support Guix packaged extensions and native manifests. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 10:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66408 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: Jonathan Brielmaier , 66408@debbugs.gnu.org Received: via spool by 66408-submit@debbugs.gnu.org id=B66408.16977961235109 (code B ref 66408); Fri, 20 Oct 2023 10:03:02 +0000 Received: (at 66408) by debbugs.gnu.org; 20 Oct 2023 10:02:03 +0000 Received: from localhost ([127.0.0.1]:38733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtmKQ-0001KL-RV for submit@debbugs.gnu.org; Fri, 20 Oct 2023 06:02:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtmKO-0001Jp-1q for 66408@debbugs.gnu.org; Fri, 20 Oct 2023 06:02:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtmJq-0005gh-MJ; Fri, 20 Oct 2023 06:01:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=21/cuc3xiMnVVWGfjFKdNB4jE7iEjfTZfh7G5VQ4aAs=; b=p7Hlz8J2SRiLfdamzAr+ w4xWkd+1Rxd3e92cd0pDTLJ2z6BIMwijS20F4TBwQKNnWNV5qwDacyON71EEihdt5N7OkwxeTRvJ0 OpYr4UqBYHUu0sVUxz49m8PpM16++oJ7jnJu6jDyK8y9Cj7Jp8jeXWMfsyraNTXD9mhxy8r22iL4X RbnCijh8aP2K1U33X9H+iI5kdSRxe7o6MsFz2C46+crhSUOO8Ze99FwC/8fkboIEU1xCzWEh4PUgK cIDzN/LE0qgf1Kik8KOrRrZHGMZ7EOlEYeh4ht3Z2rzIYRLZw+BLJiHj5jZGsGd8hm3lEF6U984B9 fJuguu2YXmvJEA==; From: Mathieu Othacehe In-Reply-To: <2ae9c5496838c6644de4c1199e188e44c7171f0f.1697561146.git.clement@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?= Lassieur"'s message of "Tue, 17 Oct 2023 18:45:46 +0200") References: <2ae9c5496838c6644de4c1199e188e44c7171f0f.1697561146.git.clement@lassieur.org> Date: Fri, 20 Oct 2023 12:01:11 +0200 Message-ID: <87h6mllijc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.82 X-Spam-Score: -6.82 X-Migadu-Queue-Id: 9E686417E0 X-Migadu-Scanner: mx2.migadu.com X-TUID: Y2peoZBHcSvY Hey Cl=C3=A9ment, > + (let* ((id #$(assq-ref properties 'id)) id is maybe a bit generic? > + (firefox (in-vicinity (assoc-ref outputs "firefox")= id)) > + (xpi (assoc-ref outputs "xpi")) > + (chromium (assoc-ref outputs "chromium"))) > (install-file "dist/build/uBlock0.firefox.xpi" > (string-append xpi "/lib/mozilla/extension= s")) > (copy-recursively "dist/build/uBlock0.firefox" firefox) > @@ -142,3 +146,6 @@ (define ublock-origin >=20=20 > (define-public ublock-origin/chromium > (make-chromium-extension ublock-origin "chromium")) > + > +(define-public ublock-origin/icecat > + (make-icecat-extension ublock-origin "firefox")) It does not appear clearly that one has to install ublock-origin-icecat here. We have the same issue for ublock-origin-chromium though. > diff --git a/gnu/packages/patches/icecat-compare-paths.patch b/gnu/packag= es/patches/icecat-compare-paths.patch > new file mode 100644 > index 000000000000..9205899dc0c4 > --- /dev/null > +++ b/gnu/packages/patches/icecat-compare-paths.patch You could add a small header explaining the content of that patch, ... > --- /dev/null > +++ b/gnu/packages/patches/icecat-use-system-wide-dir.patch ..., as well as that one. I tried a guix shell icecat ublock-origin-icecat and it worked perfectly :) It is also very appreciated to have a pre-built icecat by the QA :). Thanks, Mathieu