From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mARoBQQ/dmX4QwAAauVa8A:P1 (envelope-from ) for ; Sun, 10 Dec 2023 23:43:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mARoBQQ/dmX4QwAAauVa8A (envelope-from ) for ; Sun, 10 Dec 2023 23:43:16 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm3 header.b=S2m7DwhV; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=yUVUpoXj; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702248196; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GRLtCsu73kEc2kUdAShjDhOq9h6miN5QA0nIjCxa+5g=; b=pBbNEOUP30ybAsNKMD03KGQyY/gtazd1hl3f/R4OV8lGsowtwitZiQUzOSYgS6MgfPNU82 N4Fa7Ft0jjFVmB33v5S/OLylqOCBhYFyhY0BG5fuiMjZX9L0BIdehKq9j8Bj26+E1rg7Jh 7BsD3qvpwNTyvjCT2AG7A/OqCL8cOBxNd46JbajNbdqoKA07IsSSZP+I3EtOFCgwRhHvX2 IAbeSYQfVSTnkv89YGtY90wEqVbVnke8weQj2whVxCTfsS/bA/7H2b55XDQDGLkkXb091R CY9djVDOmN7pg3daCb/AppB+XEmVi83sfrKRkRxCUWF/1Vob1G/yBK7x9BFFPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm3 header.b=S2m7DwhV; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=yUVUpoXj; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702248196; a=rsa-sha256; cv=none; b=SVTKldnj3zi95MBxY+KkVOQMj+eOO+WdojUfIkvDapeO2kus92FotwaUT9jWq4kNQ0y8P/ WBZeVlfETjjYRr0Y++gDQp3VsMlJ2ZfnrDijPDKkFx+fvQZiXuXvY8TxkscHsWd6nBk+3m N7WjTuClj2DVAS4YjBf46mVSgislicDjR5pvO2tVMIBrjHD8PX828wOxx6dW8uIA+OO6/B +U4w44jNxVJoW484LsSV7hjuM31Zx8JaaCSDOaxKDJWQn371zc/JjKlOOgi4/hKem/u/tN 1kgnVR/T0UeJV5uTzpF4NmB+es+mKpPMFqzRrULv09ntFaWcRHwxOxywtqbSOQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D36F4549CC for ; Sun, 10 Dec 2023 23:43:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCSVe-0005JS-FH; Sun, 10 Dec 2023 17:42:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCSVb-0005HS-Ve for guix-patches@gnu.org; Sun, 10 Dec 2023 17:42:48 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCSVb-0004lo-Nm for guix-patches@gnu.org; Sun, 10 Dec 2023 17:42:47 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCSVq-0007lz-3f for guix-patches@gnu.org; Sun, 10 Dec 2023 17:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67512] [PATCH 0/5] Add LibreWolf Resent-From: Ian Eure Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 10 Dec 2023 22:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67512 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 67512@debbugs.gnu.org Received: via spool by 67512-submit@debbugs.gnu.org id=B67512.170224813729820 (code B ref 67512); Sun, 10 Dec 2023 22:43:02 +0000 Received: (at 67512) by debbugs.gnu.org; 10 Dec 2023 22:42:17 +0000 Received: from localhost ([127.0.0.1]:51923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCSV7-0007ku-6e for submit@debbugs.gnu.org; Sun, 10 Dec 2023 17:42:17 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCSV3-0007kf-BL for 67512@debbugs.gnu.org; Sun, 10 Dec 2023 17:42:15 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BC0B05C00C4; Sun, 10 Dec 2023 17:41:53 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 10 Dec 2023 17:41:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1702248113; x=1702334513; bh=GRLtCsu73kEc2kUdAShjDhOq9h6miN5QA0n IjCxa+5g=; b=S2m7DwhVmEdyqBrnY7zpBmW9Evw18YfhWJzHKMktAX4uAst6UMR peRs4klu8A0By4qzDR9jTe+6PGMYQJDG1YP53Jb5DUl+VoTTqaGPw4ZwjcU6DH0J TF5MidOxXj/fdq/JV9W1q9Lwspc0ZLbcCV7UqlY0WQjQYZrYi738t0lNPGDAda1P dguOjyckMrLGUTvH45iKanR2NqR5Y+oa/sagiZoGjoifdtn90DcEjhwzVO2R9k0j hCFTb2eQOouwtSq6MjVz+5VcLKpBRmN/8GOnco0kPlrH6sBezW1qDNAo+ixdCuM+ yte9OEtdHcGp5ZDajnic/FhnhLY1QH+WdsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1702248113; x=1702334513; bh=GRLtCsu73kEc2kUdAShjDhOq9h6miN5QA0n IjCxa+5g=; b=yUVUpoXjBIq74HGkRFbLQKnHrN1vHBRnpVYUB08JEEy9qqgR3vn fXWVF44a5SjcORzD/w1WeJwhGlAh6Y13dUkWc7FGt/dkckNxEXM542qrVImVfxR2 EBYRC0KgqBGUGJp0tnZIwqXY6+2E398DRHmuLYikKtkd9T203k3rjDWAP0ef7Onp FKdOBURLZ3FTqqu1oNTz8uLfFfAmtQJrVJOqvQRyKtq1IcyZOVoOmJanIE3D+x9Q EjqiBlLxnwKRxe0bxOoWNNY3uKUQCCUSoK92X1kwaRAA6UmNuJTHdbv5Ct1vtEtk HyaxsxlqXV7XMQFNxSBoUTLHbmBKG8EUTLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeluddgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpefkrghn ucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqnecuggftrfgrthhtvghrnh epgeduieejieehgeehueejteevgedtuefgieektdelfeekudeilefggfetgedukeeknecu ffhomhgrihhnpehlihgsrhgvfiholhhfrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihgrnhesrhgvthhrohhsphgvtgdrthhv X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Dec 2023 17:41:53 -0500 (EST) References: <878r613em1.fsf@gnu.org> User-agent: mu4e 1.8.13; emacs 28.2 From: Ian Eure Date: Sun, 10 Dec 2023 14:28:35 -0800 In-reply-to: <878r613em1.fsf@gnu.org> Message-ID: <87h6kpk7db.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: 0.99 X-Spam-Score: 0.99 X-Migadu-Queue-Id: D36F4549CC X-TUID: ppXPSR177d1M Hi, thank you very much for your comments. Ludovic Court=C3=A8s writes: > Hi! > > Ian Eure skribis: > >> I mentioned in #guix that I was working on a package for=20 >> LibreWolf, >> and it was requested that I send in patches, so I am. These=20 >> changes >> are based on the firefox-esr package in nonguix; I've retained=20 >> the >> copyright / authorship notices from there. >> >> LibreWolf (https://librewolf.net/) is a fork of Firefox which >> removes the telemetry and advertising, and bundles uBlock=20 >> Origin. >> It doesn't have the redistribution issues that Firefox does,=20 >> its >> name/logo are under MPL 2.0 and aren't trademarked. >> >> I'm new to Guix, and not remotely a browser development expert,=20 >> so I >> don't expect these are ready to be accepted yet, but I believe >> they're in good enough shape to have a discussion about.=20 >> They're >> working acceptably well for me, though I'm not currently daily >> driving Guix, so there may be issues I haven't encountered yet. > > This is much appreciated! People often complain that IceCat is=20 > based on > too old a version of Firefox, so if we can have LibreWolf (or=20 > even > Firefox without its problematic bits), that=E2=80=99s great. > IMO, LibreWolf pretty much is Firefox without the problematic=20 bits. It=E2=80=99s been my default browser for several years, and I=E2=80=99m ver= y=20 satisfied with it. >> The librewolf package has some functions duplicated from (gnu >> packages gnuzilla), which probably ought to get factored out=20 >> and put >> somewhere, but I'm not sure if they should be in (gnu packages >> mozilla) or a different module. Guidance would be appreciated=20 >> here. > > To me that=E2=80=99s the main issue here: these packages are complex,=20 > and I > wouldn=E2=80=99t want us to end up with two (or more!) copies of these=20 > beasts. > > As the person who made the changes, it would be great if you=20 > could > pinpoint things that had to be changed compared to =E2=80=98icecat=E2=80= =99.=20 > What > phases or flags differ? What phases can be factorized? > This work isn=E2=80=99t based on the icecat package, but on the=20 firefox-esr package from nonguix. The duplication I refer to is two small=20 helper functions, `runpath-of' and `runpaths-of-input', totaling nine=20 lines of code; they=E2=80=99re flagged with a comment in the patch. As=20 mentioned in the cover letter, I=E2=80=99m happy to extract these, I just don=E2=80=99t = know=20 where they ought to be placed. They=E2=80=99re defined inside a lambda in a=20 gexp, which sounds like it may be challenging to put somewhere=20 accessible to both packages. Skimming the icecat package, not many of the build steps are=20 shared with librewolf, and factoring the commonalities out would IMO=20 result in overly complex, brittle, hard to maintain code that=E2=80=99s worse=20 than the slight duplication between the two packages. If there=E2=80=99s a=20 strong feeling that they must be accounted for, I=E2=80=99ll give it a try, but I don=E2=80=99t believe that it=E2=80=99s the best option. Thanks, =E2=80=94 Ian