From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aGD6FMgCxGVeNQEA62LTzQ:P1 (envelope-from ) for ; Wed, 07 Feb 2024 23:23:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id aGD6FMgCxGVeNQEA62LTzQ (envelope-from ) for ; Wed, 07 Feb 2024 23:23:04 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IzV+HRu6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707344584; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=T6/HdaLP/8bMo7lf5hFyQ19gd0XI1ttyD7qWOKbxAeI=; b=Q/GZfYKDE+ZunPFjka1benLO36N/rkX5KsCcVWVpt+3QKjUd9DaDMIv4AFdnhwmrcwVR9H I94v5Gj11kbl0bixVFH9wdvOFkpeE5u4qdTbuzXQGm+SXGW1fWBnghZ9Z9WvUleGlxTIpn zeP72IB1lWVLYQ/GHRy6LHZ30gvPrL6oYoAmSf+cDpa8fz0q7TZ6Ea3xS2gbi+dQ5d+1iU e2SImcSsBgwf1C/dIAPC4KLaKI4wfwlHYGpVVro2042VeKmMxzPqS569UCI7bzFxMLUoLq Z5PevrdZ/xUl97rpTdnlvqkB+wpaLzdPygVg+X5xc6BQWOeDJq7wT92IxgVsTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IzV+HRu6; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707344584; a=rsa-sha256; cv=none; b=nlExr/Z0ouX5erh89vYPx7ZU+R2y+OZqK7L5zgQSFXt63c8ZtVdVklTWoq6Ig1pV11kKy4 SIQGuBTAsdbh0RSKqIhWHNX1kknnJX12FEfwwYUz503+jXd9BOgRepUC7bQ5u8j/SD95M+ emaLVnpe+tDzALpwANnWx8jf5r3uc6GZZ/IUPbT1WVCgDZFGym/4GYs3RyREuW4NJHKoWQ px0rIjcaK0TGYD43A6Xg+yDUvtxrAXUAQALUEDwQQNZbkZdqQsRsQcGmk6Xbmq0hA8doSn HLq+GS30vIM6Riuldgpt8SyTvvzNBrC8kLeSYKJRtZRiASVyCmmMGU8lTZM+kw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A9DA39096 for ; Wed, 7 Feb 2024 23:23:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXqJf-0007Rn-OF; Wed, 07 Feb 2024 17:22:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXqJc-0007RT-5h for guix-patches@gnu.org; Wed, 07 Feb 2024 17:22:49 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXqJb-0003RQ-U2 for guix-patches@gnu.org; Wed, 07 Feb 2024 17:22:47 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rXqJp-0003Yq-TM for guix-patches@gnu.org; Wed, 07 Feb 2024 17:23:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68412] [PATCH v2] scripts: edit: Accept generic formatting parameter. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Feb 2024 22:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68412 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 68412@debbugs.gnu.org, Simon Tournier Received: via spool by 68412-submit@debbugs.gnu.org id=B68412.170734456613661 (code B ref 68412); Wed, 07 Feb 2024 22:23:01 +0000 Received: (at 68412) by debbugs.gnu.org; 7 Feb 2024 22:22:46 +0000 Received: from localhost ([127.0.0.1]:58130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXqJa-0003YG-55 for submit@debbugs.gnu.org; Wed, 07 Feb 2024 17:22:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXqJZ-0003Y5-9w for 68412@debbugs.gnu.org; Wed, 07 Feb 2024 17:22:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXqJF-0003JB-SD; Wed, 07 Feb 2024 17:22:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=T6/HdaLP/8bMo7lf5hFyQ19gd0XI1ttyD7qWOKbxAeI=; b=IzV+HRu6CN7SFH5WlUKB xaXcPPfg8Sz8sHkiE2Z02kT06u1OCNvTF/DGsnGTsFZd1zTPFpP0IbuFn9zkcKdFty0u0jiKJVbAz AShRQP5AaU3rsyOy08t0BEcQvDahHogJecbfmDhGkUTumMLRMcHipYfIK/tHlUhH64e2eD6kICSEa ufVxYLUdrW+cVhlQfUHVQt73wIukWVyiI9d8oZKAStPyjK6iVviKdd3dwVDYIjEIyVyMalv2om8wA UmTHgFoHJTSUc7b4jrf7j3DaTsmlRc2rKYcfeE9mnxR6yoPuJutty0WWJpCJHncg8f8u3k3Upq2Pw qr9g3HRZPCA+uA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <8422a68ebc6545a4587232c404efcfee86337df3.camel@gmail.com> (Liliana Marie Prikler's message of "Mon, 29 Jan 2024 18:58:31 +0100") References: <9a666abbf1cb4b7548c1a117eaa04b0de02145ae.1705103171.git.liliana.prikler@gmail.com> <86b13fd4916ffecb1947d0879805a6d0c32542bf.1706386650.git.liliana.prikler@gmail.com> <87v87ciedd.fsf@gmail.com> <8422a68ebc6545a4587232c404efcfee86337df3.camel@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 19 =?UTF-8?Q?Pluvi=C3=B4se?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la Pulmonaire X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 07 Feb 2024 23:22:23 +0100 Message-ID: <87h6ij3of4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.04 X-Migadu-Scanner: mx13.migadu.com X-Spam-Score: -7.04 X-Migadu-Queue-Id: 3A9DA39096 X-TUID: E26bFzMIqG9y Hi, Liliana Marie Prikler skribis: >> Second, I think that using markers that can be interpreted by Bash >> shell can lead to confusion.=C2=A0 For instance, [...] >> $ export GUIX_EDITOR_LOCATION_FORMAT=3D"--line=3D${LINE} ${FILE}" >> $ echo $GUIX_EDITOR_LOCATION_FORMAT >> --line=3Dfoo bar >> --8<---------------cut here---------------end--------------->8--- >>=20 >> Well, simple quote versus double quote appears to me subtle. >>=20 >> Since it is an hard text replacement, why not remove $ and just have >> the placeholder {LINE} or {FILE}?=C2=A0 Or and ?=C2=A0 Or w= hatever >> that is not interpreted by common shells. > Because it is only a hard text replacement *for now*. We might find > that there's merit to having gash interpret these later on. I know > there's like fifty conventions for formatting strings and we have to > pick one, but I'd like to think that this isn't just a pointless > exercise in forward compatibility. It=E2=80=99s true that someone not well versed in shell or someone distract= ed could easily find themselves having ${LINE} and ${FILE} shell-expanded even though we precisely don=E2=80=99t want that. One way out would be to use a different syntax, say, %LINE% and %FILE%. With the syntax clearly different from shell variables, we=E2=80=99d avoid = those easy mistakes. WDYT? Ludo=E2=80=99.