From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aJo+D3bN2GVDXQAAe85BDQ:P1 (envelope-from ) for ; Fri, 23 Feb 2024 17:53:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aJo+D3bN2GVDXQAAe85BDQ (envelope-from ) for ; Fri, 23 Feb 2024 17:53:10 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=egjh1hMh; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708707190; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Yg4Jcgchm1eSVm/L9Uq6bvPZTgit5WH9rmuH6R2WXrs=; b=LurUqVQWKJ51005eokvmERztEO6lUfUrj+42N9kWN0KFduJVki5RONRqEMEZUitxUfn/p5 mQhiCjAt431C+WEY8T/E0ErI3IKjJH/MPPXrVosbQyyndF8Qi3/Z+8vppnCfUpcUxEGV60 BQyxozQjBlBWNQMiZQoa43GNn1DObfYaOhJ5pfO7M6wyb13rB5cywal05yZyxSLbdTUQgD m49lH8ysOktLj7DfSd4JTAmZswHsnNevKrnUzPUFYr/ClafgqhhYJO0ENC3SpcnppWHDFg hebBxXhQgaJJMl+M8XEu3OzlADHarcPflblwIx/Ls++bKp4rTiRDM6XmKYyZWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=egjh1hMh; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708707190; a=rsa-sha256; cv=none; b=M0kPFA1WSuba+raVqMBqL2XPA8DOXlUhPjWK+WW/v68bIWIr9U1EzCh4pLt5T3JM6O3n61 k7MSZq2VPd04z8eUonmw2As2jVRo9QFddoWb1MirtuNAuaK1ksPE49vVG50+o1hwmpIAt5 0dhAxJsYVDwShzk4f5UFw1LbXIBrPlnSrs69MxwqKwZ4RY+kVDIzi1PfutavJ/29t7z970 Gf9GCXGUrRh09EE0icXzz5t7mHsFIqc5c161oykJTXrl8ZKa3h+Az82IBombNQEdRr9pQD sQGTUO+HstiZIy2JTQ97HWbw51CE4e2PbUDzCwAusxh4aZJa5B5xGcOWJGTBPw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29FD5126F7 for ; Fri, 23 Feb 2024 17:53:10 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdYnG-0006UB-Sq; Fri, 23 Feb 2024 11:53:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYcG-0003BF-Vz for guix-patches@gnu.org; Fri, 23 Feb 2024 11:41:41 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdYcF-00010t-K3 for guix-patches@gnu.org; Fri, 23 Feb 2024 11:41:40 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdYcd-0004fk-4M for guix-patches@gnu.org; Fri, 23 Feb 2024 11:42:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69292] [PATCH 1/6] store: database: Remove call-with-savepoint and associated code. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Feb 2024 16:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69292 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 69292@debbugs.gnu.org, Christopher Baines Received: via spool by 69292-submit@debbugs.gnu.org id=B69292.170870647617817 (code B ref 69292); Fri, 23 Feb 2024 16:42:03 +0000 Received: (at 69292) by debbugs.gnu.org; 23 Feb 2024 16:41:16 +0000 Received: from localhost ([127.0.0.1]:52602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYbr-0004d8-Hm for submit@debbugs.gnu.org; Fri, 23 Feb 2024 11:41:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYbn-0004c2-UH for 69292@debbugs.gnu.org; Fri, 23 Feb 2024 11:41:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdYSO-0007yN-QY; Fri, 23 Feb 2024 11:31:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Yg4Jcgchm1eSVm/L9Uq6bvPZTgit5WH9rmuH6R2WXrs=; b=egjh1hMhyt9dik5xh+4f 0GtolKBQMrDmFkOanMSDUNgo886b0y5KfBag6qDUYRdMCBpuXaARj4x62LEi1WLIGsQjuHJgzvtwi 6YnTozvyagBaiAfyenhX5QiayTuV7ZpwaCBORXEdvSZqN+Tt3z5oZSi/gwCTD3GtF4nprmFIR1ohM sMR391uxHfY0n0kdZbNa2VzjSEsB96IRk6mROJYKX2jpPBi8Zc++x5pkfL85HhOw+nNlV5hAVvzWg alpLWFC2VXkvvxY8jQV3goDP5XNTdLwT8hsmEJWBp0FheqOUjPZkkOgCO9k/CHAwisP6dGLeCMt86 XKJ8IKgsoppSDQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <4b6a268daab5e0b307dff2229d551a47c9fe1ebc.1708457946.git.mail@cbaines.net> (Christopher Baines's message of "Tue, 20 Feb 2024 19:39:01 +0000") References: <87h6i3lyph.fsf@cbaines.net> <4b6a268daab5e0b307dff2229d551a47c9fe1ebc.1708457946.git.mail@cbaines.net> Date: Fri, 23 Feb 2024 17:31:20 +0100 Message-ID: <87h6hzf8h3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.08 X-Spam-Score: -2.08 X-Migadu-Queue-Id: 29FD5126F7 X-Migadu-Scanner: mx13.migadu.com X-TUID: TUQaULZHxz2c Christopher Baines skribis: > While care does need to be taken with making updates or inserts to the > ValidPaths table, I think that trying to ensure this within update-or-ins= ert > is the wrong approach. Instead, when working with the store database, onl= y one > connection should be used to make changes to the database and those chang= es > should happen in transactions that ideally begin immediately. > > This reverts commit 37545de4a3bf59611c184b31506fe9a16abe4c8b. > > * .dir-locals.el (scheme-mode): Remove entries for call-with-savepoint and > call-with-retrying-savepoint. > * guix/store/database.scm (call-with-savepoint, call-with-retrying-savepo= int): > Remove procedures. > (update-or-insert): Remove use of call-with-savepoint. > > Change-Id: I2f986e8623d8235a90c40d5f219c1292c1ab157b Okay, I trust you on this; we=E2=80=99ll have to make sure to actually start transactions at the top level. (BTW, make sure at least =E2=80=9Cmake check TESTS=3Dtests/store-database.s= cm=E2=80=9D passes for changes to this module.)