From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oLHwEtr85mVcRQAAe85BDQ:P1 (envelope-from ) for ; Tue, 05 Mar 2024 12:07:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id oLHwEtr85mVcRQAAe85BDQ (envelope-from ) for ; Tue, 05 Mar 2024 12:07:06 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QFigBCWI; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709636826; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lcd9cerCz4Ozs5UTm7UwPBpbKY7pM/bTWeIe11px2PI=; b=QuCzpttR0YNbpOT3HVRkYnOFrcmHWfC4g3dTK7ID4D1ElF3MSyWLxRgC6SWy8r+k2/VzWK VKbjXUNlsE5v7yq/e0QsNBebj+M+swGDfDBZ7XoWk1LaHhkPKwGgwYwxT8UTFeP4HrODMa eegKEmlmEj8IzG4i42qD0eyGLzUTwEAUyXLCIGWJzbaM1ljQO10ln1Cf+nR9qct9fN7oAc PrujE0BhvperdVe0G9hRWJHgS1aBIPH4cdhkpKn0FvsSYU/WaRwHB5f6HZm+PnFIlpGzAe eQfVcEkcjNJOXHyA+XdnEuRMp2xo4niCTmF3IXTuZZleEDl+Zb0DhnlUybwCRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QFigBCWI; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709636826; a=rsa-sha256; cv=none; b=H75M8qrSj7OVSs9ut5P4l4FbAXk1yi1WbqwaZIWVBCKoBtdnTdi1/U351ANELooOQ0gvuV XjrV183NlTB6HB7fct92q/JQuko8wnrzIGLcEM0/SFJRRHCARnsnEkQfH7gyY2RvugC/0G si0UN86ZlbI2ahBFHuSAmcVQLe7lB9ZwQoRgPXZ+rwWdI4bMmjWNJ8cLqcUrzWKxXni59R NMKW1JZpoUu8QNgVjvK+RDJ4ORZH7jExXja9oaA6Xx8ca1uMRsASiI4KinZeyq+x9Cvbmp eqE8tpxDF6641qDoolXenjbCu1qFPeQ6s3ef6kA6zXyVameyzj7Tgf0kTRlnRw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2DEF625643 for ; Tue, 5 Mar 2024 12:07:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhSd3-0007ew-K1; Tue, 05 Mar 2024 06:06:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhScz-0007aO-3O for guix-patches@gnu.org; Tue, 05 Mar 2024 06:06:34 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhScy-0002lS-Qv for guix-patches@gnu.org; Tue, 05 Mar 2024 06:06:32 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rhSdR-0008UW-TO for guix-patches@gnu.org; Tue, 05 Mar 2024 06:07:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69292] [PATCH 2/6] store: database: Remove with-statement and associated code. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Mar 2024 11:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69292 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Reepca Russelstein Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 69292@debbugs.gnu.org, Christopher Baines Received: via spool by 69292-submit@debbugs.gnu.org id=B69292.170963678332590 (code B ref 69292); Tue, 05 Mar 2024 11:07:01 +0000 Received: (at 69292) by debbugs.gnu.org; 5 Mar 2024 11:06:23 +0000 Received: from localhost ([127.0.0.1]:46360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhSco-0008TZ-OI for submit@debbugs.gnu.org; Tue, 05 Mar 2024 06:06:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhScn-0008TE-JP for 69292@debbugs.gnu.org; Tue, 05 Mar 2024 06:06:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhScB-0002cA-Fa; Tue, 05 Mar 2024 06:05:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lcd9cerCz4Ozs5UTm7UwPBpbKY7pM/bTWeIe11px2PI=; b=QFigBCWI9bkftXRMuJrl TU48kDvlhws5/U8ZFaAHk1eQMYs/pyEkULQZcWBlkdQ9ajcpkRuNokWTBbGBrBngWM/EAevnY/LFR 9tCyjkNd6NuGcElrb/0dOKXEbUmV8s0rHvKZRGkF4Z+5i5/HrwAYtmuPhMmWBpxmSafMcMMSwCcqr HCJiFxYP8Ky4VKByY5jPvDI8qHhlkEP5alqL/vZYSVibvjzeDgOkwtnNGpydjX+9nFLQf9gl2Ztrk 0utfjdNMYf9Bqq51OjpTejeKCNQkLQOauCV4+8QWcUnAxAB4qwjuXVylblKt3lKsCGI4OAMvnwJ45 d02qIktoFMZuEg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87ttlzqbfg.fsf@russelstein.xyz> (Reepca Russelstein's message of "Fri, 23 Feb 2024 12:32:03 -0600") References: <4b6a268daab5e0b307dff2229d551a47c9fe1ebc.1708457946.git.mail@cbaines.net> <878r3bf8aw.fsf@gnu.org> <87ttlzqbfg.fsf@russelstein.xyz> Date: Tue, 05 Mar 2024 12:05:38 +0100 Message-ID: <87h6hlc519.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -2.72 X-Spam-Score: -2.72 X-Migadu-Queue-Id: 2DEF625643 X-TUID: IeyTn2nBuozZ Hi, Reepca Russelstein skribis: >> I=E2=80=99m all for removing =E2=80=98dynamic-wind=E2=80=99, we=E2=80=99= ll have to do it to make it >> usable in a fiberized context anyway. >> >> I=E2=80=99ll let reepca comment. > > What is the proper fibers-friendly replacement for dynamic-wind, anyway, > that is "like dynamic-wind, except when suspending a fiber"? It feels > like the current interaction between dynamic-wind and fibers is more of > an accident of how the implementation works; I don't suppose fibers could > export a transparent replacement, like how it already exports a > replacement for 'sleep'? Or perhaps the underlying issue is that we > keep using 'dynamic-wind' in situations where it only makes sense to > enter or exit the dynamic extent once? Is it time to bring > 'unwind-protect' back into style? I see that fibers now has a > dynamic-wind*, should that be preferred? I=E2=80=99ve come to think that =E2=80=98dynamic-wind=E2=80=99 is a problem= atic abstraction. What we really want is to perform an effect after a normal exit or when an exception is thrown. The latter case is actually best handled with =E2=80=98with-exception-handler=E2=80=99 (this is what I did for =E2=80=98w= ith-store=E2=80=99; see commit 8ed597f4a261fe188de82cd1f5daed83dba948eb). (In Cuirass I added =E2=80=98unwind-protect=E2=80=99 at one point but in th= e end it was not so nice and I eventually removed it.) > I don't have a strong opinion on these changes, I just want to make sure > we're all aware of how guile-sqlite3's sqlite-finalize acts with cached > statements. Agreed. Thank you for chiming in! Ludo=E2=80=99.