From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id kHq3FU4jRmawSgAAqHPOHw:P1 (envelope-from ) for ; Thu, 16 May 2024 17:16:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id kHq3FU4jRmawSgAAqHPOHw (envelope-from ) for ; Thu, 16 May 2024 17:16:30 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715872590; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=/6X+oD41UxyJ5DTCpuWTlMO37fxTcCxfTcv41vbjktQ=; b=QiH4UDmtjl/pT+XK0xXohQlcNPegf1YCsnI+If9Xq/etp/dxjWRQoq7CD1aLde5Tty98VD 71ampW4NQ3CpkRTpnET3MDYEjbO/qI+FWRtAiSQcvVmQJyvNS3ctS41WZ0RHI1ThN8N/zs F9o4rH9FNEXIfOl6hX7pzZVVIF1UdBw+1lUdVluWNn1KIjpuy3RXYSKtm6+LH/eblEk0XE TsxRDTRiuzbSFlzzVdPKu/RQ7dC13Y/yKsoHfjmW8WQJWP+aDFgmZy01/AIkozoxHIsY2Y 01ENZ+GT3Ue0GIUFV4y/fbb8QCnC4C+iZgmK2i6dWbJpBH1a0fep5DZWFdcM6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715872590; a=rsa-sha256; cv=none; b=J5MwMunTsCoxjlCGEKTKagjdiwGhEn3OEcGUQI+cJUlMCI2csN9xAFXW96PY0XtMD17+5x W7FEBKfWVyaGTOB3SqzBHrWhmz69fKi8bFmx+e4dgYp9FjyJZoIW2+1jW2JYe3PBuXzIkj vQAQSkn7znJD7NEdJlSAhyGOl8i4AVS84aH3AaheQsT7DFamTiYa5coQoS/Uz6+XZxyCLb Z5oXAt1/4P8nIhw3OjhtzVLuID0j6K6sADN9ZTdxfEgHk3ry1C/RYJBC8+xWSaJb4QIGVn AGMHJGuhbQPNnuac+mKk9t6is8tONhjcZn4/VOjddAjQHrqBpSDvXGN9aHKbWw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 109692457C for ; Thu, 16 May 2024 17:16:30 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7cq4-0004Ev-OY; Thu, 16 May 2024 11:16:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7cpt-0004CE-9S for guix-patches@gnu.org; Thu, 16 May 2024 11:16:08 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7cpr-0002Se-QO for guix-patches@gnu.org; Thu, 16 May 2024 11:16:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7cpt-0007wR-S0 for guix-patches@gnu.org; Thu, 16 May 2024 11:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70985] [PATCH 3/4] gnu: cross-libc*: Raise conditions rather than returning #f. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 May 2024 15:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 70985@debbugs.gnu.org Received: via spool by 70985-submit@debbugs.gnu.org id=B70985.171587254930519 (code B ref 70985); Thu, 16 May 2024 15:16:01 +0000 Received: (at 70985) by debbugs.gnu.org; 16 May 2024 15:15:49 +0000 Received: from localhost ([127.0.0.1]:49284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7cph-0007wB-3r for submit@debbugs.gnu.org; Thu, 16 May 2024 11:15:49 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:42580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7cpf-0007w0-K9 for 70985@debbugs.gnu.org; Thu, 16 May 2024 11:15:48 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id CD08D1F83; Thu, 16 May 2024 17:15:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FsqN87hjBx67; Thu, 16 May 2024 17:15:09 +0200 (CEST) Received: from ribbon (unknown [193.50.110.250]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 538E61F41; Thu, 16 May 2024 17:15:09 +0200 (CEST) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <05efcc4bcf0dc4b270930747d215a97b2bd86761.1715871966.git.mail@cbaines.net> (Christopher Baines's message of "Thu, 16 May 2024 16:06:05 +0100") References: <3828bc238a8cc400f9686fe6856c665c31e927dd.1715871966.git.mail@cbaines.net> <05efcc4bcf0dc4b270930747d215a97b2bd86761.1715871966.git.mail@cbaines.net> Date: Thu, 16 May 2024 17:15:08 +0200 Message-ID: <87h6exbxfn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -6.87 X-Migadu-Queue-Id: 109692457C X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -6.87 X-TUID: 3Wd0Sr1lXDhb Christopher Baines writes: > As this means that the error will be clearer for targets which are > unsupported. > > * gnu/packages/cross-base.scm (cross-libc*): Raise conditions rather than > returning #f. > > Change-Id: I820780ad738d85a98950de5608f3019e961ff7c8 [...] > - (else #f))) > + (else > + (raise (condition > + (&package-unsupported-target-error > + (package libc) > + (target target))))))) What I'm unsure is whether this works with libc-less triplets such as =E2=80=98avr=E2=80=99 or =E2=80=98or1k-elf=E2=80=99. If it does, LGTM. Ludo=E2=80=99.