all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#65031] [PATCH] gnu: Add syncplay.
@ 2023-08-03  4:35 aurtzy
  2023-09-05 14:54 ` Maxim Cournoyer
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: aurtzy @ 2023-08-03  4:35 UTC (permalink / raw)
  To: 65031; +Cc: aurtzy

* gnu/packages/networking.scm (syncplay): New variable.
---
 gnu/packages/networking.scm | 52 +++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 488d015107..10eb19e980 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -60,6 +60,7 @@
 ;;; Copyright © 2023 Bruno Victal <mirai@makinata.eu>
 ;;; Copyright © 2023 Yovan Naumovski <yovan@gorski.stream>
 ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
+;;; Copyright © 2023 aurtzy <aurtzy@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4644,3 +4645,54 @@ (define-public dropwatch
 recording packets that are dropped by the kernel.  It provides the commands
 @command{dropwatch} and @command{dwdump}.")
     (license license:gpl2+)))
+
+(define-public syncplay
+  (package
+    (name "syncplay")
+    (version "1.7.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/Syncplay/syncplay.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "061kpnb48lad8rr8v58xac33mwpbrixfbhn7d0xa63zpxg43bvsd"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:imported-modules `(,@%gnu-build-system-modules (guix build
+                                                                  qt-utils)
+                                (guix build utils))
+           #:modules '((guix build gnu-build-system)
+                       (guix build qt-utils)
+                       (guix build utils))
+           #:make-flags #~`("DESTDIR=" ,(string-append "PREFIX="
+                                                       (assoc-ref %outputs
+                                                                  "out")))
+           #:phases #~(modify-phases %standard-phases
+                        (delete 'configure)
+                        (delete 'build)
+                        (delete 'check)
+                        (add-after 'install 'wrap-qt
+                          (lambda* (#:key inputs #:allow-other-keys)
+                            (wrap-qt-program "syncplay"
+                                             #:output #$output
+                                             #:inputs inputs))))))
+    (inputs (list bash-minimal qtwayland-5))
+    (propagated-inputs (list python
+                             python-service-identity
+                             python-twisted
+                             python-pyside-2
+                             python-certifi
+                             python-idna))
+    (home-page "https://syncplay.pl")
+    (synopsis "Client/server to synchronize media playback on many computers")
+    (description
+     "Syncplay is a solution to synchronize video playback across multiple
+instances of media players over the Internet.  When one person pauses/unpauses
+playback or skips to a position in the video, this is replicated across all
+media players connected to the same server and in the same \"room\" (viewing
+session).  A built-in text chat for discussing the synced media is also
+included for convenience.")
+    (license license:asl2.0)))
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#65031] [PATCH] gnu: Add syncplay.
  2023-08-03  4:35 [bug#65031] [PATCH] gnu: Add syncplay aurtzy
@ 2023-09-05 14:54 ` Maxim Cournoyer
  2023-09-21 19:37 ` [bug#65031] [PATCH v2] " aurtzy
  2024-06-29 21:37 ` [bug#65031] [PATCH v3] " aurtzy
  2 siblings, 0 replies; 7+ messages in thread
From: Maxim Cournoyer @ 2023-09-05 14:54 UTC (permalink / raw)
  To: aurtzy; +Cc: 65031

Hi,

aurtzy <aurtzy@gmail.com> writes:

> * gnu/packages/networking.scm (syncplay): New variable.
> ---
>  gnu/packages/networking.scm | 52 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
>
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 488d015107..10eb19e980 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -60,6 +60,7 @@
>  ;;; Copyright © 2023 Bruno Victal <mirai@makinata.eu>
>  ;;; Copyright © 2023 Yovan Naumovski <yovan@gorski.stream>
>  ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
> +;;; Copyright © 2023 aurtzy <aurtzy@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4644,3 +4645,54 @@ (define-public dropwatch
>  recording packets that are dropped by the kernel.  It provides the commands
>  @command{dropwatch} and @command{dwdump}.")
>      (license license:gpl2+)))
> +
> +(define-public syncplay
> +  (package
> +    (name "syncplay")
> +    (version "1.7.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/Syncplay/syncplay.git")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "061kpnb48lad8rr8v58xac33mwpbrixfbhn7d0xa63zpxg43bvsd"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:imported-modules `(,@%gnu-build-system-modules (guix build
> +                                                                  qt-utils)
> +                                (guix build utils))
> +           #:modules '((guix build gnu-build-system)
> +                       (guix build qt-utils)
> +                       (guix build utils))
> +           #:make-flags #~`("DESTDIR=" ,(string-append "PREFIX="
> +                                                       (assoc-ref %outputs
> +                                                                  "out")))
> +           #:phases #~(modify-phases %standard-phases
> +                        (delete 'configure)
> +                        (delete 'build)
> +                        (delete 'check)
> +                        (add-after 'install 'wrap-qt
> +                          (lambda* (#:key inputs #:allow-other-keys)
> +                            (wrap-qt-program "syncplay"
> +                                             #:output #$output
> +                                             #:inputs inputs))))))
> +    (inputs (list bash-minimal qtwayland-5))

Is it compatible with Qt 6?  To try it, replace qtwayland-5 with
qtwayland, and specify a #:qtbase qtbase argument.

> +    (propagated-inputs (list python
> +                             python-service-identity
> +                             python-twisted
> +                             python-pyside-2
> +                             python-certifi
> +                             python-idna))

These should be inputs, not propagated-inputs, unless it can be used as
a library?  Also, please sort the inputs alphabetically.

> +    (home-page "https://syncplay.pl")
> +    (synopsis "Client/server to synchronize media playback on many computers")
> +    (description
> +     "Syncplay is a solution to synchronize video playback across multiple
> +instances of media players over the Internet.  When one person pauses/unpauses
> +playback or skips to a position in the video, this is replicated across all
> +media players connected to the same server and in the same \"room\" (viewing
> +session).  A built-in text chat for discussing the synced media is also
> +included for convenience.")
> +    (license license:asl2.0)))

The rest LGTM.  Could you please send a v2?

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#65031] [PATCH v2] gnu: Add syncplay.
  2023-08-03  4:35 [bug#65031] [PATCH] gnu: Add syncplay aurtzy
  2023-09-05 14:54 ` Maxim Cournoyer
@ 2023-09-21 19:37 ` aurtzy
  2024-06-29 21:37 ` [bug#65031] [PATCH v3] " aurtzy
  2 siblings, 0 replies; 7+ messages in thread
From: aurtzy @ 2023-09-21 19:37 UTC (permalink / raw)
  To: 65031; +Cc: aurtzy

* gnu/packages/networking.scm (syncplay): New variable.
* gnu/packages/patches/syncplay-fix-typeerror.patch: New file.
---

> Is it compatible with Qt 6?  To try it, replace qtwayland-5 with
> qtwayland, and specify a #:qtbase qtbase argument.

Looks like it is!  #:qtbase doesn't seem to be supported by gnu-build-system or
python-build-system (switched to the latter for this v2; elaborated further
below) and I had to make a few other adjustments to get it working, so I may
need advice if I've missed anything here.

A patch has been added to fix a Qt 6 issue causing Syncplay to crash.

> These should be inputs, not propagated-inputs, unless it can be used as
> a library?  Also, please sort the inputs alphabetically.

Fixed; not a library.  It appears I was using an inappropriate build system for
this package - I originally made them propagated because gnu-build-system wasn't
doing whatever wrapping python-build-system does to make the inputs available,
so this v2 uses python-build-system instead now.

Best,

aurtzy

 gnu/packages/networking.scm                   | 54 +++++++++++++++++++
 .../patches/syncplay-fix-typeerror.patch      | 25 +++++++++
 2 files changed, 79 insertions(+)
 create mode 100644 gnu/packages/patches/syncplay-fix-typeerror.patch

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index c1cab1fe0d..a7fde61ea8 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -60,6 +60,7 @@
 ;;; Copyright © 2023 Bruno Victal <mirai@makinata.eu>
 ;;; Copyright © 2023 Yovan Naumovski <yovan@gorski.stream>
 ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
+;;; Copyright © 2023 aurtzy <aurtzy@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4700,3 +4701,56 @@ (define-public dropwatch
 recording packets that are dropped by the kernel.  It provides the commands
 @command{dropwatch} and @command{dwdump}.")
     (license license:gpl2+)))
+
+(define-public syncplay
+  (package
+    (name "syncplay")
+    (version "1.7.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/Syncplay/syncplay.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "061kpnb48lad8rr8v58xac33mwpbrixfbhn7d0xa63zpxg43bvsd"))
+              (patches (search-patches "syncplay-fix-typeerror.patch"))))
+    (build-system python-build-system)
+    (arguments
+     (list #:imported-modules `(,@%python-build-system-modules
+                                (guix build qt-utils)
+                                (guix build utils))
+           #:modules '((guix build python-build-system)
+                       (guix build qt-utils)
+                       (guix build utils))
+           #:phases #~(modify-phases %standard-phases
+                        (delete 'check)
+                        (replace 'install
+                          (lambda _
+                            (invoke "make" "install" "DESTDIR="
+                                    (string-append "PREFIX="
+                                                   (assoc-ref %outputs "out")))))
+                        (add-after 'install 'wrap-qt
+                          (lambda* (#:key inputs #:allow-other-keys)
+                            (wrap-qt-program "syncplay"
+                                             #:output #$output
+                                             #:inputs inputs
+                                             #:qt-major-version "6"))))))
+    (native-inputs (list python-pyside-6))
+    (inputs (list bash-minimal
+                  python-certifi
+                  python-idna
+                  python-service-identity
+                  python-twisted
+                  qtwayland))
+    (home-page "https://syncplay.pl")
+    (synopsis "Client/server to synchronize media playback on many computers")
+    (description
+     "Syncplay is a solution to synchronize video playback across multiple
+instances of media players over the Internet.  When one person pauses/unpauses
+playback or skips to a position in the video, this is replicated across all
+media players connected to the same server and in the same \"room\" (viewing
+session).  A built-in text chat for discussing the synced media is also
+included for convenience.")
+    (license license:asl2.0)))
diff --git a/gnu/packages/patches/syncplay-fix-typeerror.patch b/gnu/packages/patches/syncplay-fix-typeerror.patch
new file mode 100644
index 0000000000..6b1168a0e9
--- /dev/null
+++ b/gnu/packages/patches/syncplay-fix-typeerror.patch
@@ -0,0 +1,25 @@
+From b62b038cdf58c54205987dfc52ebf228505ad03b Mon Sep 17 00:00:00 2001
+From: Etoh <etoh@syncplay.pl>
+Date: Tue, 11 Apr 2023 20:22:52 +0100
+Subject: [PATCH] Fix ArchLinux GUI TypeError (#600)
+
+---
+ syncplay/ui/gui.py | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/syncplay/ui/gui.py b/syncplay/ui/gui.py
+index 7c100542..ca0f5d4a 100755
+--- a/syncplay/ui/gui.py
++++ b/syncplay/ui/gui.py
+@@ -2106,7 +2106,10 @@ def __init__(self, passedBar=None):
+         if isMacOS():
+             self.setWindowFlags(self.windowFlags())
+         else:
+-            self.setWindowFlags(self.windowFlags() & Qt.AA_DontUseNativeMenuBar)
++            try:    
++            	self.setWindowFlags(self.windowFlags() & Qt.AA_DontUseNativeMenuBar)
++            except TypeError:
++            	self.setWindowFlags(self.windowFlags())
+         self.setWindowTitle("Syncplay v" + version + revision)
+         self.mainLayout = QtWidgets.QVBoxLayout()
+         self.addTopLayout(self)
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#65031] [PATCH v3] gnu: Add syncplay.
  2023-08-03  4:35 [bug#65031] [PATCH] gnu: Add syncplay aurtzy
  2023-09-05 14:54 ` Maxim Cournoyer
  2023-09-21 19:37 ` [bug#65031] [PATCH v2] " aurtzy
@ 2024-06-29 21:37 ` aurtzy
  2024-07-10  2:46   ` Maxim Cournoyer
  2 siblings, 1 reply; 7+ messages in thread
From: aurtzy @ 2024-06-29 21:37 UTC (permalink / raw)
  To: 65031; +Cc: aurtzy, aurtzy, Maxim Cournoyer

* gnu/packages/video.scm (syncplay): New variable.

Change-Id: I72cdfa3db2b4b7ef6c3ef0b8585d138c272046a7
---

Hi Maxim,

Just got around to looking at this package again with a new patch as things
have changed since my last reply (and I didn't cc you before, oops..).

In addition to addressing your initial review, notable changes from v2
include:

- Update to current latest version of Syncplay (1.7.3).
- Patch is no longer needed.
- This patch puts syncplay in (gnu packages video) instead of the previous
  (gnu packages networking) since the latter seemed more concerned with
  system-level networking.  Does this make sense?

> > Is it compatible with Qt 6?  To try it, replace qtwayland-5 with
> > qtwayland, and specify a #:qtbase qtbase argument.
>
> Looks like it is!  #:qtbase doesn't seem to be supported by gnu-build-system or
> python-build-system (switched to the latter for this v2; elaborated further
> below) and I had to make a few other adjustments to get it working, so I may
> need advice if I've missed anything here.
>
> A patch has been added to fix a Qt 6 issue causing Syncplay to crash.
>
> > These should be inputs, not propagated-inputs, unless it can be used as
> > a library?  Also, please sort the inputs alphabetically.
>
> Fixed; not a library.  It appears I was using an inappropriate build system for
> this package - I originally made them propagated because gnu-build-system wasn't
> doing whatever wrapping python-build-system does to make the inputs available,
> so this v2 uses python-build-system instead now.
>
> Best,
>
> aurtzy

Cheers,

aurtzy

gnu/packages/video.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 411ad4c2bf..57a05f3eff 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -68,6 +68,7 @@
 ;;; Copyright © 2023 Saku Laesvuori <saku@laesvuori.fi>
 ;;; Copyright © 2023 Jaeme Sifat <jaeme@runbox.com>
 ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
+;;; Copyright © 2024 aurtzy <aurtzy@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6349,3 +6350,56 @@ (define-public svtplay-dl
 broadcasters including SVT Play, Sveriges Radio, TV4 Play, along with many
 others.")
     (license license:expat)))
+
+(define-public syncplay
+  (package
+    (name "syncplay")
+    (version "1.7.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Syncplay/syncplay")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "08bgndszja4n2kql2qmzl6qrzawxvcwmywsc69lq0dzjnpdk96la"))))
+    (build-system python-build-system)
+    (arguments
+     (list
+      #:imported-modules `(,@%python-build-system-modules
+                           (guix build qt-utils)
+                           (guix build utils))
+      #:modules '((guix build python-build-system)
+                  (guix build qt-utils)
+                  (guix build utils))
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'check)
+                   (replace 'install
+                     (lambda _
+                       (invoke "make" "install" "DESTDIR="
+                               (string-append "PREFIX="
+                                              #$output))))
+                   (add-after 'install 'wrap-qt
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       (wrap-qt-program "syncplay"
+                                        #:output #$output
+                                        #:inputs inputs
+                                        #:qt-major-version "6"))))))
+    (native-inputs (list python-pyside-6))
+    (inputs (list bash-minimal
+                  python-certifi
+                  python-idna
+                  python-service-identity
+                  python-twisted
+                  qtwayland))
+    (home-page "https://syncplay.pl")
+    (synopsis "Client/server to synchronize media playback on many computers")
+    (description
+     "Syncplay is a solution to synchronize video playback across multiple
+instances of media players over the Internet.  When one person pauses/unpauses
+playback or skips to a position in the video, this is replicated across all
+media players connected to the same server and in the same \"room\" (viewing
+session).  A built-in text chat for discussing the synced media is also
+included for convenience.")
+    (license license:asl2.0)))

base-commit: 78b881722f08325c76096557313a0faee847c66f
-- 
2.45.2





^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#65031] [PATCH v3] gnu: Add syncplay.
  2024-06-29 21:37 ` [bug#65031] [PATCH v3] " aurtzy
@ 2024-07-10  2:46   ` Maxim Cournoyer
  2024-09-12  2:25     ` [bug#65031] [PATCH] " aurtzy
  0 siblings, 1 reply; 7+ messages in thread
From: Maxim Cournoyer @ 2024-07-10  2:46 UTC (permalink / raw)
  To: aurtzy; +Cc: 65031

Hello!

aurtzy <aurtzy@gmail.com> writes:

> * gnu/packages/video.scm (syncplay): New variable.
>
> Change-Id: I72cdfa3db2b4b7ef6c3ef0b8585d138c272046a7
> ---
>
> Hi Maxim,
>
> Just got around to looking at this package again with a new patch as things
> have changed since my last reply (and I didn't cc you before, oops..).
>
> In addition to addressing your initial review, notable changes from v2
> include:
>
> - Update to current latest version of Syncplay (1.7.3).
> - Patch is no longer needed.
> - This patch puts syncplay in (gnu packages video) instead of the previous
>   (gnu packages networking) since the latter seemed more concerned with
>   system-level networking.  Does this make sense?

It does make sense :-).  This sounds good.

[...]

> gnu/packages/video.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 54 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 411ad4c2bf..57a05f3eff 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -68,6 +68,7 @@
>  ;;; Copyright © 2023 Saku Laesvuori <saku@laesvuori.fi>
>  ;;; Copyright © 2023 Jaeme Sifat <jaeme@runbox.com>
>  ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
> +;;; Copyright © 2024 aurtzy <aurtzy@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -6349,3 +6350,56 @@ (define-public svtplay-dl
>  broadcasters including SVT Play, Sveriges Radio, TV4 Play, along with many
>  others.")
>      (license license:expat)))
> +
> +(define-public syncplay
> +  (package
> +    (name "syncplay")
> +    (version "1.7.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/Syncplay/syncplay")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "08bgndszja4n2kql2qmzl6qrzawxvcwmywsc69lq0dzjnpdk96la"))))
> +    (build-system python-build-system)
> +    (arguments
> +     (list
> +      #:imported-modules `(,@%python-build-system-modules
> +                           (guix build qt-utils)
> +                           (guix build utils))
> +      #:modules '((guix build python-build-system)
> +                  (guix build qt-utils)
> +                  (guix build utils))
> +      #:phases #~(modify-phases %standard-phases
> +                   (delete 'check)
> +                   (replace 'install
> +                     (lambda _
> +                       (invoke "make" "install" "DESTDIR="
> +                               (string-append "PREFIX="
> +                                              #$output))))
> +                   (add-after 'install 'wrap-qt
> +                     (lambda* (#:key inputs #:allow-other-keys)
> +                       (wrap-qt-program "syncplay"
> +                                        #:output #$output
> +                                        #:inputs inputs
> +                                        #:qt-major-version "6"))))))
> +    (native-inputs (list python-pyside-6))
> +    (inputs (list bash-minimal
> +                  python-certifi
> +                  python-idna
> +                  python-service-identity
> +                  python-twisted
> +                  qtwayland))
> +    (home-page "https://syncplay.pl")
> +    (synopsis "Client/server to synchronize media playback on many computers")
> +    (description
> +     "Syncplay is a solution to synchronize video playback across multiple
> +instances of media players over the Internet.  When one person pauses/unpauses
> +playback or skips to a position in the video, this is replicated across all
> +media players connected to the same server and in the same \"room\" (viewing
> +session).  A built-in text chat for discussing the synced media is also
> +included for convenience.")
> +    (license license:asl2.0)))
>
> base-commit: 78b881722f08325c76096557313a0faee847c66f

This looks well crafted!  Thank you!

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#65031] [PATCH] gnu: Add syncplay.
  2024-07-10  2:46   ` Maxim Cournoyer
@ 2024-09-12  2:25     ` aurtzy
  2024-09-13 16:08       ` bug#65031: " Maxim Cournoyer
  0 siblings, 1 reply; 7+ messages in thread
From: aurtzy @ 2024-09-12  2:25 UTC (permalink / raw)
  To: 65031; +Cc: aurtzy, Maxim Cournoyer

Hi Maxim,

Small poke on this issue - is there anything else I can help with to get 
this merged?

Cheers,

aurtzy

 > Hello!
 >
 > aurtzy <aurtzy@gmail.com> writes:
 >
 > > * gnu/packages/video.scm (syncplay): New variable.
 > >
 > > Change-Id: I72cdfa3db2b4b7ef6c3ef0b8585d138c272046a7
 > > ---
 > >
 > > Hi Maxim,
 > >
 > > Just got around to looking at this package again with a new patch 
as things
 > > have changed since my last reply (and I didn't cc you before, oops..).
 > >
 > > In addition to addressing your initial review, notable changes from v2
 > > include:
 > >
 > > - Update to current latest version of Syncplay (1.7.3).
 > > - Patch is no longer needed.
 > > - This patch puts syncplay in (gnu packages video) instead of the 
previous
 > > (gnu packages networking) since the latter seemed more concerned with
 > > system-level networking. Does this make sense?
 >
 > It does make sense :-). This sounds good.
 >
 > [...]
 >
 > > gnu/packages/video.scm | 54 ++++++++++++++++++++++++++++++++++++++++++
 > > 1 file changed, 54 insertions(+)
 > >
 > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
 > > index 411ad4c2bf..57a05f3eff 100644
 > > --- a/gnu/packages/video.scm
 > > +++ b/gnu/packages/video.scm
 > > @@ -68,6 +68,7 @@
 > > ;;; Copyright © 2023 Saku Laesvuori <saku@laesvuori.fi>
 > > ;;; Copyright © 2023 Jaeme Sifat <jaeme@runbox.com>
 > > ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
 > > +;;; Copyright © 2024 aurtzy <aurtzy@gmail.com>
 > > ;;;
 > > ;;; This file is part of GNU Guix.
 > > ;;;
 > > @@ -6349,3 +6350,56 @@ (define-public svtplay-dl
 > > broadcasters including SVT Play, Sveriges Radio, TV4 Play, along 
with many
 > > others.")
 > > (license license:expat)))
 > > +
 > > +(define-public syncplay
 > > + (package
 > > + (name "syncplay")
 > > + (version "1.7.3")
 > > + (source
 > > + (origin
 > > + (method git-fetch)
 > > + (uri (git-reference
 > > + (url "https://github.com/Syncplay/syncplay")
 > > + (commit (string-append "v" version))))
 > > + (file-name (git-file-name name version))
 > > + (sha256
 > > + (base32 "08bgndszja4n2kql2qmzl6qrzawxvcwmywsc69lq0dzjnpdk96la"))))
 > > + (build-system python-build-system)
 > > + (arguments
 > > + (list
 > > + #:imported-modules `(,@%python-build-system-modules
 > > + (guix build qt-utils)
 > > + (guix build utils))
 > > + #:modules '((guix build python-build-system)
 > > + (guix build qt-utils)
 > > + (guix build utils))
 > > + #:phases #~(modify-phases %standard-phases
 > > + (delete 'check)
 > > + (replace 'install
 > > + (lambda _
 > > + (invoke "make" "install" "DESTDIR="
 > > + (string-append "PREFIX="
 > > + #$output))))
 > > + (add-after 'install 'wrap-qt
 > > + (lambda* (#:key inputs #:allow-other-keys)
 > > + (wrap-qt-program "syncplay"
 > > + #:output #$output
 > > + #:inputs inputs
 > > + #:qt-major-version "6"))))))
 > > + (native-inputs (list python-pyside-6))
 > > + (inputs (list bash-minimal
 > > + python-certifi
 > > + python-idna
 > > + python-service-identity
 > > + python-twisted
 > > + qtwayland))
 > > + (home-page "https://syncplay.pl")
 > > + (synopsis "Client/server to synchronize media playback on many 
computers")
 > > + (description
 > > + "Syncplay is a solution to synchronize video playback across multiple
 > > +instances of media players over the Internet. When one person 
pauses/unpauses
 > > +playback or skips to a position in the video, this is replicated 
across all
 > > +media players connected to the same server and in the same 
\"room\" (viewing
 > > +session). A built-in text chat for discussing the synced media is also
 > > +included for convenience.")
 > > + (license license:asl2.0)))
 > >
 > > base-commit: 78b881722f08325c76096557313a0faee847c66f
 >
 > This looks well crafted! Thank you!
 >
 > Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#65031: [PATCH] gnu: Add syncplay.
  2024-09-12  2:25     ` [bug#65031] [PATCH] " aurtzy
@ 2024-09-13 16:08       ` Maxim Cournoyer
  0 siblings, 0 replies; 7+ messages in thread
From: Maxim Cournoyer @ 2024-09-13 16:08 UTC (permalink / raw)
  To: aurtzy; +Cc: 65031-done

Hello!

aurtzy <aurtzy@gmail.com> writes:

> Hi Maxim,
>
> Small poke on this issue - is there anything else I can help with to
> get this merged?

Sorry for the delay!  I've now merged it.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-09-13 16:10 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-03  4:35 [bug#65031] [PATCH] gnu: Add syncplay aurtzy
2023-09-05 14:54 ` Maxim Cournoyer
2023-09-21 19:37 ` [bug#65031] [PATCH v2] " aurtzy
2024-06-29 21:37 ` [bug#65031] [PATCH v3] " aurtzy
2024-07-10  2:46   ` Maxim Cournoyer
2024-09-12  2:25     ` [bug#65031] [PATCH] " aurtzy
2024-09-13 16:08       ` bug#65031: " Maxim Cournoyer

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.