From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id oFGbDsbT6mZohwAA62LTzQ:P1 (envelope-from ) for ; Wed, 18 Sep 2024 13:21:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id oFGbDsbT6mZohwAA62LTzQ (envelope-from ) for ; Wed, 18 Sep 2024 15:21:10 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=XZrurFZE; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=cqdZ7JQu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726665670; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pS+pbTgw9TR6UxE02BiflUecDj1N4JcEjVEAiMqYIKI=; b=l1R8bCHRslfOCtYwxIMXEYr3ffQSlV5VJN2mLmnmYTs+ZYSf8S3Fr03WW0Y1obsFvMPy4y 9MhVDt5MQZ2PsaxVBq9y2WTQBecrmHcFsCimJWqTBGTQNiVQeK9c8FpE8KxG1G36NkL0zi ekK6Pzb3jyPaXbRRgsLYN0Z4TbSAVDBnDBzkoJvPFPEeHQr9+BjWx7XAIdlYUXWBBWhzdq b1JDnyTZp1fVIvWxu2cN4bwE89oU59aTFMFZMPBWbwUy0VdF19erngAloxSgFJj9HBiMGA bM5dgmuyQhewqQkqwrbITehXm6wIUJMLLZiZOdREgzW/P9qQ6fvlOwxHnRO+Ag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=XZrurFZE; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=cqdZ7JQu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726665670; a=rsa-sha256; cv=none; b=HoAuYng0wWDMSszOqEYGeXUPdjV0/rfZ5m+QIeXlkmqiCgNGB8Tnf1nGtu9ZWgACEMqs99 DWsgJlW5epDeoabo8g9yWe/0BY+r7i/27n7iilVlmfEte0CRwx9aA+OGUeoETxX7GdAT/A UBwicXc4PXP/buhGwe0vaNDBZmB/IcggrfQRN6R950R2yPasy2aqab23PG/I/M4DOEXF2O R4ajm5pYnr+8DkI+gObd5/HKvmwNvagPfRwSFulh5tRqGhABPnGGas0swbPvYf+sShBbNm LyVbTQ/qK7MrbZTEtzwl/1iV1oR29rQ05sa6VFhhAobj5WYJJjFGKzWoTNtm/A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0164476F04 for ; Wed, 18 Sep 2024 15:21:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1squbw-0003iH-9W; Wed, 18 Sep 2024 09:20:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1squbu-0003cv-Bh for guix-patches@gnu.org; Wed, 18 Sep 2024 09:20:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1squbu-0005nd-2p for guix-patches@gnu.org; Wed, 18 Sep 2024 09:20:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=pS+pbTgw9TR6UxE02BiflUecDj1N4JcEjVEAiMqYIKI=; b=XZrurFZErqIbYdvG+oCKBIsWQEpUs//2iUzrvM9M2lI1mjt+fabqR5pnBwydvQE7quSjE/Wx5vmMUvOW6ESBgGxzRyUW82MGe9MQAoA3GniWl4dKqjfEdX2F/IKJPHpAdqLltSS4vs2FN61OHK8+1xAaZyWtZG589MCZKhFraI9XjuJ79DIK9E3/Qs7SBHPVRBP+eZDjdQSqG1s4oSvs+yEP2sKeFoVTcJmjssSOTBKUhATjnBDNQ1F8kId56jRvwJwTy42JCSDjUa5F6gJSR+ilF4PMZkaLGC4T2wrlJWWhhwhBCIzVeZdzDw1BXVRq4TLUmkR5jJBQH9cbjpRePw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1squc9-0003bg-Ts for guix-patches@gnu.org; Wed, 18 Sep 2024 09:21:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] Adding JPM package for Janet Resent-From: "Suhail Singh" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Sep 2024 13:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Omar Bassam Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172666562613667 (code B ref 72925); Wed, 18 Sep 2024 13:21:01 +0000 Received: (at 72925) by debbugs.gnu.org; 18 Sep 2024 13:20:26 +0000 Received: from localhost ([127.0.0.1]:57276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1squba-0003Y1-5I for submit@debbugs.gnu.org; Wed, 18 Sep 2024 09:20:26 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:53752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1squbX-0003SO-HT for 72925@debbugs.gnu.org; Wed, 18 Sep 2024 09:20:24 -0400 Received: by mail-qt1-f195.google.com with SMTP id d75a77b69052e-4583083d019so38487211cf.3 for <72925@debbugs.gnu.org>; Wed, 18 Sep 2024 06:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726665541; x=1727270341; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pS+pbTgw9TR6UxE02BiflUecDj1N4JcEjVEAiMqYIKI=; b=cqdZ7JQufeHcWeIdheT/CTxzmR47xBbYuS+rrijtnmhZ0VpW45Zm6j9hFtOk5g5Qqz mcNGwzmZXOlDCmrsv9avNHjoW7d2QxC1nOv29Qr9dCEvOqajcF9/5C7RU8BT5s9qVZCL yvdciRwPaVtekIIp1bqvk3cbFmJVU6Aj0a7g5/Qy/TV5tYqwVOjeCLHN8BrCZeINeUGS /4PouJaiHEln+O/jzFesSIJ+QqChYHY0D4ja/WWFf6WU8hjX5E0Bh7hTid+psBUexAnx zEUqvp4Q/dHYQelnTfRZx+1FykFwVQ1+dmxcAl/eK6RDIM08xbeetOw3dgeakk9iPmUR nVUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726665541; x=1727270341; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pS+pbTgw9TR6UxE02BiflUecDj1N4JcEjVEAiMqYIKI=; b=Jem+HoNR3N4ZZgtUpfoNzgkOPdev8hNjWjV/QHjfecrAVNY2c8oY64nmMc1Q3n3eru 5KHZC0I7dw3ccyitrN3rMfOXwO0GlhrjXrkvmMANpqpD9rCduK7qC1eUaNrJd08cODZm p5lpXI8wLZvWWA8B818IkTCDyN93sGpmfqMKpzBsIQQuRYnUYOYx1SXUj8YB7FKEeUX2 1tCS7G4mFkIzb581rLLA6EzPTefM9Gnk+PWRL1f1L3YVxUotwtPIyEfWTacZ5jcZ3Ibc z5I6FUYcly1x9KRVWkuUlVEa7pr3+9BNQcbKtkzCRNxQt9ogDoYyydWYIRRxm78EossB enRw== X-Gm-Message-State: AOJu0YzC3qvL177b9PVGMp0vJ+r2ETXDZCNHhXPXMNf5QgiiRe8D2SVR SHfaMWsuyAYtSheY/9hrsflYd3duMyt+E07raaNbJtdKmfrk/qAt X-Google-Smtp-Source: AGHT+IHE89ldymye99AdfTzkZ1r6jczldM5bPqO/PksBAgbHeND3DiXHqp/6v/MB9Ur4Uw1q7+h2zg== X-Received: by 2002:ac8:59d3:0:b0:458:34df:1e65 with SMTP id d75a77b69052e-4599d29f812mr272831381cf.44.1726665541476; Wed, 18 Sep 2024 06:19:01 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-459aacf611bsm48605841cf.70.2024.09.18.06.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2024 06:19:01 -0700 (PDT) From: "Suhail Singh" In-Reply-To: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> (Omar Bassam's message of "Thu, 5 Sep 2024 17:50:02 +0300") References: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> Date: Wed, 18 Sep 2024 09:18:42 -0400 Message-ID: <87h6adyua5.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 0164476F04 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.94 X-Migadu-Spam-Score: -8.94 X-TUID: RegC4On0zCrP Hi Omar, Thank you for submitting this patch. A few comments: Omar Bassam writes: > Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd > --- > gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm > index 5d4399f145..96698d375d 100644 Could you please update the reroll-count when you send amendments to the patch? IIUC, this version should have been v2. > +(define-public jpm > + (package > + (name "jpm") > + (version "1.1.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/janet-lang/jpm.git") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l")))) > + (build-system trivial-build-system) > ... > + (substitute* (string-append %output "/bin/jpm") > + (("/usr/bin/env janet") > + (string-append #$janet "/bin/janet"))) Is my understanding correct that you're updating the shebang line here? If so, would it be better to use the copy-build-system instead? If not, could you please elaborate? If copy-build-system does indeed turn out to be better suited, could you please send v3 of the patch? -- Suhail